[issue16038] ftplib: unlimited readline() from connection
Radu Voicilas added the comment: I'm a little confused about this patch. Please correct me if I'm wrong, but fp.readline([size + 1]) should return a line of length at most size + 1. This means that the check len(line) size will always be true when reading a line that has a length greater than self.maxline. Also, wouldn't it make more sense to have the line that logs stuff in debugging mode be before raising a LineTooLong exception ? This way you have the option of actually seeing the line. -- nosy: +raduv ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16038 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18652] Add itertools.first_true (return first true item in iterable)
Changes by Radu Voicilas radu.voici...@gmail.com: -- nosy: +raduv ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18652 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17491] Consolidate traceback.format_tb and traceback.print_tb
Radu Voicilas added the comment: Is there anything else that I have to do in order for this patch to be looked at ? I am holding off a similar one for print_exception vs. format_exception -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17491 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17502] unittest.mock: side_effect iterators ignore DEFAULT
Changes by Radu Voicilas radu.voici...@gmail.com: -- nosy: +raduv ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17502 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17504] Dropping duplicated docstring explanation of what Mocks' side_effect does.
New submission from Radu Voicilas: Seems like there's a duplicated explanation in unittest.mock.Mock's docstring of what side_effect does. The attached patch should take care of that, if I'm not interpreting it wrong and it's actually on purpose there. -- components: Library (Lib) files: drop_side_effect_docstring_duplicate.diff keywords: patch messages: 184849 nosy: michael.foord, raduv priority: normal severity: normal status: open title: Dropping duplicated docstring explanation of what Mocks' side_effect does. type: enhancement versions: Python 3.4 Added file: http://bugs.python.org/file29526/drop_side_effect_docstring_duplicate.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17504 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17491] Consolidate traceback.format_tb and traceback.print_tb
New submission from Radu Voicilas: This is a patch that consolidates the implementation of traceback.format_tb and traceback.print_tb into one common internal function traceback._get_tb. The current implementations are almost identical, except that the print_tb() ones also prints to a file ... Now, I don't really know what the Python developers feel about this kind of cleanups which doesn't really add any value for the end user. I've seen projects where this kind of patches are not accepted because of this. IMHO, making code more readable and reducing duplication is always a good thing. -- components: Library (Lib) files: consolidate_tb_functions.diff keywords: patch messages: 184725 nosy: raduv priority: normal severity: normal status: open title: Consolidate traceback.format_tb and traceback.print_tb type: enhancement versions: Python 3.4 Added file: http://bugs.python.org/file29497/consolidate_tb_functions.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17491 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17464] Improve Test Coverage Of Pydoc
Radu Voicilas added the comment: Hi, Here are some small comments to your otherwise good to have patch: -- assertEquals has been deprecated in favor of assertEqual, and usually it's great to be consistent across the test suite -- likewise maxDiff should be max_diff mainly because of consistency and because of pep8's naming styles -- self.temp_dir is never cleaned up (on tearDown maybe?) and gettempdir() doesn't really look like a good option; maybe you wanted to create a new temporary directory rather than pointing to the filesystem's tmp dir ? -- the patch doesn't apply cleanly, at least for me - the ACKS hunk is failing for me -- nosy: +raduv ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17464 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17453] logging.config.fileConfig error
Radu Voicilas added the comment: Even though it seems kind of weird to have all those keys set to the empty string, I still think that configparser should handle this case, which might be relevant for some other uses cases (not logging configs). The attached patch should take care of this. -- keywords: +patch nosy: +raduv Added file: http://bugs.python.org/file29466/issue17453.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17453 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9554] test_argparse.py: use new unittest features
Radu Voicilas radu.voici...@gmail.com added the comment: Hi Eric, Denver's patch should apply correctly from the root. Also, I've made the changes you mention: try: except: assert has been replaced by: with self.assertRaises() -- Added file: http://bugs.python.org/file25659/test_argparse.py.take2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9554 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9554] test_argparse.py: use new unittest features
Radu Voicilas radu.voici...@gmail.com added the comment: The patch is still valid - it applies ok. The only issues as mentioned by sandro.tosi are offsets and that it was generated inside Lib/ It would be worth having these changes applied. -- nosy: +raduv ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9554 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12355] Crawler doesn't follow redirection
Radu Voicilas radu.voici...@gmail.com added the comment:
I can no longer reproduce the issue on tip. Here's the output I get trying to
do c.get_releases('webob'):
$ ./python issue12355.py
version has not been parsed: WebOb-0.8.3-py2.5
version has not been parsed: WebOb-0.9.1-py2.4
version has not been parsed: WebOb-0.8-py2.4
version has not been parsed: WebOb-0.8.4-py2.5
version has not been parsed: WebOb-0.8.4-py2.4
version has not been parsed: WebOb-0.8.5-py2.4
version has not been parsed: WebOb-0.9-py2.4
version has not been parsed: WebOb-0.8.5-py2.5
version has not been parsed: WebOb-0.9.1-py2.5
version has not been parsed: WebOb-0.8.3-py2.4
version has not been parsed: WebOb-0.8.1-py2.4
version has not been parsed: WebOb-0.8.2-py2.4
version has not been parsed: WebOb-0.9-py2.5
version has not been parsed: WebOb-0.8.2-py2.5
[103083 refs]
--
nosy: +raduv
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12355
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
