[issue16244] TimedRotatingFileHandler forces write mode, should use append
New submission from Richard Jones: The RotatingFileHandler classes force the open() mode of the new log file to be w even though it is initially defaulted to a in doRollover() methods: self.mode = 'w' self.stream = self._open() This can cause problems in systems that have multiple programs writing to the log file; they can both end up opening the new file in w mode and then there's loss of data. I cannot think of a reason why w should be forced in this manner. The fix is to remove the self.mode = 'w' line from the two doRollover() methods. -- components: Library (Lib) messages: 173016 nosy: richard priority: normal severity: normal status: open title: TimedRotatingFileHandler forces write mode, should use append type: behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16244 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16107] distutils2.version doesn't str() 1.0.post1 correctly
New submission from Richard Jones:
The attached simple patch demonstrates the problem:
str(NormalizedVersion('1.0.post1'))
'1.0.post1.z'
and includes a fix.
--
assignee: eric.araujo
components: Distutils2
files: post-fix.patch
keywords: patch
messages: 171765
nosy: alexis, eric.araujo, richard, tarek
priority: normal
severity: normal
stage: patch review
status: open
title: distutils2.version doesn't str() 1.0.post1 correctly
type: behavior
Added file: http://bugs.python.org/file27381/post-fix.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16107
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16108] Include maintainer information in register/upload
New submission from Richard Jones: The attached patch includes the maintainer information in the data sent to PyPI in a register or upload submission. -- assignee: eric.araujo components: Distutils2 files: maintainer.patch keywords: patch messages: 171774 nosy: alexis, eric.araujo, richard, tarek priority: normal severity: normal stage: patch review status: open title: Include maintainer information in register/upload type: behavior Added file: http://bugs.python.org/file27383/maintainer.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16108 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9619] test_ssl freezes
Richard Jones richardjo...@optushome.com.au added the comment: Thanks for the investigation Antoine. In r84088 I've added a call to asyncore.close_all in the smtpd test tearDown methods. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9619 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2423] test_smtplib.py no longer butt slow
Richard Jones richardjo...@optushome.com.au added the comment: Merged mock socket from test_smtpd.py and committed. -- resolution: - accepted status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2423 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8739] Update to smtpd.py to RFC 5321
Richard Jones richardjo...@optushome.com.au added the comment: The smtpd module now has a test suite. Please add your unit tests to test_smtpd.py -- nosy: +richard ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue8739 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2423] test_smtplib.py no longer butt slow
Richard Jones richardjo...@optushome.com.au added the comment: The patch to test_smtplib.py no longer applies since trunk is now py3k. I'm looking into it - and seeing whether the mock socket work I implemented for test_smtpd.py will have any common code. I'm hitting some fun areas of py3k-ness with bytes/str stuff in smtplib at the moment though ;-) -- assignee: - richard ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2423 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9412] test_smtpd leaks references
Richard Jones richardjo...@optushome.com.au added the comment: That's odd. I didn't run the refcount tests because I was only adding Python code. I'll look into compiling a debug build and running the tests locally with a view to tracking down the problem. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9412 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4184] Remove use of private attributes in smtpd
Richard Jones richardjo...@optushome.com.au added the comment: Committed in revision 83125. -- assignee: - richard resolution: - fixed stage: - committed/rejected status: open - closed type: - feature request ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4184 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4184] Remove use of private attributes in smtpd
Richard Jones richardjo...@optushome.com.au added the comment: After discussing with core devs at the EuroPython sprint I will implement a different approach: new attributes with the old, private attributes implemented as properties over the new attributes. The properties responsible for this will raise PendingDeprecationWarnings. I'll also be improving (well, *implementing*) test coverage for the module while I'm at it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4184 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4184] Remove use of private attributes in smtpd
Richard Jones richardjo...@optushome.com.au added the comment: Giampaolo, I think I can see where you're coming from: assuming that someone else must have also had to resort to the name-mangling hack to extend the class? In that case yes, my patch would break their code. I'll look at re-working it to use properties while retaining the underlying attributes. Would that be acceptable? What additional tests would you deem necessary? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4184 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7184] build failures on Snow Leopard
New submission from Richard Jones richardjo...@optushome.com.au: I'm using python 2.6 maint SVN r75588 and get the attached build log when I run: configure --enable-framework make Failed to build these modules: _curses_curses_panel _tkinter readline -- components: Build files: python-r75588-build.log messages: 94331 nosy: richard severity: normal status: open title: build failures on Snow Leopard type: compile error versions: Python 2.6 Added file: http://bugs.python.org/file15178/python-r75588-build.log ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7184 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4184] Remove use of private attributes in smtpd
New submission from Richard Jones [EMAIL PROTECTED]: Executive summary of the patch: The attached patch removes the use of __private attributes in the smtpd module allowing it to be extensible without needing to use the _classname__attributename hack. Summary of the patch's changes: 1. removes the unused __conn and __addr attributes 2. renames __server to smtp_server 3. renames __lines to received_lines 4. renames __state to smtp_state 5. renames __greeting to seen_greeting, and alters the default to empty string to match the anticipated data 6. renames __mailfrom to mailfrom 7. renames __date to received_data 8. renames __fqdn to fqdn 9. removes __peer and uses base class' addr attribute The existing unit tests contained within test_smtplib pass. Additional tests could be written if it's deemed necessary. There is a chance this patch will break backward compatibility with programs that use the private-variable-access hack. A more complex patch could be written providing greater compatibility if it's deemed necessary. -- components: Library (Lib) files: smtpd.py-patch messages: 75132 nosy: richard severity: normal status: open title: Remove use of private attributes in smtpd versions: Python 2.6 Added file: http://bugs.python.org/file11867/smtpd.py-patch ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue4184 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3441] Regression in module as a script command-line option
Richard Jones [EMAIL PROTECTED] added the comment: I'm afraid it's all a bit opaque to an outsider like me. I've no idea what subtle breakage the feature was causing. I just saw it working quite nicely for me in 2.5 :) ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3441] Regression in module as a script command-line option
New submission from Richard Jones [EMAIL PROTECTED]: The Python 2.5 -m command-line option allowed execution of a package directly, by invoking the __init__.py module. Python 2.6 no longer allows this. This is a quite unfortunate regression, and I would urge the decision to hobble it to be reconsidered. -- messages: 70240 nosy: richard severity: normal status: open title: Regression in module as a script command-line option versions: Python 2.6 ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3441] Regression in module as a script command-line option
Changes by Richard Jones [EMAIL PROTECTED]: -- type: - behavior ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3441 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
