[issue39121] gzip header write OS field

[Rob Man]

Rob Man  added the comment:

I do not need it for personaly, but since RFC exists and since linux
command line equivalent writes OS information, why should python gzip
implementation not include that.
The same goes for the FCOMMENT field for wich I also have a patch ready and
I they're both nice enhancements.

On Mon, 23 Dec 2019 at 09:04, Serhiy Storchaka 
wrote:

>
> Serhiy Storchaka  added the comment:
>
> The OS field is used in determining end-of-line convention for text files.
> But since we do not set the FTEXT flag, all files are binary. RFC 1952
>
> Why do you need to set this field?
>
> --
> nosy: +serhiy.storchaka
>
> ___
> Python tracker 
> <https://bugs.python.org/issue39121>
> ___
>

--

___
Python tracker 
<https://bugs.python.org/issue39121>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39121] gzip header write OS field

[Rob Man]

Change by Rob Man :


--
versions:  -Python 3.9

___
Python tracker 
<https://bugs.python.org/issue39121>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39121] gzip header write OS field

[Rob Man]

Change by Rob Man :


--
keywords: +patch
pull_requests: +17138
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17682

___
Python tracker 
<https://bugs.python.org/issue39121>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39121] gzip header write OS field

[Rob Man]

New submission from Rob Man :

Files written with gzip module write a value of 255 (unknown) at the 10th 
position in the header which defined what OS was used when gzip file was 
written. 
Files written with gzip linux command correctly set that field to the value of 
3 (Unix).
This ehancement does that.

--
components: Library (Lib)
messages: 358801
nosy: wungad
priority: normal
severity: normal
status: open
title: gzip header write OS field
type: enhancement
versions: Python 3.9

___
Python tracker 
<https://bugs.python.org/issue39121>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com