[issue15849] PEP 3121, 384 Refactoring applied to xx module

2013-08-18 Thread Robin Schreiber

Robin Schreiber added the comment:

Antoine, regarding that the last pending problem with the patch is related to 
the NULL checking of FindModule, I would be inclined to include your proposed 
helper API. I see that issue18710 has not been included into the trunk yet, but 
I think this is mostly due to the additional _csv patch and not because of the 
proposed API itself.
So I will upload a corrected version of the patch soon, but it will rely on 
issue18710 to be accepted beforehand...

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15849
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15849] PEP 3121, 384 Refactoring applied to xx module

2013-08-18 Thread Robin Schreiber

Robin Schreiber added the comment:

Updated patch accordingly. 
Regarding the problem in 
http://mail.python.org/pipermail/python-dev/2013-August/127862.html , it can 
indeed be solved by returning the already existing module object, if PyInit is 
called multiple times. I followed the discussion and can not make out a 
definite decision on how to handle this.
My understanding is, that up to now extension modules are only supposed to be 
initialized once per interpreter, so the check I have included in, for example 
issue15651, makes sense from this perspective. There have been reasonable 
desires (from Eli) to make the module state separate from each imported module 
within the interpreter, but this would involve more drastic changes and will be 
rather part of future Python releases.
Should we therefore (for now) make this a mandatory PEP3121 convention and 
include it into the xxmodule.c refactoring?

--
Added file: http://bugs.python.org/file31355/xxmodule_pep3121-384_v2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15849
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15849] PEP 3121, 384 Refactoring applied to xx module

2013-08-18 Thread Robin Schreiber

Robin Schreiber added the comment:

Everything except for the Xxo_Type. But you are right. Then again, why are 
these global static variables from the start? Isn't this because xxmodule is 
some kind of dummy module that is supposed to demonstrate some coding 
conventions on how to build extension modules? 
Another possibility could be the faster lookup of the variables, which is now 
of course invalidated if we store it within the module state.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15849
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15849] PEP 3121, 384 Refactoring applied to xx module

2013-08-13 Thread Robin Schreiber

Robin Schreiber added the comment:

Updated the patch, corrected multiple syntax errors and missing INCREFS. Also 
added the comments that include the members names. I am yet undecided regarding 
the NULL-check for FindModule.

Apart from that I have tried to build some tests that prove that loading and 
unloading the module do not cause any memory leaks. This has turned up several 
problems: For one, the only possibility to check for the leaks that PEP 3121 
tries to fix, is to run PyInit of the respective module multiple times. This is 
only possible if Py_finalize() has been called after the module has been 
imported beforehand. This means we can not test for these leaks from within 
Python, but need some C-Code that calls
Py_initialize(); ... import xx ... Py_finalize(); multiple times. The problem 
is that also the plain Py_initialize(); Py_finalize(); calls leak memory. 
Unfortunately the amount of objects that are leaked also seems to vary, so 
there is no constant factor that I can subtract to determine how much the 
imported module itself leaks.
So I am kind of on a dead end here. I could upload the tests scripts that I 
have written so far, if that helps.

--
keywords: +patch
Added file: http://bugs.python.org/file31272/xxmodule_pep3121-384_v1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15849
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15787] PEP 3121, 384 Refactoring

2013-08-11 Thread Robin Schreiber

Robin Schreiber added the comment:

I have in fact used abitype.py to produce all of my PEP 384 patches, however it 
failed to work correctly in like 50% of all cases, and I had to complete the 
rest of the patch by hand.I thought about correcting the abitype.py throughout 
the GSOC, but I happened to find it easier to simply do the missing steps by 
hand. (I don't know If the script has been fixed up to this point though).
In any case, it might also be interesting for external extension module 
developers to make use of a fully working version of this script, so they can 
make their modules PEP 384 compliant without investing too much time.
One has to keep in mind however that almost any script will fail to work by 
itself, once we run into problems like refcounting or concurrency when applying 
the patch to a module.

I will have some free time throughout next week and will start to correct the 
patches for the xx modules (as Alex proposed), and continue from there to all 
the other patches I have submitted a year ago.

I am deeply sorry that I have not continued my work on this project earlier, 
however I dramatically underestimated the amount if work related to university, 
etc... I still feel obliged to complete all these patches.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15787
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15849] PEP 3121, 384 Refactoring applied to xx module

2013-08-11 Thread Robin Schreiber

Robin Schreiber added the comment:

I absolutely agree on mentioning the member names in the comments. :-)

In the example Martin gave in his PEP 3121, the PyInit does not perform any 
INCREFs on the Variables that are referenced from inside the module state.
He therefore left out m_free completely as there was nothing to DECREF within 
the module state.
Back when I did my GSoC together with Martin, we decided that the Module state 
itself can be considered a valid container object, an therefore has to INCREF 
and in the end of its lifecycle (that is within m_free) also DECREF every 
object reference it holds. I therefore decided to include that into every 
module I refactored, and consequently also the xxmodule.

I was also thinking about redefining the macro of xx_state_global with a NULL 
check, however this would lead either to a redundant call of PyState_FindModule 
(Which may lead to unnecessary performance degregation as xx_state_global is 
used quite frequently in some parts of the respective module) or I had to find 
some awkward way to store the result o f FindModule in some local variable 
exapnded by the macro, which I would not consider a good idea. Instead Martin 
and I were thinking of including a NULL safe variant of xx_state_global only in 
CPython Debug Builds. What do you think about that?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15849
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15651] PEP 3121, 384 refactoring applied to elementtree module

2012-12-14 Thread Robin Schreiber

Robin Schreiber added the comment:

Patch updated to work with current 3.4 Branch version of elementtree.

--
keywords: +patch
Added file: http://bugs.python.org/file28311/_elementtree_pep3121-384_v1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15651
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15671] PEP 3121, 384 Refactoring applied to struct module

2012-12-14 Thread Robin Schreiber

Robin Schreiber added the comment:

Updated patch to work with 3.4 Branch version of _struct.c

--
keywords: +patch
Added file: http://bugs.python.org/file28315/_struct_pep3121-384_v1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15671
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15690] PEP 3121, 384 Refactoring applied to parser module

2012-12-14 Thread Robin Schreiber

Robin Schreiber added the comment:

Updated parsermodule patch to work with 3.4 Branch version.

--
keywords: +patch
Added file: http://bugs.python.org/file28316/parser_pep3121-384_v1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15690
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15691] PEP 3121, 384 Refactoring applied to posix module

2012-12-14 Thread Robin Schreiber

Robin Schreiber added the comment:

Updated posixmodule to work with the 3.4 Branch version.

--
keywords: +patch
Added file: http://bugs.python.org/file28317/posix_pep3121-384_v1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15691
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-12-10 Thread Robin Schreiber

Robin Schreiber added the comment:

I have updated the patch to work again with the current version of the 
_datetimemodule. 

Regarding the suggestion of separating PEP3121 and PEP384. It might be true 
that datetime and other modules do not benefit directly from PEP 384, however 
it is still a fact that the stdlib modules should be seen as a set of reference 
modules, that are all implemented in a way that complies with the 
implementation fo the xxmodules.
I have talked with Martin von Löwis about this, and as far as I understood him 
correctly he also sees the PEP384 refactoring applied to the whole stdlib as a 
nessecary signal to other developers to refactor their modules accordingly.

Anyway I am planning to start to commit all of the open changes that I have 
created during my GSOC in the next few months. So a decision regarding this 
separation concern might be helpful. :-)

--
keywords: +patch
Added file: 
http://bugs.python.org/file28274/_datetimemodule_pep3121-384_v3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15390
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15727] PyType_FromSpecWithBases tp_new bugfix

2012-11-30 Thread Robin Schreiber

Robin Schreiber added the comment:

Here is revised version of the patch. 

Martin von Löwis and I had discovered a way to reproduce problems with 
refactored modules, that
occur without this patch. This is was several months ago, however I will try to 
give you a code sample! :-)

--
keywords: +patch
Added file: 
http://bugs.python.org/file28167/PyType_FromSpecWithBases_tp_new_fix_v1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15727
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15650] PEP 3121, 384 refactoring applied to dbm module

2012-11-29 Thread Robin Schreiber

Robin Schreiber added the comment:

Take a look at the discussion in Issue 15653.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15650
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15721
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15650] PEP 3121, 384 refactoring applied to dbm module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15650
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15390] PEP 3121, 384 refactoring applied to datetime module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15390
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15727] PyType_FromSpecWithBases tp_new bugfix

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15727
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15725] PyType_FromSpecWithBases bugfix

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15725
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15848] PEP 3121, 384 Refactoring applied to xxsubtype module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15848
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15849] PEP 3121, 384 Refactoring applied to xx module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15849
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15711] PEP 3121, 384 Refactoring applied to time module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15711
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15733] PEP 3121, 384 Refactoring applied to winapi module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15733
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15735] PEP 3121, 384 Refactoring applied to ossaudio module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15735
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15734] PEP 3121, 384 Refactoring applied to spwd module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15734
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15729] PyStructSequence_NewType enhancement

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15729
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15653] PEP 3121, 384 refactoring applied to hashopenssl module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15653
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15668] PEP 3121, 384 Refactoring applied to random module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15668
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15672] PEP 3121, 384 Refactoring applied to testbuffer module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15672
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15675] PEP 3121, 384 Refactoring applied to array module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15675
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15674] PEP 3121, 384 Refactoring applied to thread module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15674
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15673] PEP 3121, 384 Refactoring applied to testcapi module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15673
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15671] PEP 3121, 384 Refactoring applied to struct module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15671
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15722] PEP 3121, 384 Refactoring applied to decimal module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15722
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15670] PEP 3121, 384 Refactoring applied to ssl module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15670
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15669] PEP 3121, 384 Refactoring applied to sre module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15669
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15667] PEP 3121, 384 refactoring applied to pickle module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15667
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15666] PEP 3121, 384 refactoring applied to lzma module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15666
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15665] PEP 3121, 384 refactoring applied to lsprof module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15665
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15662] PEP 3121 refactoring applied to locale module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15662
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15655] PEP 384 Refactoring applied to json module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15655
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15652] PEP 3121, 384 refactoring applied to gdbm module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15652
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15654] PEP 384 Refactoring applied to bz2 module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15654
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15651] PEP 3121, 384 refactoring applied to elementtree module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15651
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15714] PEP 3121, 384 Refactoring applied to grp module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15714
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15713] PEP 3121, 384 Refactoring applied to zipimport module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15713
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15712] PEP 3121, 384 Refactoring applied to unicodedata module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15712
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15709] PEP 3121, 384 Refactoring applied to termios module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15709
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15708] PEP 3121, 384 Refactoring applied to socket module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15708
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15707] PEP 3121, 384 Refactoring applied to signal module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15707
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15706] PEP 3121, 384 Refactoring applied to sha512 module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15706
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15705] PEP 3121, 384 Refactoring applied to sha256 module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15705
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15704] PEP 3121, 384 Refactoring applied to sha1 module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15704
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15703] PEP 3121, 384 Refactoring applied to select module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15703
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15700] PEP 3121, 384 Refactoring applied to resource module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15700
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15699] PEP 3121, 384 Refactoring applied to readline module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15699
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15698] PEP 3121, 384 Refactoring applied to pyexpat module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15698
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15697] PEP 3121 refactoring applied to pwd module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15697
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15691] PEP 3121, 384 Refactoring applied to posix module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15691
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15690] PEP 3121, 384 Refactoring applied to parser module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15690
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15689] PEP 3121, 384 Refactoring applied to operator module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15689
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15688] PEP 3121 Refactoring applied to nis module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15688
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15687] PEP 3121, 384 Refactoring applied to mmap module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15687
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15686] PEP 3121, 384 Refactoring applied to md5 module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15686
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15685] PEP 3121, 384 Refactoring applied to itertools module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15685
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15681] PEP 3121 refactoring applied to binascii module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15681
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15680] PEP 3121 refactoring applied to audioop module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15680
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15684] PEP 3121 refactoring applied to fpetest module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15684
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15682] PEP 3121 refactoring applied to fpectl module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15682
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15389] PEP 3121, 384 refactoring applied to curses module

2012-11-08 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
keywords: +pep3121 -patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15389
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15650] PEP 3121, 384 refactoring applied to dbm module

2012-10-07 Thread Robin Schreiber

Robin Schreiber added the comment:

PEP384 demands, among other things, that the TypeObjects themselves are 
transformed to Heaptypes. This means that the Typeobjects, that are created 
from this new stable ABI, reside within the heap and therefore have to be 
managed by the Python GC. This is of course done by appropriately incref- and 
decrefing of the specific Heaptype.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15650
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

2012-10-06 Thread Robin Schreiber

Robin Schreiber added the comment:

Before I submitted this patch, I used to have these variables inside the 
modulestate, which caused severe problems. I do not know the exact reason, but 
my guess is that these variables have to be globally available for every thread 
(tcl variables are used for thread synchronization arent they?). As the 
modulestate may change depending on the thread, one can no longer guarantee 
that every thread within the process is operating on the same variable. This 
might not be nessecary, however as I mentioned, the naive approach of putting 
the variables inside the modulestate did not work out for me.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15721
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15848] PEP 3121, 384 Refactoring applied to xxsubtype module

2012-09-02 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the xxsubtype 
module!

--
components: Extension Modules
files: xxsubtype_pep3121-384_v0.patch
keywords: patch
messages: 169701
nosy: Robin.Schreiber, belopolsky
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to xxsubtype module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file27097/xxsubtype_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15848
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15849] PEP 3121, 384 Refactoring applied to xx module

2012-09-02 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the xx module!

--
components: Extension Modules
files: xxmodule_pep3121-384_v0.patch
keywords: patch
messages: 169702
nosy: Robin.Schreiber, belopolsky
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to xx module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file27098/xxmodule_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15849
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15733] PEP 3121, 384 Refactoring applied to winapi module

2012-08-20 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the winapi 
module!

--
components: Extension Modules
files: _winapi_pep3121-384_v0.patch
keywords: patch
messages: 168639
nosy: Robin.Schreiber, astrand, effbot, loewis
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to winapi module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26921/_winapi_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15733
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15733] PEP 3121, 384 Refactoring applied to winapi module

2012-08-20 Thread Robin Schreiber

Robin Schreiber added the comment:

Forgot to change the macro definition...

--
Added file: http://bugs.python.org/file26922/_winapi_pep3121-384_v1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15733
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15734] PEP 3121, 384 Refactoring applied to spwd module

2012-08-20 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the spwd module!

--
components: Extension Modules
files: spwd_pep3121-384_v0.patch
keywords: patch
messages: 168641
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to spwd module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26923/spwd_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15734
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15735] PEP 3121, 384 Refactoring applied to ossaudio module

2012-08-20 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the ossaudio 
module!

--
components: Extension Modules
files: ossaudiodev_pep3121-384_v0.patch
keywords: patch
messages: 168642
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to ossaudio module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26924/ossaudiodev_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15735
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15725] PyType_FromSpecWithBases bugfix

2012-08-19 Thread Robin Schreiber

New submission from Robin Schreiber:

This small patch prevents PyType_FromSpecWithBases, from setting the base(s) 
attribute of the HeapType to NULL-values.

--
components: Interpreter Core
files: PyType_FromSpecWithBases_bases_fix.patch
keywords: patch
messages: 168570
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PyType_FromSpecWithBases bugfix
type: behavior
versions: Python 3.4
Added file: 
http://bugs.python.org/file26895/PyType_FromSpecWithBases_bases_fix.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15725
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15726] PyState_FindModule false length-comparison fix

2012-08-19 Thread Robin Schreiber

New submission from Robin Schreiber:

Fixed wrong list-length comparison in PyState_FindModule.

--
components: Interpreter Core
files: PyState_FindModule_LE_fix.patch
keywords: patch
messages: 168572
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PyState_FindModule false length-comparison fix
type: behavior
versions: Python 3.4
Added file: http://bugs.python.org/file26896/PyState_FindModule_LE_fix.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15726
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15726] PyState_FindModule false length-comparison fix

2012-08-19 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15726
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15725] PyType_FromSpecWithBases bugfix

2012-08-19 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15725
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15727] PyType_FromSpecWithBases tp_new bugfix

2012-08-19 Thread Robin Schreiber

New submission from Robin Schreiber:

As with every type, that has been created and initialized, HeapTypes created 
form PyType_FromSpecWithBases() have to pass through PyType_Ready(). Here the 
function inherit_special might be called, which, among other things, does the 
following:

3892 if (base != PyBaseObject_Type ||  
  
3893 (type-tp_flags  Py_TPFLAGS_HEAPTYPE)) {
3894 if (type-tp_new == NULL)
3895 type-tp_new = base-tp_new;
3896 }

The code does not know of Heaptypes that have been created from extension-types 
by the PEP 384 refactorings. This includes extension-types that do not specify 
a tp_new method but instead have seperate factory methods, that are only used 
within the extension module. inherit_special() might consequently assign 
inappropriate new-methods to these type objects.

To circumvent this issue, I propose to enhance PyType_FromSpecWithBases in the 
following way: If no tp_new has been specified, we assign the newly defined 
PySpec_New() method to tp_new which simply denies the user to create an 
instance of this type. This also prohibits inherit_special to falsely inherit 
inappropriate new-methods.

--
components: Interpreter Core
files: PyType_FromSpecWithBases_tp_new_fix.patch
keywords: patch
messages: 168579
nosy: Robin.Schreiber, loewis
priority: normal
severity: normal
status: open
title: PyType_FromSpecWithBases tp_new bugfix
type: behavior
versions: Python 3.4
Added file: 
http://bugs.python.org/file26897/PyType_FromSpecWithBases_tp_new_fix.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15727
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15729] PyStructSequence_NewType enhancement

2012-08-19 Thread Robin Schreiber

New submission from Robin Schreiber:

To create a HeapType from Structseq description, there is the helpful, yet 
undocumented PyStructSequence_NewType Method, which can do just that.
Until now, this method solely allocates some generic TypeObject on which it 
then performs PyStructSequence_InitType().

I have found that this is far from enough, as for one the flags of the type are 
not set appropriately and neither ht_name nor ht_qualname are set (which is as 
far as I know required of a proper Heaptype).
I have now added this missing initialization of the fields to 
PyStructSequence_NewType(). 

I have also changed the previous definition of PyStructSequence_InitType, by 
extracting a new Method _PyStructSequence_InitTypeWithFlags. This initializes 
the given type with the flags variable passed to the function.
This method extraction is needed, as we can not alter the semantics of InitType 
itself, yet need some way to initialize a SequenceType with Heaptype-flags, 
without having too much duplicate code.

--
components: Interpreter Core
files: structseq_newtype_fix.patch
keywords: patch
messages: 168595
nosy: Robin.Schreiber, loewis
priority: normal
severity: normal
status: open
title: PyStructSequence_NewType enhancement
type: enhancement
versions: Python 3.4
Added file: http://bugs.python.org/file26901/structseq_newtype_fix.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15729
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15721] PEP 3121, 384 Refactoring applied to tkinter module

2012-08-18 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the tkinter 
module!
When running the test form inside Python.exe (tkinter._test()), the litte 
test-window is rendered correctly. However there are still some error 
messages popping up inside the python shell 
(I am running this on OS X 10.8):

 tkinter._test()
2012-08-18 12:46:24.775 python.exe[17410:707] speedup (null)
2012-08-18 12:46:24.776 python.exe[17410:707] ERROR: Unable to find method 
[_NSFullScreenTransition 
_startFullScreenTransitionForCGWindow:targetFrame:duration:].
2012-08-18 12:46:24.776 python.exe[17410:707] ERROR: Unable to find method 
[_NSFullScreenTransition 
_startEnterFullScreenTransitionForCGWindow:targetFrame:duration:].
2012-08-18 12:46:24.778 python.exe[17410:707] ERROR: Unable to find method 
[_NSFullScreenTransition 
startExitFullScreenTransitionForCGWindow:targetFrame:duration:].
[87221 refs]
 

I have no Idea how and where these are triggered.

--
components: Extension Modules
files: _tkinter_pep3121-384_v0.patch
keywords: patch
messages: 168504
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to tkinter module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26887/_tkinter_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15721
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15722] PEP 3121, 384 Refactoring applied to decimal module

2012-08-18 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the decimal 
module!

--
components: Regular Expressions
files: _decimal_pep3121-384_v0.patch
keywords: patch
messages: 168511
nosy: Robin.Schreiber, ezio.melotti, mrabarnett, skrah
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to decimal module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26888/_decimal_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15722
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15722] PEP 3121, 384 Refactoring applied to decimal module

2012-08-18 Thread Robin Schreiber

Changes by Robin Schreiber robin.schrei...@me.com:


--
components: +Extension Modules -Regular Expressions

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15722
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15722] PEP 3121, 384 Refactoring applied to decimal module

2012-08-18 Thread Robin Schreiber

Robin Schreiber added the comment:

I have removed some redundant modulestate lookups and the testsuite now 
executes the decimal tests as fast as before the patch is applied. (at least 
for me).
May I ask how you tested the decimal performance?

Regarding the failing test:
It appears that the hackcheck() method in typeobject.c is responsible for this 
failure: 

static int
hackcheck(PyObject *self, setattrofunc func, char *what)
{
PyTypeObject *type = Py_TYPE(self);
while (type  type-tp_flags  Py_TPFLAGS_HEAPTYPE)
type = type-tp_base;
/* If type is NULL now, this is a really weird type.
   In the spirit of backwards compatibility (?), just shut up. */
if (type  type-tp_setattro != func) {
PyErr_Format(PyExc_TypeError,
 can't apply this %s to %s object,
 what,
 type-tp_name);
return 0;
}
return 1;
}

As the context-type is now a heaptype the while-loop will continue to jump to 
the basetype of the conext-type, which is the object-type. There it ultimately 
fails when it compares func (context_setattr) to the tp_setattr of object.
Anyway, I do not understand the purpose of the hackcheck method, so I can not 
propose any kind of solution for this problem.

--
Added file: http://bugs.python.org/file26889/_decimal_pep3121-384_v1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15722
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15680] PEP 3121 refactoring applied to audioop module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 have now been applied to the audioop module!

--
components: Extension Modules
files: audioop_pep3121_v0.patch
keywords: patch
messages: 168353
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121 refactoring applied to audioop module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26842/audioop_pep3121_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15680
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15681] PEP 3121 refactoring applied to binascii module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 have now been applied to the binascii module!

--
components: Extension Modules
files: binascii_pep3121_v0.patch
keywords: patch
messages: 168354
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121 refactoring applied to binascii module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26843/binascii_pep3121_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15681
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15682] PEP 3121 refactoring applied to fpectl module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 have now been applied to the fpectl module!

--
components: Extension Modules
files: fpectl_pep3121_v0.patch
keywords: patch
messages: 168355
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121 refactoring applied to fpectl module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26844/fpectl_pep3121_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15682
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15684] PEP 3121 refactoring applied to fpetest module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the fpetest 
module!

--
components: Extension Modules
files: fpetest_pep3121_v0.patch
keywords: patch
messages: 168357
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121 refactoring applied to fpetest module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26845/fpetest_pep3121_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15684
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15685] PEP 3121, 384 Refactoring applied to itertools module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the itertools 
module!

--
components: Extension Modules
files: itertools_pep3121-384_v0.patch
keywords: patch
messages: 168359
nosy: Robin.Schreiber, rhettinger
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to itertools module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26846/itertools_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15685
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15686] PEP 3121, 384 Refactoring applied to md5 module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the md5 module!

--
components: Extension Modules
files: md5_pep3121-384_v0.patch
keywords: patch
messages: 168360
nosy: Robin.Schreiber, gregory.p.smith
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to md5 module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26847/md5_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15686
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15687] PEP 3121, 384 Refactoring applied to mmap module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the mmap module!

--
components: Extension Modules
files: mmap_pep3121-384_v0.patch
keywords: patch
messages: 168361
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to mmap module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26848/mmap_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15687
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15688] PEP 3121 Refactoring applied to nis module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the nis module!

--
components: Extension Modules
files: nis_pep3121_v0.patch
keywords: patch
messages: 168362
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121 Refactoring applied to nis module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26849/nis_pep3121_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15688
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15689] PEP 3121, 384 Refactoring applied to operator module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the operator 
module!

--
components: Extension Modules
files: operator_pep3121-384_v0.patch
keywords: patch
messages: 168363
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to operator module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26850/operator_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15689
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15690] PEP 3121, 384 Refactoring applied to parser module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the parser 
module!

--
components: Extension Modules
files: parser_pep3121-384_v0.patch
keywords: patch
messages: 168364
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to parser module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26851/parser_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15690
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15691] PEP 3121, 384 Refactoring applied to posix module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the posix 
module!

--
components: Extension Modules
files: posix_pep3121-384_v0.patch
keywords: patch
messages: 168367
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to posix module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26852/posix_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15691
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15697] PEP 3121 refactoring applied to pwd module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 have now been applied to the pwd module!

--
components: Extension Modules
files: pwd_pep3121_v0.patch
keywords: patch
messages: 168403
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121 refactoring applied to pwd module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26860/pwd_pep3121_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15697
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15698] PEP 3121, 384 Refactoring applied to pyexpat module

2012-08-16 Thread Robin Schreiber

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the pyexpat 
module!

--
components: Extension Modules
files: pyexpat_pep3121-384_v0.patch
keywords: patch
messages: 168404
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to pyexpat module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26861/pyexpat_pep3121-384_v0.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15698
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >