[issue26144] test_pkg test_4 and/or test_7 sometimes fail
Rose Ames added the comment: Reproduced. In four runs, one errored in test_4, one failed in test_7, and the other two did both. -- nosy: +superluser ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue26144> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26144] test_pkg test_4 and/or test_7 sometimes fail
Rose Ames added the comment: redirecting stdout seems to reliably suppress both failures: $ ./python -m test -w test_pkg >foo $ cat foo [1/1] test_pkg 1 test OK. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue26144> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24922] assertWarnsRegex doesn't allow multiple warning messages
Rose Ames added the comment: Would this mean that we expect any one of the warnings to be raised, or all of them? If it's one, the example you give would be equivalent to: self.assertWarnsRegex(UserWarning, "^W100[01]") Matching all of the warnings seems more interesting, but I'm not sure how to handle the context manager attributes. For instance, right now you can do: with self.assertWarnsRegex(FooWarning, "Bar") as cm: blah() self.assertEquals(cm.lineno, 1000) Would lineno and filename become lists? It seems kind of ugly. What's the advantage over simply testing for each warning separately? -- nosy: +superluser ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue24922> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18287] PyType_Ready() should sanity-check the tp_name field
Rose Ames added the comment: There's still no check on tp_name. The patch looks reasonable, applies cleanly, compiles, and doesn't break any tests - suggest it be merged. -- nosy: +superluser ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue18287> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25791] Raise an ImportWarning when __spec__.parent/__package__ isn't defined for a relative import
Rose Ames added the comment: that's what I figured. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue25791> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25791] Raise an ImportWarning when __spec__.parent/__package__ isn't defined for a relative import
Rose Ames added the comment: Patch with tests. Not sure if importlib.h should be included? -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue25791> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25791] Raise an ImportWarning when __spec__.parent/__package__ isn't defined for a relative import
Changes by Rose Ames <r...@happyspork.com>: -- keywords: +patch Added file: http://bugs.python.org/file41609/issue25791.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue25791> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25791] Raise an ImportWarning when __spec__.parent/__package__ isn't defined for a relative import
Rose Ames added the comment: Thanks for the quick review, new patch uploaded. -- Added file: http://bugs.python.org/file41611/issue25791_2.patch ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue25791> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25711] Rewrite zipimport from scratch
Rose Ames added the comment: Sorry for the late response. I didn't have much time over the holidays. I think I better let someone else take this one. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue25711> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25711] Rewrite zipimport from scratch
Rose Ames added the comment: Serhiy, how far along are you on this? I have a wip from this summer that I could finish over the holidays. -- ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue25711> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25791] Raise an ImportWarning when __spec__.parent/__package__ isn't defined for a relative import
Changes by Rose Ames <r...@happyspork.com>: -- nosy: +superluser ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue25791> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3353] make built-in tokenizer available via Python C API
Changes by Rose Ames <r...@happyspork.com>: -- nosy: +superluser ___ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue3353> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24370] OrderedDict behavior is unclear with misbehaving keys.
Changes by Rose Ames r...@happyspork.com: -- nosy: +superluser ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24370 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24468] Expose compiler flag constants as code object attributes
Changes by Rose Ames r...@happyspork.com: -- nosy: +superluser ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24468 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24427] subclass of multiprocessing Connection segfault upon attribute acces
Rose Ames added the comment: Reproduced - the crash exists and the patch fixes it. -- nosy: +superluser versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24427 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21739] Add hint about expression in list comprehensions (https://docs.python.org/2/tutorial/datastructures.html#list-comprehensions)
Rose Ames added the comment: Fwiw, I've seen a beginner be confused by this. Patch attached. -- keywords: +patch nosy: +superluser Added file: http://bugs.python.org/file36593/reword.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21739 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13272] 2to3 fix_renames doesn't rename string.lowercase/uppercase/letters
Rose Ames added the comment: Changing the imports only is straightforward, but I'm having trouble detecting and changing future uses of the variables, without also clobbering user-defined variables with the same names. I notice some of the current fixers have similar problems, for example the itertools fixer changes: ``` def imap(): pass imap() ``` to ``` def imap(): pass map() ``` This patch is a little smarter than that, but it only detects top-level definitions. For example, the lowercase in ``` class Foo: def __init__(self): self.lowercase = blargh ``` still gets renamed. I can work on this more, but would like to know: a) whether this fix is still wanted b) how smart it needs to be c) whether my approach is reasonable. I feel like there should be an easier way. -- keywords: +patch nosy: +superluser Added file: http://bugs.python.org/file36586/string_partial.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13272 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13272] 2to3 fix_renames doesn't rename string.lowercase/uppercase/letters
Rose Ames added the comment: ... d) how to format code :\ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13272 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20977] pyflakes: undefined ctype in 2 except blocks in the email module
Rose Ames added the comment: Thanks guys! Added minimal tests necessary to expose the bug. -- Added file: http://bugs.python.org/file35253/expose_bug.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20977 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20977] pyflakes: undefined ctype in 2 except blocks in the email module
Rose Ames added the comment: This is my first attempt at contributing to python I'd really appreciate some feedback :). Should I have added a test to demonstrate the bug before trying to fix it? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20977 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21221] Minor struct_time documentation bug
Rose Ames added the comment: Thanks for the quick feedback! Altered to A value of -1... -- nosy: +superluser Added file: http://bugs.python.org/file35219/tm_isdst2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21221 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21221] Minor struct_time documentation bug
Changes by Rose Ames r...@happyspork.com: -- keywords: +patch Added file: http://bugs.python.org/file35211/tm_isdst.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21221 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20977] pyflakes: undefined ctype in 2 except blocks in the email module
Rose Ames added the comment: It looks like these are just typos, recording defects to ctype objects when it should be disp_header and cte_header? Apologies if it's more complicated than that. -- keywords: +patch nosy: +superluser Added file: http://bugs.python.org/file35212/undefined_ctypes.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20977 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
