[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

2020-11-04 Thread Sebastian Wiedenroth 


Sebastian Wiedenroth  added the comment:

Excellent analysis, that's it! I've also tested your patch on SmartOS and it 
works great.

--

___
Python tracker 
<https://bugs.python.org/issue42237>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

2020-11-01 Thread Sebastian Wiedenroth 


Change by Sebastian Wiedenroth :


--
keywords: +patch
pull_requests: +22002
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23085

___
Python tracker 
<https://bugs.python.org/issue42237>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42237] test_socket.SendfileUsingSendfileTest fails on illumos

2020-11-01 Thread Sebastian Wiedenroth 


New submission from Sebastian Wiedenroth :

I'm investigating some test failures related to sendfile on illumos:


testCount (test.test_socket.SendfileUsingSendfileTest) ... FAIL
testCountSmall (test.test_socket.SendfileUsingSendfileTest) ... ok
testCountWithOffset (test.test_socket.SendfileUsingSendfileTest) ... ok
testEmptyFileSend (test.test_socket.SendfileUsingSendfileTest) ... ok
testNonBlocking (test.test_socket.SendfileUsingSendfileTest) ... ok
testNonRegularFile (test.test_socket.SendfileUsingSendfileTest) ... ok
testOffset (test.test_socket.SendfileUsingSendfileTest) ... ERROR
testRegularFile (test.test_socket.SendfileUsingSendfileTest) ... ok
testWithTimeout (test.test_socket.SendfileUsingSendfileTest) ... FAIL
testWithTimeoutTriggeredSend (test.test_socket.SendfileUsingSendfileTest) ... ok
test_errors (test.test_socket.SendfileUsingSendfileTest) ... ok

==
ERROR: testOffset (test.test_socket.SendfileUsingSendfileTest)
--
Traceback (most recent call last):
  File "/root/cpython/Lib/socket.py", line 386, in _sendfile_use_sendfile
sent = os_sendfile(sockno, fileno, offset, blocksize)
OSError: [Errno 22] Invalid argument

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/cpython/Lib/test/test_socket.py", line 374, in _tearDown
raise exc
  File "/root/cpython/Lib/test/test_socket.py", line 392, in clientRun
test_func()
  File "/root/cpython/Lib/test/test_socket.py", line 6057, in _testOffset
sent = meth(file, offset=5000)
  File "/root/cpython/Lib/socket.py", line 399, in _sendfile_use_sendfile
raise _GiveupOnSendfile(err)
socket._GiveupOnSendfile: [Errno 22] Invalid argument

==
FAIL: testCount (test.test_socket.SendfileUsingSendfileTest)
--
Traceback (most recent call last):
  File "/root/cpython/Lib/test/test_socket.py", line 6085, in testCount
self.assertEqual(len(data), count)
AssertionError: 5405948743 != 507

==
FAIL: testWithTimeout (test.test_socket.SendfileUsingSendfileTest)
--
Traceback (most recent call last):
  File "/root/cpython/Lib/test/test_socket.py", line 6159, in testWithTimeout
self.assertEqual(len(data), self.FILESIZE)
AssertionError: 429006848 != 10485760

--
Ran 11 tests in 33.603s

FAILED (failures=2, errors=1)


Looking at the testCount case I could observe repeated calls to sendfile() with 
out_fd=7, in_fd=6 off=0, len=507 which returned -1 with errno set to EAGAIN.

--
components: IO, Library (Lib)
messages: 380160
nosy: wiedi
priority: normal
severity: normal
status: open
title: test_socket.SendfileUsingSendfileTest fails on illumos
versions: Python 3.10

___
Python tracker 
<https://bugs.python.org/issue42237>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16902] Add OSS module support for Solaris

2020-10-31 Thread Sebastian Wiedenroth 


Sebastian Wiedenroth  added the comment:

This patch has also been applied to the python versions shipped by OpenIndiana 
and OmniOS for a long time. I'd say it's safe to merge.

--
nosy: +wiedi

___
Python tracker 
<https://bugs.python.org/issue16902>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42173] Drop Solaris support

2020-10-29 Thread Sebastian Wiedenroth 


Sebastian Wiedenroth  added the comment:

> Which Python version do you use?

Myself currently mostly python 3.8 via pkgsrc on SmartOS (one of the illumos 
distributions).

OmniOS ships 3.7: 
https://github.com/omniosorg/omnios-build/tree/master/build/python37

OpenIndiana ships at least 2.7, 3.5, 3.7.

The illumos build process also depends on python and was updated to support 3.9 
two weeks ago: https://www.illumos.org/issues/13217

--

___
Python tracker 
<https://bugs.python.org/issue42173>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue42173] Drop Solaris support

2020-10-29 Thread Sebastian Wiedenroth 


Sebastian Wiedenroth  added the comment:

Please don't.

Even if Oracle doesn't care anymore, the open source illumos community does.
We (illumos) share the same uname "SunOS" and depend on this support.

I have offered to host an illumos buildbot in the past and that offer is still 
valid.
At that time the testsuite did not pass and I could not figure out the fix yet.
If having this fixed is a requirement to keep illumos supported I will invest 
more time into this. I can also offer shell access to anyone interested in 
helping with this.

--
nosy: +wiedi

___
Python tracker 
<https://bugs.python.org/issue42173>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com