[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: @steve.dower - Does this fix need more work for android? @xdegaye says he does not need this for android anymore. -- ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37891] Exceptions tutorial page does not mention raise from
Srinivas Nyayapati added the comment: Here is my first pass at this. I propose the following sentence be added at the end section 8.4: If you need to track related exceptions (exceptions during exception handling), you should use exception chaining. You can chain exceptions by using the ``from`` clause. Just raise a new exception class or instance from an existing exception. The existing exception will be set as the cause for the new exception. -- ___ Python tracker <https://bugs.python.org/issue37891> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33694] test_asyncio: test_start_tls_server_1() fails on Python on x86 Windows7 3.7 and 3.x
Change by Srinivas Nyayapati : -- pull_requests: +15156 pull_request: https://github.com/python/cpython/pull/15170 ___ Python tracker <https://bugs.python.org/issue33694> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37891] Exceptions tutorial page does not mention raise from
Srinivas Nyayapati added the comment: In case Niels Albers is not interested, can I submit a PR? I noticed the linked raise reference documentation from the tutorial having details on exception chaining (https://docs.python.org/3.7/reference/simple_stmts.html#raise). Does it make sense to mention exception chaining in the tutorial and say "read details in the reference docs"? Or as you mentioned.. just write a short paragraph on exception chaining and give an example in the tutorial? -- nosy: +shireenrao ___ Python tracker <https://bugs.python.org/issue37891> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: Thank you Steve for accepting my pull requests. I was surprised to see the methods in the class and its decorators getting evaluated and causing the failures initially, but I then realized that the code is parsed before execution and that's when I was seeing the failure. -- ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: Thank you @paul.moore -- ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36266] Which module could not be found?
Srinivas Nyayapati added the comment: can a reviewer please take a look to my PR? -- ___ Python tracker <https://bugs.python.org/issue36266> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: I submitted a new PR for the Windows test case. Please take a look. Also how do I attach the label "skip news" to this new PR? -- ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Change by Srinivas Nyayapati : -- pull_requests: +14973 pull_request: https://github.com/python/cpython/pull/15252 ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: When I try to put the skipUnless decorator on CryptTestCase, I am still seeing a failure when I try to run this. The error is - File "C:\Users\srao\projects\cpython\lib\test\test_crypt.py", line 59, in CryptTestCase @unittest.skipUnless(crypt.METHOD_SHA256 in crypt.methods or AttributeError: 'NoneType' object has no attribute 'METHOD_SHA256' Line 59 is the following decorator and method - @unittest.skipUnless(crypt.METHOD_SHA256 in crypt.methods or crypt.METHOD_SHA512 in crypt.methods, 'requires support of SHA-2') def test_sha2_rounds(self): I tried a simple @skip decorator and that too fails on the same error. The class level skip is not helping here. Does it make sense to create a different test file for windows? -- ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: Can I have a go at it? Do I need to open a new issue to post a new PR? -- ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: Are you suggesting using the try/except block instead of import_module in test_crypt.py -- ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: I am curious how one would create a test for this? Would this be a new test script? The new script would skip if platform not win32 and the test case would be to import the crypt module and check for "not supported" string in the ImportError? -- ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37793] argparse uses "container object", should be "iterable"
Srinivas Nyayapati added the comment: I understand eric.smith. I can close this PR. I currently have the following 3 other PR's waiting for review on github - https://github.com/python/cpython/pull/15180 https://github.com/python/cpython/pull/15170 https://github.com/python/cpython/pull/15149 Would appreciate it if you could take a look :) -- ___ Python tracker <https://bugs.python.org/issue37793> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36266] Which module could not be found?
Srinivas Nyayapati added the comment: I just submitted a PR for this issue. -- nosy: +shireenrao ___ Python tracker <https://bugs.python.org/issue36266> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36266] Which module could not be found?
Change by Srinivas Nyayapati : -- keywords: +patch pull_requests: +14912 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/15180 ___ Python tracker <https://bugs.python.org/issue36266> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37793] argparse uses "container object", should be "iterable"
Srinivas Nyayapati added the comment: Not at all. I just started contributing to cpython 2 days ago and finally got the hang of it and was able to push this without any issues on my side. So either way I would still call this a win for me :) -- ___ Python tracker <https://bugs.python.org/issue37793> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37793] argparse uses "container object", should be "iterable"
Srinivas Nyayapati added the comment: Done. Thank you. -- ___ Python tracker <https://bugs.python.org/issue37793> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37793] argparse uses "container object", should be "iterable"
Change by Srinivas Nyayapati : -- keywords: +patch pull_requests: +14909 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15178 ___ Python tracker <https://bugs.python.org/issue37793> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37793] argparse uses "container object", should be "iterable"
Srinivas Nyayapati added the comment: Can I work on this? -- nosy: +shireenrao ___ Python tracker <https://bugs.python.org/issue37793> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37772] zipfile.Path.iterdir() outputs sub directories many times or not at all
Srinivas Nyayapati added the comment: I just submitted my PR. -- ___ Python tracker <https://bugs.python.org/issue37772> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37772] zipfile.Path.iterdir() outputs sub directories many times or not at all
Change by Srinivas Nyayapati : -- keywords: +patch pull_requests: +14902 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15170 ___ Python tracker <https://bugs.python.org/issue37772> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37772] zipfile.Path.iterdir() outputs sub directories many times or not at all
Srinivas Nyayapati added the comment: I have attempted a fix to Path._add_implied_dirs and have the changes in my github branch https://github.com/shireenrao/cpython/tree/zipfile. Is it ok if I submitted a PR on this? I have run test_zipfile.py and the test case provided by Jörn Heissler successfully. -- nosy: +shireenrao ___ Python tracker <https://bugs.python.org/issue37772> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: How do I write tests which only run for a given platform? Looking at test_crypt.py, I see that the crypt module is imported using test.support module so the exception will be raised even before the tests run. Is there a way to test imports? -- ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: Sorry, I should have waited 1 day after submitting the CLA before submitting the PR. The system is waiting for my CLA to be cleared. -- ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Change by Srinivas Nyayapati : -- keywords: +patch pull_requests: +14884 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15149 ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: I forgot to ask about tests? I see there is test_crypt.py under Lib\test. Do you have any thoughts on how to test this? -- ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: Sounds good. Can I submit my PR now? -- ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment:
What is the recommended way to check for platform in cpython? Is it using the
sys module or os module? As for the error messages I couldn't think of anything
better then what you suggested :).
win32: raise ImportError("The crypt module is not supported on Windows")
not win32: raise ImportError("The required _crypt module was not built as part
of CPython")
--
___
Python tracker
<https://bugs.python.org/issue25172>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25172] Unix-only crypt should not be present on Windows.
Srinivas Nyayapati added the comment: Hello I would like to work on this issue. First time contributor here. Would putting the import _crypt statement on line 3 in crypt.py inside a try/except block and checking to see if platform is windows then give an appropriate message be a good fix? Thank you -Srinivas -- nosy: +shireenrao ___ Python tracker <https://bugs.python.org/issue25172> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
