[issue1703178] link_objects in setup.cfg crashes build
Valerie Lambert added the comment: Fixed the typo and reuploaded. Thanks for spotting that! -- Added file: http://bugs.python.org/file37403/build_ext_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1703178 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1703178] link_objects in setup.cfg crashes build
Valerie Lambert added the comment: Here is a simple one-line-fix patch with a test. Except for the libraries option, other options separate using ':'. The documentation didn't seem to say much, so I wasn't sure if link_objects should be consistent with that or if it should follow libraries's example and instead allow spaces and commas for separation. This patch uses ensure_string_list as suggested, but let me know if using .split(os.pathsep) is a better idea. -- keywords: +patch nosy: +lambertv Added file: http://bugs.python.org/file36861/build_ext.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1703178 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
Valerie Lambert added the comment: Great! Thanks for putting together a list. I've incorporated SuppressCoreFiles into these tests and have used the test suite without any errors. Again, I'm testing these on Ubuntu. -- keywords: +patch Added file: http://bugs.python.org/file31743/issue-18948.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18948] deliberately crashing tests should prevent core dumps
Valerie Lambert added the comment: Oops! That was careless. Fixed. -- Added file: http://bugs.python.org/file31752/issue-18948_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18948 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18623] Factor out the _SuppressCoreFiles context manager
Valerie Lambert added the comment: Running through both your scripts on my machine (using Ubuntu) WCOREDUMP is always True (though I'll only be able to find a core file when ulimit is set to unlimited, as expected). Because there doesn't seem to be a good way to test this, I've cut the test from the patch. Is there anything else that this patch should address? -- Added file: http://bugs.python.org/file31533/issue-18623_v4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18623 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18623] Factor out the _SuppressCoreFiles context manager
Valerie Lambert added the comment: I've added a new test that uses fork() and os.abort(), then asserts os.WCOREDUMP() is false. However, this test is currently failing. Is my test incorrect, or is this an issue with SuppressCoreFiles() itself? If its a problem with the test I'm guessing it might have to do with how os.WCOREDUMP() decides whether a process has dumped its core or not. Is there another way we could go about this test? -- Added file: http://bugs.python.org/file31480/issue-18623_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18623 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18623] Factor out the _SuppressCoreFiles context manager
Valerie Lambert added the comment: Of course, here is the patch without the '--git' option. -- Added file: http://bugs.python.org/file31442/issue-18623_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18623 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18623] Factor out the _SuppressCoreFiles context manager
Valerie Lambert added the comment: I have included a patch that moves _SuppressCoreFiles into test.support and a test that checks whether resource.RLIMIT_CORE is being properly set and reset. It would be nice if there was a more explicit way to test the creation of core files, however. The patch also corrects a comment that stated ulimit was being set to (0, 0) when in the code only the soft limit was being set to 0. I'm pretty sure that the later should be done because then we don't run into trouble when we have to restore the hard limit to its original (higher) limit. -- keywords: +patch nosy: +lambertv Added file: http://bugs.python.org/file31429/issue-18623.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18623 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4885] mmap enhancement request
Valerie Lambert added the comment: I just signed and sent the agreement electronically. Let me know if there is anything else I need to do. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4885] mmap enhancement request
Valerie Lambert added the comment: I've uploaded a patch to make mmap_obj support weakref. A test is included in the patch. -- keywords: +patch nosy: +lambertv Added file: http://bugs.python.org/file31115/issue-4885.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4885 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
