[issue22753] urllib2 localnet Changed test to lookup IP-address of localhost

2014-11-01 Thread Wouter van Heyst

Wouter van Heyst added the comment:

What the patch does is replace the hard-coded address 127.0.0.1 for the 
loopback interface with a one-time lookup.  I'd argue the hunk @@ -315,7 +316,7 
@@ should be dropped.

The two arguments that motivate this change are:

  1) The address of the loopback interface is not always 127.0.0.1, binding to 
it may fail.
  2) The tests seem to assume localhost resolves to the same address where the 
server is running.


Working on this patch started with the ConnectionRefusedError that HÃ¥kan 
mentioned. 
Applying the patch made the ConnectionRefusedError go away, but I think we may
have solved a different problem and suppressed the real problem as a side
effect.

@r.david.murray: would the patch be acceptable on dropping said hunk, and 
changing the description to 
Do not assume localhost resolves to 127.0.0.1?


That still leaves, I think, a hidden bug somewhere in the proxy code that will 
surface in some corner case.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22753
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18034] Last two entries in the programming FAQ are out of date (import related)

2014-08-03 Thread Wouter van Heyst

Wouter van Heyst added the comment:

The attached patch changes the body of the __import__ faq entry to suggest 
using `importlib.import_module` instead.

--
keywords: +patch
nosy: +larstiq
Added file: http://bugs.python.org/file36227/faq-import_module.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18034
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21278] Running the test suite with -v makes the test_ctypes and the test_zipimport erroneously reported as failed

2014-08-03 Thread Wouter van Heyst

Wouter van Heyst added the comment:

Even running `EXTRATESTOPTS='-x test_gdb -uall -v' make testall` I can not 
reproduce this. I'll dig some more in the code for anything suspicious.

--
nosy: +larstiq

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21278
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21278] Running the test suite with -v makes the test_ctypes and the test_zipimport erroneously reported as failed

2014-08-03 Thread Wouter van Heyst

Wouter van Heyst added the comment:

Ezio also couldn't reproduce this, so unless someone else (ddvento?), can 
reproduce it, I would advocate closing this issue.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21278
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com