[issue44493] Missing terminated NUL in the length of sockaddr_un
Change by ty : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue44493> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44493] Missing terminated NUL in the length of sockaddr_un
ty added the comment: Actually the OS will always trust the length has already contained the last NUL. The test I did in this issue: https://github.com/rust-lang/rust/issues/69061 showed that: 1. OS trusted the input length was set correctly, both `sun_len` and the length of `struct sockaddr_un`. 2. The `struct sockaddr_un` and length will be copied without changed to the other programs. 3. It could be reproduced by the Rust dev team. So it shouldn't be a problem in the testcase itself. Maybe we could discuss this on the Github's PR page? I am very sure that it could be reproduced. -- ___ Python tracker <https://bugs.python.org/issue44493> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44493] Missing terminated NUL in the length of sockaddr_un
ty added the comment: Oh, it should also occurs on Linux, I should correct that. -- nosy: -christian.heimes ___ Python tracker <https://bugs.python.org/issue44493> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44493] Missing terminated NUL in the length of sockaddr_un
ty added the comment: More about the tests: The error will only shows on BSD systems, for example macOS. Here are some tests done with C and Rust: https://github.com/rust-lang/rust/issues/69061 If both the servers and clients are written in Python, you won't notice this bug because the original code ignored the length of sockaddr_un and use the sun_path as a C string (NUL terminated string). -- ___ Python tracker <https://bugs.python.org/issue44493> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44493] Missing terminated NUL in the length of sockaddr_un
ty added the comment: Sorry Heimes. I just don't know who is responsible for this code, which is very very old. -- ___ Python tracker <https://bugs.python.org/issue44493> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44493] Missing terminated NUL in the length of sockaddr_un
ty added the comment: Ping Heimes. This is a huge bug that exists for a very long time, please consider merge it and fix it in the next relesae. -- nosy: +christian.heimes ___ Python tracker <https://bugs.python.org/issue44493> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44493] Missing terminated NUL in the length of sockaddr_un
ty added the comment: I think I have already provided enough information about this bug. The `len_ret` was the length of `sockaddr_un`, which should include the terminated NUL in the `sun_path`. But the original implementation only use `path.len + offsetof(struct sockaddr_un, sun_path)`. References: 1. https://man7.org/linux/man-pages/man7/unix.7.html The Address format section. 2. The `SUN_LEN` macro in *BSD systems, https://man.cx/unix(4) -- versions: -Python 3.11 ___ Python tracker <https://bugs.python.org/issue44493> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44493] Missing terminated NUL in the length of sockaddr_un
ty added the comment: Hello and PING. -- ___ Python tracker <https://bugs.python.org/issue44493> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44493] Missing terminated NUL in the length of sockaddr_un
ty added the comment: Changes have been made in this PR, waiting for reviewing. -- resolution: -> fixed ___ Python tracker <https://bugs.python.org/issue44493> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44493] Missing terminated NUL in the length of sockaddr_un
Change by ty : -- keywords: +patch pull_requests: +25441 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26866 ___ Python tracker <https://bugs.python.org/issue44493> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44493] Missing terminated NUL in the length of sockaddr_un
New submission from ty : https://github.com/python/cpython/blob/main/Modules/socketmodule.c#L1700 -- components: Library (Lib) messages: 396379 nosy: zonyitoo priority: normal severity: normal status: open title: Missing terminated NUL in the length of sockaddr_un type: behavior versions: Python 3.6 ___ Python tracker <https://bugs.python.org/issue44493> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1105] patch for readme.txt in PCbuild8
New submission from Ty: This update adds some comments to the readme.txt file for PCbuild8. When building subprojects VS2005 does not build the dependencies. I have included some text to alert the reader to this so they don't have the same trouble building subprojects as I did. I encountered this problem when building the pythoncore subproject. VS2005 did not build its dependencies (make_buildinfo, make_versioninfo) for me. -- components: Documentation files: pcbuild8_readme_txt.patch messages: 55651 nosy: chipped severity: normal status: open title: patch for readme.txt in PCbuild8 type: compile error __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1105 __ pcbuild8_readme_txt.patch Description: Binary data ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
