[issue10240] dict.update.__doc__ is misleading
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- resolution: - rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10240 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10240] dict.update.__doc__ is misleading
Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: -berker.peksag ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10240 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10240] dict.update.__doc__ is misleading
Changes by Berker Peksag berker.pek...@gmail.com: -- assignee: - docs@python components: +Documentation -Interpreter Core nosy: +berker.peksag, docs@python versions: +Python 3.4, Python 3.5 -Python 3.1, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10240 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10240] dict.update.__doc__ is misleading
Raymond Hettinger added the comment: Maybe the fastpath should do a strict check and not be used for subclasses of dict? This code is ancient and well-established. IMO, nothing good can come from changing it (besides slowing down code that is already deployed and working fine). -- assignee: docs@python - rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10240 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10240] dict.update.__doc__ is misleading
Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo versions: -Python 2.5, Python 2.6, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10240] dict.update.__doc__ is misleading
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: I'm not sure that we should mention the fast path for dicts. That is an implementation detail and may not be present in IronPython, PyPy, Jython, etc. The current version includes: D.updated(E, **F) -- None. Updated D for dict/iterable E and F. ISTM that covers the semantics of what it does. Your proposed modification gets into how it does it. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10240] dict.update.__doc__ is misleading
ivank b...@ludios.org added the comment: CPython's dict(obj) ignores `keys` and `__iter__` if obj is a subclass of dict. I thought this was an important language detail, not just an implementation quirk. But, I just tested pypy 1.3, and it is calling .keys() on dicts. Oh well. I think the __doc__ can still be slightly improved; ignore my patch and just change the first E: to E.keys(): - that would be more accurate. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10240] dict.update.__doc__ is misleading
R. David Murray rdmur...@bitdance.com added the comment: Maybe the fastpath should do a strict check and not be used for subclasses of dict? -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10240] dict.update.__doc__ is misleading
New submission from ivank b...@ludios.org: It would be nice if dict.update.__doc__ conveyed some of the subtleties of the update algorithm. See the patch. I changed __doc__ to mention the fast path for dicts, and changed one instance of E: - E.keys(): -- components: Interpreter Core files: dict.update.__doc__.patch keywords: patch messages: 119954 nosy: ivank priority: normal severity: normal status: open title: dict.update.__doc__ is misleading versions: Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3 Added file: http://bugs.python.org/file19420/dict.update.__doc__.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10240 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
