[issue10276] zlib crc32/adler32 buffer length truncation (64-bit)

2016-05-26 Thread Martin Panter 

Changes by Martin Panter :


--
Removed message: http://bugs.python.org/msg135065

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10276] zlib crc32/adler32 buffer length truncation (64-bit)

2016-05-26 Thread Martin Panter 

Changes by Martin Panter :


--
Removed message: http://bugs.python.org/msg135066

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10276] zlib crc32/adler32 buffer length truncation (64-bit)

2011-05-03 Thread Roundup Robot 

Roundup Robot devnull@devnull added the comment:

New changeset f43213129ba8 by Victor Stinner in branch '2.7':
Issue #10276: test_zlib checks that inputs of 2 GB are handled correctly by
http://hg.python.org/cpython/rev/f43213129ba8

--
nosy: +python-dev
status: pending - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10276
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10276] zlib crc32/adler32 buffer length truncation (64-bit)

2011-05-03 Thread Roundup Robot 

Roundup Robot devnull@devnull added the comment:

New changeset dd58f8072216 by Victor Stinner in branch '2.7':
Issue #10276: Fix test_zlib, m may be undefined in the finally block
http://hg.python.org/cpython/rev/dd58f8072216

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10276
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10276] zlib crc32/adler32 buffer length truncation (64-bit)

2011-05-03 Thread Steffen Daode Nurpmeso 

Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:

Ha!  I always knew it!  wink

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10276
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10276] zlib crc32/adler32 buffer length truncation (64-bit)

2011-05-03 Thread Nadeem Vawda 

Nadeem Vawda nadeem.va...@gmail.com added the comment:

Changeset a0681e7a6ded fixes this bug for 2.7 - too-large buffers cause
an OverflowError during argument parsing, so there is no possibility of
truncation happening.

--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10276
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10276] zlib crc32/adler32 buffer length truncation (64-bit)

2011-02-21 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Patch looks good to me.

--
nosy: +pitrou
stage:  - patch review
versions: +Python 3.3 -Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10276
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10276] zlib crc32/adler32 buffer length truncation (64-bit)

2011-02-21 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Thank you for the patch! Committed in r88460 (3.3) and r88461 (3.2).
2.7 would need more surgery in order for this to be fixed, see #8651 and #8650.

--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - pending
versions:  -Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10276
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10276] zlib crc32/adler32 buffer length truncation (64-bit)

2011-01-26 Thread Nadeem Vawda 

Nadeem Vawda nadeem.va...@gmail.com added the comment:

Here is an update patch, which corrects a typo in the previous patch, and adds 
a test to test_zlib.

The test uses a memory-mapped sparse file, so it gets skipped on systems 
without mmap. The alternative would be to allocate a 4+GB buffer of ordinary 
memory, causes heavy swapping on my machine (4GB of RAM). The test also gets 
skipped on 32-bit builds, where the address space is too small for this bug to 
arise.

I'm not sure whether the test can count on the created file actually being 
sparse, so I had the test require the 'largefile' resource, to be on the safe 
side.

--
Added file: http://bugs.python.org/file20543/zlib-v2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10276
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10276] zlib crc32/adler32 buffer length truncation (64-bit)

2010-11-01 Thread Nadeem Vawda 

New submission from Nadeem Vawda nadeem.va...@gmail.com:

zlib.crc32() and zlib.adler32() in Modules/zlibmodule.c don't handle buffers of 
=4GB correctly. The length of a Py_buffer is of type Py_ssize_t, while the C 
zlib functions take length as an unsigned integer. This means that on a 64-bit 
build, the buffer length gets silently truncated to 32 bits, which results in 
incorrect output for large inputs.

Attached is a patch that fixes this by computing the checksum incrementally, 
using small-enough chunks of the buffer.

A better fix might be to have Modules/zlib/crc32.c use 64-bit lengths. I tried 
this, but I couldn't get it to work. It seems that if the system already has 
zlib installed, Python will link against the existing version instead of 
compiling its own.

Testing this might be a bit tricky. Allocating a 4+GB regular buffer isn't 
practical. Using a memory-mapped file would work, but I'm not sure having a 
unit test create a multi-gigabyte file is a great thing to do.

--
components: Library (Lib)
files: zlib-checksum-truncation.diff
keywords: patch
messages: 120114
nosy: nvawda
priority: normal
severity: normal
status: open
title: zlib crc32/adler32 buffer length truncation (64-bit)
type: behavior
versions: Python 2.5, Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3
Added file: http://bugs.python.org/file19453/zlib-checksum-truncation.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10276
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10276] zlib crc32/adler32 buffer length truncation (64-bit)

2010-11-01 Thread Martin v . Löwis 

Martin v. Löwis mar...@v.loewis.de added the comment:

I find your approach fine; there isn't a need (IMO) to have the underlying 
functions change.

--
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10276
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10276] zlib crc32/adler32 buffer length truncation (64-bit)

2010-11-01 Thread Éric Araujo 

Changes by Éric Araujo mer...@netwok.org:


--
components: +Extension Modules -Library (Lib)
versions:  -Python 2.5, Python 2.6, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10276
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com