[issue10292] tarinfo should use relative symlinks
Benjamin Root added the comment: What was the issue number for the python2.7 fix? I think I have hit upon this issue myself and I need to see if I need to file a new report. -- nosy: +Benjamin.Root ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10292 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10292] tarinfo should use relative symlinks
Benjamin Root added the comment: To clarify, the bug is resolved in py2.7 -- for the most part. I think I have come upon an edge-case where if the archived symbolic link refers to a file not contained in a subdirectory, say: foo.txt - foobar.txt, extracting foo.txt would result in an exception: 'KeyError: linkname '/foobar.txt' not found'. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10292 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10292] tarinfo should use relative symlinks
Lars Gustäbel l...@gustaebel.de added the comment: Okay, this bug has been fixed in the 2.7 series. Python 2.6 is now in security-fix-only mode which means that there will not be a fix for it. Therefore, I close this issue. -- resolution: - fixed status: open - closed versions: +Python 2.6 -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10292 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10292] tarinfo should use relative symlinks
Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10292 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10292] tarinfo should use relative symlinks
Changes by Martin v. Löwis mar...@v.loewis.de: -- assignee: - lars.gustaebel nosy: +lars.gustaebel ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10292 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10292] tarinfo should use relative symlinks
Lars Gustäbel l...@gustaebel.de added the comment: Apparently you were in quite a hurry when you filed this bug report. - What is the exact problem and how does it manifest itself? - Any helpful details (tracebacks, output)? - Is there a testcase or example code you can provide? - Which other tools are you talking about? - Your patch is faulty (upperdir is undefined). - The patch does not apply to neither r27 tag nor release27-maint branch although you claim that 2.7 is affected. - Which exact Python version are you using on what platform? - Oh, and a little more politeness wouldn't hurt. Okay, so please ask again. I am curious to see what you've found. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10292 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10292] tarinfo should use relative symlinks
Jasper St. Pierre jstpie...@mecheye.net added the comment: Oh man, attaching the wrong diff and getting the diff wrong. The issue I found with Python 2.7: when creating a simple link in tar: $ mkdir tar_test $ cd tar_test $ touch one $ ln -s one two $ cd .. $ tar czf tar_test.tgz tar_test It seems obvious that there would be a relative link in the tar file: -rwxrwxrwx jstpierre/me 2010-11-02 10:57:15 tar_test/two - one Unfortunately, as far as I can tell, tarfile treats this as an absolute path, and fails when extracting: tf.extractfile(tar_test/two) Traceback (most recent call last): File stdin, line 1, in module File /usr/lib/python2.6/tarfile.py, line 2122, in extractfile tarinfo)) File /usr/lib/python2.6/tarfile.py, line 2105, in extractfile if tarinfo.isreg(): AttributeError: 'NoneType' object has no attribute 'isreg' I was trying to fix that. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10292 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10292] tarinfo should use relative symlinks
Jasper St. Pierre jstpie...@mecheye.net added the comment: Uh, I just noticed the python2.6 in the traceback. Looks like I *was* using 2.6 because Cygwin decided to downgrade for some reason. Uh, sorry about that. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10292 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10292] tarinfo should use relative symlinks
New submission from JP St. Pierre jstpie...@mecheye.net: With all the tools I've used, the target of a symlink appears to be relative to the actual symlink entry. Fix this. -- components: Library (Lib) messages: 120208 nosy: magcius priority: normal severity: normal status: open title: tarinfo should use relative symlinks versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10292 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10292] tarinfo should use relative symlinks
Changes by JP St. Pierre jstpie...@mecheye.net: -- keywords: +patch Added file: http://bugs.python.org/file19462/tarinfo-10292.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10292 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
