[issue10712] 2to3 fixer for deprecated unittest method names
Ezio Melotti added the comment: Thanks! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
R. David Murray added the comment: I committed this to 2.7 in 9336b470544b but screwed up the copy and paste of the issue number so it didn't auto post. -- nosy: +r.david.murray resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Ezio Melotti added the comment: Here is an updated patch that is the same as my first patch but also includes the documentation provided by Berker (thanks!). -- Added file: http://bugs.python.org/file32808/issue10712-2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Serhiy Storchaka added the comment: LGTM. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Roundup Robot added the comment: New changeset cc0fc4e9b494 by Ezio Melotti in branch 'default': #10712: 2to3 has a new asserts fixer that replaces deprecated names of unittest methods. http://hg.python.org/cpython/rev/cc0fc4e9b494 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Ezio Melotti added the comment: Committed in 3.4, I'll backport it to 2.7/3.3 later. Thanks for the review! -- stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Changes by Serhiy Storchaka storch...@gmail.com: -- versions: -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Changes by Martin Panter vadmium...@gmail.com: -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Serhiy Storchaka added the comment: There are reasons why Ezio did not include assert*Regexp*-assert*Regex* in his patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Berker Peksag added the comment: I've converted Ezio's patch to Mercurial format, updated the lib2to3 documentation and added tests for assertRegexpMatches and assertRaisesRegexp aliases[1]. [1] http://docs.python.org/3.4/library/unittest.html#deprecated-aliases -- components: +2to3 (2.x to 3.x conversion tool) nosy: +berker.peksag Added file: http://bugs.python.org/file29332/issue10712_v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Ezio Melotti added the comment: Can this still go on 2.7/3.2/3.3? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Gregory P. Smith added the comment: Yes! 2to3 features are allowed in stable releases. On Mar 2, 2013 5:17 AM, Ezio Melotti rep...@bugs.python.org wrote: Ezio Melotti added the comment: Can this still go on 2.7/3.2/3.3? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Changes by Serhiy Storchaka storch...@gmail.com: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Bradley Froehle added the comment: Bikeshedding, but the fixer name of 'asserts' bugs me. I'd suggest 'unittest' or 'unittest_asserts'. -- nosy: +bfroehle ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Benjamin Peterson added the comment: Looks fine, though. Make sure to add docs to library/2to3.rst. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +gregory.p.smith versions: +Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Ezio Melotti added the comment: Ping. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Ezio Melotti ezio.melo...@gmail.com added the comment: Should this still go to the sandbox? and if so, what is the right sandbox? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Changes by Ezio Melotti ezio.melo...@gmail.com: -- assignee: - ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
New submission from Ezio Melotti ezio.melo...@gmail.com: The attached patch against 2.7 adds a new fixer to 2to3 that replaces deprecated unittest method names with the correct ones. There are a few issues: 1) only the safe renamings are included; the assert[SameElements|ItemsEqual|CountEqual] and the assert*Regexp*-assert*Regex* changes are missing; 2) unless 2to3 provides a way to specify a target version (e.g. 3.2 rather than just 3.x), the missing renamings can't be included; 3) the patch is against 2.7 but I'm not sure in what versions could/should be included, or if the fixer should (also|only) go on PyPI; 4) this fixer is useful from 3.1 to 3.2 too, is there a way to use it with 3.x versions only? 5) doc is still missing; -- files: issue10712.diff keywords: needs review, patch messages: 124054 nosy: benjamin.peterson, ezio.melotti, georg.brandl, michael.foord priority: normal severity: normal stage: patch review status: open title: 2to3 fixer for deprecated unittest method names type: feature request versions: Python 2.7, Python 3.2 Added file: http://bugs.python.org/file20062/issue10712.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10712] 2to3 fixer for deprecated unittest method names
Martin v. Löwis mar...@v.loewis.de added the comment: 2to3 patches should currently be made against and checked into the sandbox. -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10712 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
