[issue10961] Pydoc touchups in new browser for 3.2

[Georg Brandl]

Georg Brandl  added the comment:

I fixed two instances of missing HTML escaping and committed as r88261.  The 
code should be checked thoroughly for more such missing escaping.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Ron Adam]

Ron Adam  added the comment:

New and hopefully last patch... pydoc_misc_fix_e.diff

I removed the .html in the ?key= links as Eric suggested.

I checked the navbar float behavior on browsershots.org.  Multiple versions of 
MSIE, firefox, opera, chrome, and safari were tested on Ubuntu and Windows XP.  
They all looked very close to each other. Better than I expected. :-)

As for clearing floats, there is the html clear="all" attribute, and a css 
style="clear:both;".  The browsershots.org tests confirms style="clear:both;" 
works as it should where I used it.

Cheers, and hopefully this is ready to go.  I believe it is.

--
Added file: http://bugs.python.org/file20616/pydoc_misc_fix_e.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Éric Araujo]

Éric Araujo  added the comment:

Replied on Rietveld.

Ezio, I think you have good HTML/CSS knowledge, so I’m adding you to nosy.  If 
you could read the short discussion and Rietveld and weigh in, it would be very 
helpful.

--
nosy: +ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Ron Adam]

Ron Adam  added the comment:

Ok, after input from Eric,  Here is another patch.

Removed a set of unneeded parentheses.

Changed the title of the pages from PyDoc to Pydoc.

A better fix for the uncaught floats.  Wrap the main content in div with 
style="clear:both;". Should work on nearly everything.  Also avoided floating 
the "get" and "search" form inputs.  That was causing them to separate too much 
in IE.


To summarize ...

Minor fixes for new browser mode only.

Fix float problems with the navbar.
Change html page titles to "Pydoc" instead of "Python".
Call html.markup() on topic contents.
Fix topic/object shadowing.
Improved error handling. (Part of the shadowing fix.)

--
Added file: http://bugs.python.org/file20499/pydoc_misc_fix_d.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Ron Adam]

Changes by Ron Adam :


Removed file: http://bugs.python.org/file20473/pydoc_misc_fix_c.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Ron Adam]

Ron Adam  added the comment:

George, My apologies to you for the late corrections.  And thanks for doing 
this.

Eric, I replied to your comments on Rietveld.  Thanks for taking a look.

I'll wait until you have a chance to reply and test it, then upload a new patch 
with any needed changes.

Ron

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Éric Araujo]

Éric Araujo  added the comment:

Some comments on http://codereview.appspot.com/4090042

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Georg Brandl]

Georg Brandl  added the comment:

Sigh... that might have come a little earlier.

As it is, I'll review it before rc2.

--
assignee:  -> georg.brandl
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Ron Adam]

Changes by Ron Adam :


--
nosy: +eric.araujo, rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Ron Adam]

Changes by Ron Adam :


Removed file: http://bugs.python.org/file20468/pydoc_misc_fix.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Ron Adam]

Ron Adam  added the comment:

A few last minute changes.. I think this will be all.

Run topic contents through html.markup.  That makes ref:, pep:, and html: links 
if they exist.  (I meant to this earlier.)

Fix case where topic reference links are to objects rather than another topic.  
(applies to keywords also.)

Skips making an empty reference section if there are no references with a topic.

These are all small changes, and nothing should be controversial in this as 
everything changed only effects the new html browser mode.

--
Added file: http://bugs.python.org/file20473/pydoc_misc_fix_c.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Ron Adam]

Changes by Ron Adam :


Removed file: http://bugs.python.org/file20467/pydoc_misc_fix.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Ron Adam]

Ron Adam  added the comment:

new patch...

Adjusted a comment in the _gettopic method.

Everything else the same.

--
Added file: http://bugs.python.org/file20468/pydoc_misc_fix.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10961] Pydoc touchups in new browser for 3.2

[Ron Adam]

New submission from Ron Adam :

A collection of small fix's that only effect the new browser mode.

* Change title of html pages from "Python ..." to "PyDoc ...".

* Fixed unterminated div float for items returned without a header.
 example: str, None, True, False

* Added "topic?key=..." url command to explicitly get topics.  This is to avoid 
the shadowing when an object has the same name as a topic.

* Nicer parsing and error handling in the url handler.

--
components: Library (Lib)
files: pydoc_misc_fix.diff
keywords: patch
messages: 126633
nosy: georg.brandl, ron_adam
priority: normal
severity: normal
status: open
title: Pydoc touchups in new browser for 3.2
type: behavior
versions: Python 3.2
Added file: http://bugs.python.org/file20467/pydoc_misc_fix.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com