[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Irit Katriel]

Irit Katriel  added the comment:

I've created Issue45935 for the missing test and will close this as resolved in 
version 3.3.

--
nosy: +iritkatriel
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue45935] Add test for Issue11109: socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass.

[Irit Katriel]

New submission from Irit Katriel :

As mentioned in https://bugs.python.org/issue11109#msg136869, test_socketserver 
needs to be updated to serve as a regression test for Issue11109.

--
components: Tests
messages: 407335
nosy: giampaolo.rodola, gregory.p.smith, iritkatriel, jwarkentin, orsenthil, 
python-dev, vstinner
priority: normal
severity: normal
status: open
title: Add test for Issue11109: socketserver.ForkingMixIn leaves zombies, also 
fails to reap all zombies in one pass.
type: enhancement
versions: Python 3.11

___
Python tracker 
<https://bugs.python.org/issue45935>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Roundup Robot]

Roundup Robot added the comment:

New changeset 991c24b8969d by R David Murray in branch '3.3':
#11109: clean up docs, add whatsnew entry, and fix Justin's last name.
http://hg.python.org/cpython/rev/991c24b8969d

New changeset 1234300bc056 by R David Murray in branch 'default':
Merge #11109: clean up docs, add whatsnew entry, and fix Justin's last name.
http://hg.python.org/cpython/rev/1234300bc056

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Justin Warkentin]

Justin Warkentin justin.warken...@gmail.com added the comment:

Sorry, I haven't had a chance to look at this in a couple days. I've been very 
busy with work. I'm not sure exactly how to write the test for this, so I don't 
know that I'd be much help there.

One last thing, I was just looking through the commits and I noticed in the 
NEWS update (http://hg.python.org/cpython/rev/3e3cd0ed82bb/) you have my name 
as Justin Wark. The last name is actually Warkentin, I just didn't have 
anything showing that. That's my fault, sorry. I just updated my profile to 
show my full name.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Roundup Robot]

Roundup Robot devnull@devnull added the comment:

New changeset e2363b1c4bca by Senthil Kumaran in branch 'default':
Fix closes issue #11109 -  socketserver.ForkingMixIn leaves zombies, also fails 
to reap all zombies in one pass.
http://hg.python.org/cpython/rev/e2363b1c4bca

New changeset 3e3cd0ed82bb by Senthil Kumaran in branch 'default':
News entry for issue11109.
http://hg.python.org/cpython/rev/3e3cd0ed82bb

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Senthil Kumaran]

Senthil Kumaran sent...@uthcode.com added the comment:

The feature is in 3.3. I did not remove the handle_timeout method from the 
Mixin class, because it might be used in the production by the existing 
servers. It is not appropriate to remove methods all of sudden without 
deprecation warnings and also it is not required to remove in this case.

Added the Documentation and News entry too.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Senthil Kumaran]

Senthil Kumaran sent...@uthcode.com added the comment:

This is fixed in 3.3 now. Keeping it open for test_socketserver update. After a 
ForkingServer service call, it should be asserted the collect_children routine 
is run.

--
resolution:  - fixed
stage: patch review - committed/rejected
versions:  -Python 2.7, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[STINNER Victor]

STINNER Victor victor.stin...@haypocalc.com added the comment:

 New changeset 3e3cd0ed82bb by Senthil Kumaran in branch 'default':
 News entry for issue11109.
 http://hg.python.org/cpython/rev/3e3cd0ed82bb

Please try to format NEWS entries using Issue #xxx: xxx instead of Issue 
#xxx - xxx.

--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Senthil Kumaran]

Senthil Kumaran sent...@uthcode.com added the comment:

Victor - Sure, I understand Issue #xxx: desc must be useful while generation 
reST docs.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Senthil Kumaran]

Senthil Kumaran sent...@uthcode.com added the comment:

Justin,

The patch and logic is okay. We can have this is 3.3.

- I find that loop_actions as not appropriate name for the new method. It fails 
to give a intuitive meaning of what is supposed to do. request_action, 
request_action_continued or anything else which gives a meaning should be 
helpful.  I agree with your reasoning to provide some flexiblity for the user 
to override this.

- The patch lacks Documentation and tests should be added to 
Lib/test/test_socketserver.py.  If you can, please append the patch with these, 
otherwise I shall do it.

A suggestion for better method name is a must! :)

Thanks!

--
assignee: gregory.p.smith - orsenthil
nosy: +orsenthil

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Justin]

Justin justin.warken...@gmail.com added the comment:

Don't mean to nag. Just checking to see if anyone has taken it upon themselves 
to commit this yet since it's been a couple more months :P

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Gregory P. Smith]

Gregory P. Smith g...@krypto.org added the comment:

not yet, thanks for the reminder.  if any other committers feel like jumping on 
this and doing it before I get around to it, feel free.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Justin]

Justin justin.warken...@gmail.com added the comment:

Just following up on this. Now that 3.2 is out, has the patch been committed?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Gregory P. Smith]

Gregory P. Smith g...@krypto.org added the comment:

I believe that is good.  I'll commit it after the 3.2 release has been cut 
(we're in release candidate release blocker only lockdown right now).

Looking at ForkingMixIn.collect_children() there appears to be another buglet: 
it loops over self.active_children and calls self.active_children.remove(pid).  
This modification of the list while looping over it will cause it to skip the 
next item in the list.  For every child waited on successfully, it skips 
checking one of the others.

--
title: socketserver.ForkingMixIn leaves zombies - socketserver.ForkingMixIn 
leaves zombies, also fails to reap all zombies in one pass

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Gregory P. Smith]

Changes by Gregory P. Smith g...@krypto.org:


--
assignee:  - gregory.p.smith

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Justin]

Justin justin.warken...@gmail.com added the comment:

I noticed that ForkingMixIn also was overriding handle_timeout() trying to 
cleanup zombies after 300 seconds of inactivity, which is useless on a busy 
server. I'm replacing the patch with one that also removes handle_timeout().

--
Added file: http://bugs.python.org/file20691/loop_actions.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Justin]

Changes by Justin justin.warken...@gmail.com:


Removed file: http://bugs.python.org/file20690/loop_actions.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Justin]

Changes by Justin justin.warken...@gmail.com:


Removed file: http://bugs.python.org/file20691/loop_actions.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Justin]

Changes by Justin justin.warken...@gmail.com:


Added file: http://bugs.python.org/file20693/loop_actions.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Justin]

Justin justin.warken...@gmail.com added the comment:

I hope I did that last patch right. I did a 'diff -u' instead of a 'diff -c'. 
If you need something different, let me know.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

[Justin]

Justin justin.warken...@gmail.com added the comment:

Sorry I keep plaguing this with comments and files, but I got to thinking, 
anyone should be able to override _loop_actions() and implement what they need 
in the loop. While it's probably a bad idea in most cases, there may be 
legitimate needs and it's always good to allow the flexibility. So, I'm adding 
one more patch that changes the name to loop_actions() and adds it to the list 
of methods that can be overridden in the BaseServer docstring. If you like it, 
keep it, if not, just use the last one.

--
Added file: http://bugs.python.org/file20695/loop_actions.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11109
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com