[issue11551] test_dummy_thread.py test coverage improvement

[Senthil Kumaran]

Changes by Senthil Kumaran :


--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Roundup Robot]

Roundup Robot added the comment:

New changeset 08f446bf45a7 by Senthil Kumaran in branch '3.5':
Issue11551 - Increase the test coverage of _dummy_thread module to 100%.
https://hg.python.org/cpython/rev/08f446bf45a7

New changeset d69e0df64b11 by Senthil Kumaran in branch 'default':
[merge from 3.5] Issue11551 - Increase the test coverage of _dummy_thread 
module to 100%.
https://hg.python.org/cpython/rev/d69e0df64b11

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Senthil Kumaran]

Senthil Kumaran added the comment:

Here is an updated patch that increases the coverage to 100% and has some pep8 
style improvements.


shannon-2:issue11551 senthil$ ./python.exe -m test.regrtest test_dummy_thread
Run tests sequentially
0:00:00 [1/1] test_dummy_thread
1 test OK.

Total duration: 23 ms
Tests result: SUCCESS

shannon-2:issue11551 senthil$ ./python.exe -m coverage run --pylib 
--source=_dummy_thread Lib/test/regrtest.py test_dummy_thread
Run tests sequentially
0:00:00 [1/1] test_dummy_thread
1 test OK.

Total duration: 82 ms
Tests result: SUCCESS

shannon-2:issue11551 senthil$ ./python.exe -m coverage report --show-missing
Name   Stmts   Miss  Cover   Missing

Lib/_dummy_thread.py  64  0   100%


Since these are restricted to test improvements and have addressed the comments 
from previous reviews, I am going ahead with committing this patch. If there 
are any further comments, we can address them in subsequent commits.

--
Added file: http://bugs.python.org/file44461/issue11551.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Senthil Kumaran]

Senthil Kumaran added the comment:

I've updated the patch to use unittest.mock, the removed the old style way of 
exercising it.

--
nosy: +orsenthil
Added file: http://bugs.python.org/file44429/issue11551.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Joseph Gordon]

Changes by Joseph Gordon :


--
nosy: +josephgordon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Mark Lawrence]

Mark Lawrence added the comment:

@Denver are you still interested in working on this as a week or two has 
passed? :)

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11551
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Brian Curtin]

Changes by Brian Curtin br...@python.org:


--
nosy:  -brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11551
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Ezio Melotti]

Changes by Ezio Melotti ezio.melo...@gmail.com:


--
keywords: +easy
nosy: +ezio.melotti, ramchandra.apte
stage:  - patch review
versions: +Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11551
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Denver Coneybeare]

Denver Coneybeare denver.coneybe...@gmail.com added the comment:

I've looked at the review (thanks for the review) and can submit an updated 
patch.  I don't have the Python source code pulled down to my PC anymore so it 
might take a week or two before I'm able to update the patch and test it out.  
I imagine that's not too much of a problem though :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11551
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Sandro Tosi]

Sandro Tosi sandro.t...@gmail.com added the comment:

Hi Denver, do you have the time to address the review on rietveld and propose a 
new patch?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11551
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Sandro Tosi]

Sandro Tosi sandro.t...@gmail.com added the comment:

I run a review on rietveld, just minor stuff (even though I don't see the 100% 
coverage).

--
nosy: +sandro.tosi

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11551
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Denver Coneybeare]

New submission from Denver Coneybeare denver.coneybe...@gmail.com:

The attached patch increases the test coverage of the module _dummy_thread from 
78% to 100%.

--
components: Tests
files: test_dummy_thread_test_coverage_improvement.patch
keywords: patch
messages: 130957
nosy: brian.curtin, denversc
priority: normal
severity: normal
status: open
title: test_dummy_thread.py test coverage improvement
type: behavior
versions: Python 3.3
Added file: 
http://bugs.python.org/file21204/test_dummy_thread_test_coverage_improvement.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11551
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Denver Coneybeare]

Changes by Denver Coneybeare denver.coneybe...@gmail.com:


Added file: 
http://bugs.python.org/file21206/test_dummy_thread_test_coverage_improvement_v2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11551
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11551] test_dummy_thread.py test coverage improvement

[Denver Coneybeare]

Changes by Denver Coneybeare denver.coneybe...@gmail.com:


--
nosy: +brett.cannon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11551
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com