[issue11582] Boilerplate code replaced in Python/ceval.c
A.M. Kuchling added the comment: Closing, because neither Amaury nor Raymond likes the idea. Thanks for your work, anyway! -- nosy: +akuchling resolution: - rejected stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11582 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11582] Boilerplate code replaced in Python/ceval.c
Changes by Francis MB franci...@email.de: -- type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11582 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11582] Boilerplate code replaced in Python/ceval.c
New submission from knickerkicker knicker.kic...@gmail.com: Replaced boilerplate implementations of several BINARY_* and INPLACE_* opcodes with two macros. The result shaves off 154 lines from Python/ceval.c. -- components: Interpreter Core files: 20110317_ceval.patch keywords: patch messages: 131230 nosy: knicker.kicker priority: normal severity: normal status: open title: Boilerplate code replaced in Python/ceval.c versions: Python 3.1, Python 3.2, Python 3.3, Python 3.4 Added file: http://bugs.python.org/file21264/20110317_ceval.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11582 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11582] Boilerplate code replaced in Python/ceval.c
Amaury Forgeot d'Arc amaur...@gmail.com added the comment: Hmm, this kind of macros make it difficult to step line by line in a debugger. From this point of view, an inlined function would be better, I'm not sure if this can have a performance impact though. -- nosy: +amaury.forgeotdarc ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11582 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11582] Boilerplate code replaced in Python/ceval.c
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11582 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11582] Boilerplate code replaced in Python/ceval.c
knickerkicker knicker.kic...@gmail.com added the comment: Creating a inline function would require passing the stackpointer variable so that the TOP() and POP() macros continue working, and creating variables for u, v and x. I am not sure if that will not have a performance impact - ideally it shouldn't, but can we trust the compilers to see what we're upto? Also, the DISPATCH() macro will still need to be outside the inline function. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11582 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11582] Boilerplate code replaced in Python/ceval.c
Raymond Hettinger raymond.hettin...@gmail.com added the comment: -1 I think this will make the code harder to understand and maintain. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11582 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11582] Boilerplate code replaced in Python/ceval.c
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- priority: normal - low versions: -Python 3.1, Python 3.2, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11582 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
