[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2016-09-05 Thread Zachary Ware 

Zachary Ware added the comment:

Thanks for the original patch, Tim!

After discussion with Steve, we figured it's best to keep this to 3.6.

--
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2016-09-05 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 8fa615a2a896 by Zachary Ware in branch 'default':
Closes #11620: Fix support for SND_MEMORY in winsound.PlaySound.
https://hg.python.org/cpython/rev/8fa615a2a896

--
nosy: +python-dev
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2016-08-14 Thread Zachary Ware 

Zachary Ware added the comment:

Here's an updated patch.  I'm a little wary of applying this on 3.5, because it 
is backward-incompatible: a str is no longer accepted with SND_MEMORY.  On the 
other hand, it's pretty much a fluke if that works at all currently.

--
assignee:  -> zach.ware
stage: needs patch -> patch review
Added file: http://bugs.python.org/file44104/issue11620.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2016-08-03 Thread Zachary Ware 

Zachary Ware added the comment:

Irmen, you're probably correct that this was overlooked at the time of 3.0.

The patch is well out of date as well, winsound was Clinicized around the 3.4 
timeframe.

--
assignee: brian.curtin -> 
keywords:  -needs review
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
stage: patch review -> needs patch
versions: +Python 3.6 -Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2016-02-13 Thread Irmen de Jong 

Irmen de Jong added the comment:

Ran into this today when trying to provide a fallback sound output on windows 
when the user hasn't got pyaudio installed.
It seems that this module has been forgotten and didn't get fixed when the 
str/bytes change happened in Python 3.0?

--
nosy: +irmen

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2016-02-13 Thread Irmen de Jong 

Changes by Irmen de Jong :


--
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2013-09-30 Thread Eric Snow 

Eric Snow added the comment:

I ran into this today.  Can't we just change the Z to z# in the format 
string (or z*)?  Other than that, Tim's patch makes sense.

--
nosy: +eric.snow
versions: +Python 3.3, Python 3.4 -Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11620
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2012-02-09 Thread Tim Lesher 

Tim Lesher tles...@gmail.com added the comment:

This patch should both correct the incorrect acceptance of strings and the 
incorrect rejection of buffer objects when using SND_MEMORY.

--
keywords: +patch
Added file: http://bugs.python.org/file24470/11620-PlaySound.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11620
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2012-02-09 Thread Brian Curtin 

Changes by Brian Curtin br...@python.org:


--
assignee:  - brian.curtin
keywords: +needs review
stage: needs patch - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11620
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2011-06-03 Thread Tim Lesher 

Changes by Tim Lesher tles...@gmail.com:


--
nosy: +tlesher

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11620
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2011-04-28 Thread Sijin Joseph 

Changes by Sijin Joseph sijinjos...@gmail.com:


--
nosy: +sijinjoseph

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11620
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2011-03-22 Thread Brian Curtin 

Changes by Brian Curtin br...@python.org:


--
components: +Extension Modules, Windows -Library (Lib)
nosy: +brian.curtin
stage:  - needs patch
type:  - behavior

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11620
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11620] winsound.PlaySound() with SND_MEMORY should accept bytes instead of strings

2011-03-20 Thread Tom Felker 

New submission from Tom Felker tomfel...@gmail.com:

PlaySound supposedly lets you play a .WAV file whose contents are stored in a 
string, by passing the string and flags including winsound.SND_MEMORY.  I'm 
trying to use BytesIO object and the wave module to make a file in-memory, and 
pass this to winsound.  It's a TypeError if I pass the resultant bytes object 
directly, and if I pass a string object, I get

TypeError: must be str without null character or None, not str

Since wav files can contain zeros, for the feature to work at all, the C code 
would need to detect the SND_MEMORY flag and interpret the first argument as a 
bytes object, instead of a null-terminated string, in that case.

--
components: Library (Lib)
messages: 131583
nosy: Tom.Felker
priority: normal
severity: normal
status: open
title: winsound.PlaySound() with SND_MEMORY should accept bytes instead of 
strings
versions: Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11620
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com