[issue11702] dir on return value of msilib.OpenDatabase() crashes python

[Irit Katriel]

Change by Irit Katriel :


--
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder:  -> Special method lookup fails on uninitialized types

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11702] dir on return value of msilib.OpenDatabase() crashes python

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11702] dir on return value of msilib.OpenDatabase() crashes python

[Terry J. Reedy]

Terry J. Reedy added the comment:

This is a generic issue as there are multiple unready types that can raise (or 
in this case crash) with code that should work.  #26906 gives other examples 
and discussion of possible generic solutions that would make this issue 
obsolete.

--
nosy: +serhiy.storchaka, terry.reedy
versions: +Python 3.5, Python 3.6, Python 3.7 -Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11702] dir on return value of msilib.OpenDatabase() crashes python

[Mark Lawrence]

Mark Lawrence added the comment:

The attached patch is short and sweet and looks okay to my untrained eye.  I 
believe it should apply cleanly as there've been very few changes to _msi.c.  
Can we have a formal patch review please.

--
nosy: +BreamoreBoy, steve.dower, tim.golden, zach.ware

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11702
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11702] dir on return value of msilib.OpenDatabase() crashes python

[Brian Curtin]

Changes by Brian Curtin br...@python.org:


--
nosy:  -brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11702
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11702] dir on return value of msilib.OpenDatabase() crashes python

[Mark Mc Mahon]

Mark Mc Mahon mtnbikingm...@gmail.com added the comment:

I wasn't so happy trawling through \windows\installer either :) 

Creating an MSI to test is very simple, and actually quicker than I had 
originally thought. The latest patch (support_dir_for_msi_objs.patch) creates 
the one and just uses that. Optionally I could create a new one each time 
setUp()/tearDown(). But was thinking - let's do that if/when we need to :)

The latest patch updates the tests - but no change to the C code.

(I doubt the error you received is a bug in msilib, and I couldn't repro even 
by opening EVERY MSI in my windows\installer dir. It could be a rights/security 
issue? The previous test was not opening as READ ONLY - even though it never 
saved the db, so that may be another reason?)

--
Added file: http://bugs.python.org/file22043/support_dir_for_msi_objs.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11702
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11702] dir on return value of msilib.OpenDatabase() crashes python

[Brian Curtin]

Brian Curtin br...@python.org added the comment:

If we can generate a testable MSI file that would be the best. Including a very 
small pre-generated MSI for the purposes of the test would be acceptable.

As-is, the tests don't pass because my machine has 
C:\Windows\installer\1032f.msi that gets used for the test, which apparently 
doesn't work with this functionality, and other machines may end up with the 
same situation. I'm not sure if that's a bug in the code or in whatever MSI 
that is, though. The OpenDatabase call returns unknown error 6e for both new 
tests.

--
nosy: +brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11702
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11702] dir on return value of msilib.OpenDatabase() crashes python

[Mark Mc Mahon]

Mark Mc Mahon mtnbikingm...@gmail.com added the comment:

That fixed it - but it seems we need that for the other Types defined in the 
module.

Regarding testing - would it be a good idea to add an MSI to the test suite - 
or better to create one during testing (using msilib) and then use that in the 
tests?

--
Added file: http://bugs.python.org/file21466/msi_opendatabase_2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11702
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11702] dir on return value of msilib.OpenDatabase() crashes python

[Mark Mc Mahon]

New submission from Mark Mc Mahon mtnbikingm...@gmail.com:

Running the following code:

 import msilib
 db  = msilib.OpenDatabase('c:/windows/installer/1c7a1.msi', 1)
 db
_msi.Database object at 0x01E230A0
 dir(db)

(Python crashes - tested on current Trunk and Python 2.7.1).

I tried tracking it through the C code - and it seems to be a problem when dir 
is checking for __dir__ (the pointer in PyObject_GetAttrString seems to be 
incorrect).

--
components: Windows
messages: 132402
nosy: markm
priority: normal
severity: normal
status: open
title: dir on return value of msilib.OpenDatabase() crashes python
type: crash
versions: Python 2.7, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11702
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11702] dir on return value of msilib.OpenDatabase() crashes python

[Éric Araujo]

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11702
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11702] dir on return value of msilib.OpenDatabase() crashes python

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc amaur...@gmail.com added the comment:

A call to PyType_Ready() fixes the issue, see attached patch.
I added a test that opens a random file in c:\windows\installer, I don't know 
if this is correct for all Windows version.

--
keywords: +patch
nosy: +amaury.forgeotdarc
stage:  - patch review
Added file: http://bugs.python.org/file21445/msi_opendatabase.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11702
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com