[issue1194222] parsedate and Y2K
Jeffrey Finkelstein jeffrey.finkelst...@gmail.com added the comment: Attached a patch with just the y2k changes and new unit test, for the py3k branch. -- Added file: http://bugs.python.org/file18629/issue1194222-py3k.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
Jeffrey Finkelstein jeffrey.finkelst...@gmail.com added the comment: Attached a patch with just the y2k changes and new unit test, for the trunk branch. -- Added file: http://bugs.python.org/file18630/issue1194222-trunk.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
Jeffrey Finkelstein jeffrey.finkelst...@gmail.com added the comment: Added my copyright information to the patch for trunk. -- Added file: http://bugs.python.org/file18631/issue1194222-trunk.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
Changes by Jeffrey Finkelstein jeffrey.finkelst...@gmail.com: Removed file: http://bugs.python.org/file18630/issue1194222-trunk.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
R. David Murray rdmur...@bitdance.com added the comment: Adding a copyright notice for a patch is not something that we generally do (and your current mod is implicitly claiming the whole file, which doesn't seem right in any case). My understanding is that US copyright law says you have the copyright whether there's a notice or not, so you don't have to worry about putting anything in there (even assuming such a small piece of code is copyrightable, which is debatable). Signing the contributor agreement is enough to grant redistribution rights to the code, regardless, so really nothing needs to be added. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
Jeffrey Finkelstein jeffrey.finkelst...@gmail.com added the comment: Removed copyright additions from patch. -- Added file: http://bugs.python.org/file18633/issue1194222-py3k.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
Jeffrey Finkelstein jeffrey.finkelst...@gmail.com added the comment: Removed copyright additions from patch. -- Added file: http://bugs.python.org/file18634/issue1194222-trunk.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
R. David Murray rdmur...@bitdance.com added the comment: Applied in r84310. Leaving issue open pending backport. Thanks, Jeffrey. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
R. David Murray rdmur...@bitdance.com added the comment: Ported to 2.7 in r84311 and to 3.1 in r84312. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
R. David Murray rdmur...@bitdance.com added the comment: Thanks for working on this. I would prefer to have two patches: one that fixes the bug (and adds the unit tests) and a separate one for the cleanups (in a new issue). I agree that the fact that it isn't complying with the RFC makes it a bug. It seems unlikely that fixing this would break anyone's code, since if they are already working around the bug the return of a four digit year should cause their workaround code to be skipped. -- type: feature request - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
Mark Lawrence breamore...@yahoo.co.uk added the comment: I couldn't apply the py3k version of the patch which contains changed unit tests. Would someone please review this patch. -- nosy: +BreamoreBoy stage: unit test needed - patch review versions: +Python 3.2 -Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
Jeffrey Finkelstein jeffrey.finkelst...@gmail.com added the comment: Sorry about that; the diff paths have the a/ and b/ prefixes. Patch with -p1 at the top-level directory: patch -p1 issue1194222fix-py3k.diff -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
Éric Araujo mer...@netwok.org added the comment: -p1 is the default for patch, so it should work. Is this a bug fix or a feature request? It’s unclear. If it’s a bug fix, please add 2.7 and 3.1 to versions. -- assignee: - r.david.murray nosy: +eric.araujo, l0nwlf, r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
Jeffrey Finkelstein jeffrey.finkelst...@gmail.com added the comment: I suppose this is a bug fix because it changes the behavior of email.utils.parsedate_tz() to match the RFC standards. -- versions: +Python 2.7, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
Éric Araujo mer...@netwok.org added the comment: What I wrote on Rietveld: I don’t know much about email, but the code itself looks good to me. The fact that you didn’t have to change any test but added one is reassuring (unless it reveals lack of coverage). http://codereview.appspot.com/217107/diff/1/2#newcode1 Lib/email/_parseaddr.py:1: # Copyright (C) 2002-2007, 2010 Python Software Foundation “2002-2010” would make more sense. http://codereview.appspot.com/217107/diff/1/2#newcode24 Lib/email/_parseaddr.py:24: DOY_UNKNOWN = 1 Can you add a comment explaining what DOY means, unless it’s obvious for email specialists? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1194222] parsedate and Y2K
Daniel Diniz aja...@gmail.com added the comment: Confirmed in trunk and py3k. -- keywords: +easy, patch nosy: +ajaksu2 stage: - test needed type: - feature request versions: +Python 2.7, Python 3.1 -Python 2.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1194222 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
