[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 402c4bbedf9c by Éric Araujo in branch '3.2': Refactor the copying of xxmodule.c in distutils tests (#12141). http://hg.python.org/cpython/rev/402c4bbedf9c -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 7d9fa30c5588 by Éric Araujo in branch '3.2': Refactor the copying of xxmodule.c in distutils tests (#12141). http://hg.python.org/cpython/rev/7d9fa30c5588 New changeset 900738175779 by Éric Araujo in branch 'default': Refactor the copying of xxmodule.c in packaging tests (#12141). http://hg.python.org/cpython/rev/900738175779 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Éric Araujo mer...@netwok.org added the comment: BTW, doesn’t the change to Makefile.pre.in need to be ported to the MSI build system too? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Roundup Robot devnull@devnull added the comment: New changeset c8ffa3891d5e by Ned Deily in branch '2.7': Issue #12141: Install a copy of template C module file so that http://hg.python.org/cpython/rev/c8ffa3891d5e New changeset de226a510b52 by Ned Deily in branch '3.2': Issue #12141: Install a copy of template C module file so that http://hg.python.org/cpython/rev/de226a510b52 New changeset ef8e9e99de88 by Ned Deily in branch 'default': Issue #12141: Install copies of template C module file so that http://hg.python.org/cpython/rev/ef8e9e99de88 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Ned Deily n...@acm.org added the comment: Patches applied as described above for 3.3, 3.2.1, and 2.7.3. I'm setting the status of the issue to pending and, assuming there are no buildbot failures in the near future, I will close it unless anyone sees a reason not to. -- resolution: - fixed stage: patch review - committed/rejected status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Changes by Ned Deily n...@acm.org: -- status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Ned Deily n...@acm.org added the comment: Are the patches good to go? And would you like me to apply them? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Éric Araujo mer...@netwok.org added the comment: I think they are ready, I gave a +1 (with a typo: path instead of patch :) two messages ago. -- versions: -Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Éric Araujo mer...@netwok.org added the comment: See also #10764. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Éric Araujo mer...@netwok.org added the comment: Path LGTM. Also +1 on keeping distutils and packaging wholly separate, including in tests infrastructure. It’s just one file. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Ned Deily n...@acm.org added the comment:
Here are patches to install a copy of xxmodule.c in the distutils tests
directory (for 3.3, 3.2, and 2.7) and a copy in packaging tests for 3.3. With
them in place, test_build_ext/test_command_build_ext now executes when the
tests are run from an installed Python where no source directory is available
and each test case run copies the c file into its temp dir.
Currently, those test are being silently skipped in the installed case or,
worse, picking up the wrong version of xxmodule.c depending on what
sysconfig.get_config_vars('srcdir') returns (this happened to me when I reused
a source directory name in some builds). For 3.2, a patch is included to
backport the Distutils part of the fix for issue12132.
--
components: +Distutils, Distutils2
keywords: +patch
nosy: +alexis
stage: - patch review
Added file: http://bugs.python.org/file22346/issue12141_3x.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12141
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Changes by Ned Deily n...@acm.org: Added file: http://bugs.python.org/file22347/issue12132_backport_32.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Changes by Ned Deily n...@acm.org: Added file: http://bugs.python.org/file22348/issue12141_32.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Changes by Ned Deily n...@acm.org: Added file: http://bugs.python.org/file22349/issue12141_27.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
R. David Murray rdmur...@bitdance.com added the comment: Is it really necessary to copy this file? I haven't looked at the tests, but I'm wondering if they are using xxmodule.c only because it already existed. Could the test instead use a much simpler .c file that it creates on the fly? -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Ned Deily n...@acm.org added the comment: I think one of the objectives of the test is to see that it works with the C API of that particular Python release as captured in its version of xxmodule.c. And, while it could be argued that both distutils and packaging don't need their own copies, I think it is cleaner to keep the two testing environment uncoupled. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo versions: -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12141 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12141] sysconfig.get_config_vars('srcdir') fails in specific cases
Tarek Ziadé ziade.ta...@gmail.com added the comment:
@ned: right. done, and fixes issue12132
--
assignee: pitrou - tarek
components: +Library (Lib)
title: --multiprocessing fails with packaging.tests.test_command_build_ext -
sysconfig.get_config_vars('srcdir') fails in specific cases
versions: +Python 2.7, Python 3.1, Python 3.2, Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12141
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
