[issue12306] zlib: Expose zlibVersion to query runtime version of zlib
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset b21d1de6d78e by Nadeem Vawda in branch 'default': Issue #12306: Add ZLIB_RUNTIME_VERSION to the zlib module. http://hg.python.org/cpython/rev/b21d1de6d78e -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12306 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12306] zlib: Expose zlibVersion to query runtime version of zlib
Nadeem Vawda nadeem.va...@gmail.com added the comment: I've committed your patches. I took the liberty of removing the versionadded tag for ZLIB_VERSION; I don't think many people will need to worry about compatibility with Python 1.5 ;-) Once again, thanks for the patches! -- assignee: - nadeem.vawda resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12306 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12306] zlib: Expose zlibVersion to query runtime version of zlib
Torsten Landschoff t.landsch...@gmx.net added the comment: Here is an updated patch: * Function zlibVersion() replaced by module-level constant ZLIB_RUNTIME_VERSION * Added documentation (with versionadded: 3.3) -- Added file: http://bugs.python.org/file22343/zlib_runtime_version.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12306 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12306] zlib: Expose zlibVersion to query runtime version of zlib
Torsten Landschoff t.landsch...@gmx.net added the comment: Documentation for ZLIB_VERSION. I just notice that it makes no sense to add the version info to that section. Feel free to move the two snippets. I added a versionadded tag here as well (ZLIB_VERSION was already in Python 1.5). Is there any old release for that versionadded tags should be removed? -- Added file: http://bugs.python.org/file22344/zlib_version_doc.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12306 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12306] zlib: Expose zlibVersion to query runtime version of zlib
Changes by Nadeem Vawda nadeem.va...@gmail.com: -- nosy: +nadeem.vawda ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12306 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12306] zlib: Expose zlibVersion to query runtime version of zlib
Antoine Pitrou pit...@free.fr added the comment: Good idea, and thanks for posting a patch! This is a new feature, so 3.3-only. Also, you'll need to update the docs (Doc/library/zlib.rst, presumably) to add the new module method/attribute (with a suitable versionadded tag). Nitpicking: - zlibVersion isn't PEP8-compliant - semantically it should probably be a module-level attribute, rather than a method; after all it's kind of a constant; perhaps ZLIB_RUNTIME_VERSION? Also, I see that ZLIB_VERSION itself isn't documented, it would be nice to have a separate patch to fix that. -- nosy: +pitrou stage: - patch review versions: -Python 2.7, Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12306 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12306] zlib: Expose zlibVersion to query runtime version of zlib
Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12306 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12306] zlib: Expose zlibVersion to query runtime version of zlib
New submission from Torsten Landschoff t.landsch...@gmx.net: I am currently fighting a curious problem in using zlib from Python: Decompression completes but sometimes the resulting output does not match a sha224 hash of the expected output. I deployed a zlib 1.2.5 with our PyInstaller output but the problem persists. I would like to check that the program is actually using the right zlib version. zlib provides the function zlibVersion to access the actual run time version. The attached patch exposes this function from the zlib module. I also added a unit test to check that the function is there and the output matches ZLIB_VERSION (which should match on the build machine). -- components: Library (Lib) files: zlibversion.diff keywords: patch messages: 138044 nosy: torsten priority: normal severity: normal status: open title: zlib: Expose zlibVersion to query runtime version of zlib type: feature request versions: Python 2.7, Python 3.2, Python 3.3 Added file: http://bugs.python.org/file22307/zlibversion.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12306 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12306] zlib: Expose zlibVersion to query runtime version of zlib
Changes by Torsten Landschoff t.landsch...@gmx.net: Added file: http://bugs.python.org/file22308/zlibversion_py3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12306 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
