[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[Christian Heimes]

Christian Heimes added the comment:

Not a bug in the SSL module.

--
assignee: christian.heimes -> 
components:  -SSL
versions: +Python 2.7 -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[Christian Heimes]

Changes by Christian Heimes :


--
assignee:  -> christian.heimes
components: +SSL
nosy: +christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[Christian Heimes]

Changes by Christian Heimes :


--
stage: needs patch -> patch review
versions: +Python 3.5, Python 3.6, Python 3.7 -Python 2.7, Python 3.2, Python 
3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[Milan Oberkirch]

Milan Oberkirch added the comment:

I agree that there is not much we can do on the server side (see issue 19806) 
and with the fix for issue 19662 the server won't recognize this error at all 
(patiently waiting for b'\r\n\' which is unlikely to appear in the first 
handshake-message from the client).

Attached is a smtplib patch for 3.x.

--
nosy: +jesstess, zvyn
Added file: http://bugs.python.org/file36037/issue12378_py35.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12378
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[Giampaolo Rodola']

Giampaolo Rodola' added the comment:

 @Giampaolo can you add anything to this?

As for smptd encoding error I think a reasonable thing to do would be to reply 
with 501 Can't decode command.. There's no way for the server to return a 
more specific error message (e.g. SSL is not supported). ...And just for 
clarity/completeness, smtpd module cannot support SSL because asyncore doesn't.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12378
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[Mark Lawrence]

Mark Lawrence added the comment:

@Giampaolo can you add anything to this?

--
nosy: +giampaolo.rodola

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12378
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[brian morrow]

brian morrow added the comment:

Not sure if this is still relevant, but I've supplied a python2.7 patch for 
this issue. All regression tests still pass and the underlying socket 
connection is closed:

bmorrow@xorange:~/cpython$ ./python -m smtpd -n -c DebuggingServer 
localhost:2525

 import smtplib
 s = smtplib.SMTP_SSL(localhost, 2525)
[...]
ssl.SSLError: [Errno 1] _ssl.c:510: error:140770FC:SSL 
routines:SSL23_GET_SERVER_HELLO:unknown protocol

bmorrow@xorange:~/cpython$ ps -ef | grep ./python
bmorrow  19052 19742  0 19:08 pts/17   00:00:00 ./python

bmorrow@xorange:~/cpython$ lsof -P -p 19052 | grep 2525
bmorrow@xorange:~/cpython$ 

bmorrow@xorange:~/cpython$ lsof -P -p 19742 | grep 2525
bmorrow@xorange:~/cpython$

--
keywords: +patch
nosy: +bhm
Added file: http://bugs.python.org/file35743/issue12378_py27.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12378
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[Mark Lawrence]

Mark Lawrence added the comment:

I don't know where we stand with this as it references asyncore which is 
deprecated in favour of asynio, can someone please advise.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12378
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[Catalin Iacob]

Changes by Catalin Iacob iacobcata...@gmail.com:


--
nosy: +catalin.iacob

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12378
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[Catalin Iacob]

Catalin Iacob iacobcata...@gmail.com added the comment:

Just a note after running Joe's example. smtplib is affected by this issue in 
3.x, but the example produces different results in 3.x: smtpd doesn't keep the 
connection open due to UnicodeDecodeError when the data from the ssl handshake 
cannot be decoded as utf-8:

error: uncaptured python exception, closing channel __main__.SMTPChannel 
connected 127.0.0.1:34160 at 0xb739a4cc (class 'UnicodeDecodeError':'utf8' 
codec can't decode bytes in position 13-14: invalid continuation byte 
[/mnt/data/catalin/hacking/cpython/default/Lib/asyncore.py|read|83] 
[/mnt/data/catalin/hacking/cpython/default/Lib/asyncore.py|handle_read_event|442]
 [/mnt/data/catalin/hacking/cpython/default/Lib/asynchat.py|handle_read|190] 
[/mnt/data/catalin/hacking/cpython/default/Lib/smtpd.py|collect_incoming_data|278])

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12378
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[Joe Shaw]

New submission from Joe Shaw js...@itasoftware.com:

Start a non-SSL server on port 2525:

$ python -m smtpd -n -c DebuggingServer localhost:2525

In another terminal, fire up a python interpreter and run the following code:

 import smtplib
 s = smtplib.SMTP_SSL(localhost, 2525)
[...]
ssl.SSLError: [Errno 1] _ssl.c:480: error:140770FC:SSL 
routines:SSL23_GET_SERVER_HELLO:unknown protocol

The underlying socket connection is still open, but you can't access it or 
close it:

$ lsof -P -p 76318 | grep 2525
Python  76318 joeshaw3u  IPv4 0x09a9fb18   0t0  TCP 
localhost:64328-localhost:2525 (ESTABLISHED)

This wreaks havoc if you're trying to write a unit test using the smtpd module 
and asyncore in a thread and try to clean up after yourself.

The code inside SMTP_SSL looks something like this (on 2.6.5 anyway):

def _get_socket(self, host, port, timeout):
if self.debuglevel  0: printstderr, 'connect:', (host, port)
new_socket = socket.create_connection((host, port), timeout)
new_socket = ssl.wrap_socket(new_socket, self.keyfile, 
self.certfile)
self.file = SSLFakeFile(new_socket)
return new_socket

Something like:

new_socket = socket.create_connection((host, port), timeout)
try:
new_socket = ssl.wrap_socket(new_socket, self.keyfile, 
self.certfile)
except:
new_socket.close()
raise
self.file = SSLFakeFile(new_socket)
return new_socket

I think will do the trick.

--
components: Library (Lib)
messages: 138753
nosy: joeshaw
priority: normal
severity: normal
status: open
title: smtplib.SMTP_SSL leaks socket connections on SSL error
type: resource usage
versions: Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12378
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[Joe Shaw]

Joe Shaw js...@itasoftware.com added the comment:

From some experimentation, closing the underlying socket isn't enough.  You 
also need to close the SSL socket, so you'd need to do something like:


new_socket = socket.create_connection((host, port), timeout)
ssl_socket = ssl.wrap_socket(new_socket, self.keyfile, self.certfile, 
do_handshake_on_connect=False)
try:
ssl_socket.do_handshake()
except:
ssl_socket.close()
new_socket.close()
raise
self.file = SSLFakeFile(ssl_socket)
return ssl_socket

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12378
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

[R. David Murray]

R. David Murray rdmur...@bitdance.com added the comment:

2.6 is in security-fix-only mode.

By inspection the 2.7 and 3.x code have the same issue (though the 3.x code is 
very different, there still appears to be a lack of error recovery logic.

Joe, do you have any interest in writing a unit test for this?  I believe the 
necessary infrastructure already exists in test_smtpnet, though I'm not sure.

--
nosy: +kasun, pitrou, r.david.murray
stage:  - needs patch
versions: +Python 2.7, Python 3.2, Python 3.3 -Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12378
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com