[issue12516] imghdr.what should take one argument

[Irit Katriel]

Change by Irit Katriel :


--
resolution: rejected -> wont fix

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12516] imghdr.what should take one argument

[Irit Katriel]

Irit Katriel  added the comment:

imghdr is deprecated as per PEP 594, so there won't be more enhancements to it.

--
nosy: +iritkatriel
resolution:  -> rejected
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12516] imghdr.what should take one argument

[Claudiu Popa]

Changes by Claudiu Popa pcmantic...@gmail.com:


--
nosy: +Claudiu.Popa
versions: +Python 3.5 -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12516
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12516] imghdr.what should take one argument

[Claudiu Popa]

Claudiu Popa added the comment:

imghdr got a test file in 94813eab5a58. Your patch also needs documentation 
updates. Besides that, +1 from me. Maybe it would be okay to add a deprecation 
warning for the second argument?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12516
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12516] imghdr.what should take one argument

[SilentGhost]

SilentGhost ghost@gmail.com added the comment:

This seems like a change suitable for 3.3

--
nosy: +SilentGhost
versions: +Python 3.3 -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12516
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12516] imghdr.what should take one argument

[Jeffrey Finkelstein]

New submission from Jeffrey Finkelstein jeffrey.finkelst...@gmail.com:

Currently imghdr.what() accepts two parameters. The first is a file or filename 
and the second is a byte stream. If the second is not None, the first is 
ignored. This is clunky. It would be simpler to accept just one argument, which 
can be either an open file or a byte stream.

I have attached a patch which implements this one argument approach as private 
function imghdr_what(). I have left imghdr.what() as a wrapper around this new 
function for backwards compatibility (in the hopes that it will eventually be 
replaced).

In addition, there did not seem to be any tests for the imghdr module, so I 
added a few simple tests.

--
components: Library (Lib)
files: imghdr.patch
keywords: patch
messages: 139993
nosy: jfinkels
priority: normal
severity: normal
status: open
title: imghdr.what should take one argument
type: feature request
versions: Python 3.4
Added file: http://bugs.python.org/file22608/imghdr.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12516
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com