[issue1309352] Make fcntl work properly on AMD64

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Committed in r72887, r72888, r72889. Thanks!

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1309352] Make fcntl work properly on AMD64

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Gonna apply if nobody opposes :)

--
assignee: nnorwitz -> pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1309352] Make fcntl work properly on AMD64

[R. David Murray]

R. David Murray  added the comment:

On Tue, 19 May 2009 at 16:24, Antoine Pitrou wrote:
> Thanks! For the record, did the rest of test_fcntl pass?
> Is it a 32-bit or a 64-bit build?

Yes and 32 bit.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1309352] Make fcntl work properly on AMD64

[Antoine Pitrou]

Antoine Pitrou  added the comment:

> @AP: ran patched test on Freebsd (6.2) as requested.

Thanks! For the record, did the rest of test_fcntl pass?
Is it a 32-bit or a 64-bit build?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1309352] Make fcntl work properly on AMD64

[R. David Murray]

R. David Murray  added the comment:

@AP: ran patched test on Freebsd (6.2) as requested.  Result is:

test_fcntl_64_bit (test.test_fcntl.TestFcntl) ... skipped 'F_NOTIFY or
DN_MULTISHOT unavailable'

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1309352] Make fcntl work properly on AMD64

[Antoine Pitrou]

Antoine Pitrou  added the comment:

As for the calling convention concern, it seems to me that a sane ABI
wouldn't make a difference between ints and longs - both should fit in a
standard machine word.

--
stage: test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1309352] Make fcntl work properly on AMD64

[Antoine Pitrou]

Antoine Pitrou  added the comment:

Here is an updated patch with a test.

--
Added file: http://bugs.python.org/file13988/fcntl.patch3.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1309352] Make fcntl work properly on AMD64

[Antoine Pitrou]

Antoine Pitrou  added the comment:

I confirm this on trunk, using Brad's test script.

--
nosy: +pitrou
versions: +Python 2.7, Python 3.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1309352] Make fcntl work properly on AMD64

[Daniel Diniz]

Changes by Daniel Diniz :


--
stage:  -> test needed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1309352] Make fcntl work properly on AMD64

[Christian Heimes]

Changes by Christian Heimes:


--
versions: +Python 2.6 -Python 2.5

_
Tracker <[EMAIL PROTECTED]>

_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com