[issue13254] maildir.items() broken
Petri Lehtinen pe...@digip.org added the comment: Even better would be to set skewfactor to something negative in this test, too. I was told that long sleeps in tests are frowned upon. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Florent Xicluna florent.xicl...@gmail.com added the comment:
test fails on x86 Windows7 2.7 buildbot
(ok on 3.2 and 3.3)
test_unix_mbox (test.test_mailbox.MaildirTestCase) ...
D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\sqlite3\test\dbapi.py:649:
DeprecationWarning: buffer() not supported in 3.x
b = sqlite.Binary(chr(0) + ')
D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\sqlite3\test\types.py:70:
DeprecationWarning: buffer() not supported in 3.x
val = buffer(Guglhupf)
D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\sqlite3\test\types.py:234:
DeprecationWarning: buffer() not supported in 3.x
val = buffer(Guglhupf)
D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\sqlite3\test\types.py:350:
DeprecationWarning: buffer() not supported in 3.x
result = self.con.execute('select ? as x [bin]',
(buffer(zlib.compress(testdata)),)).fetchone()[0]
D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\sqlite3\test\userfunctions.py:39:
DeprecationWarning: buffer() not supported in 3.x
return buffer(blob)
D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\sqlite3\test\userfunctions.py:200:
DeprecationWarning: buffer() not supported in 3.x
self.assertEqual(val, buffer(blob))
D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\sqlite3\test\userfunctions.py:237:
DeprecationWarning: buffer() not supported in 3.x
cur.execute(select isblob(?), (buffer(blob),))
D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\sqlite3\test\userfunctions.py:255:
DeprecationWarning: buffer() not supported in 3.x
(foo, 5, 3.14, None, buffer(blob),))
D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\sqlite3\test\userfunctions.py:347:
DeprecationWarning: buffer() not supported in 3.x
cur.execute(select checkType('blob', ?), (buffer(blob),))
test test_mailbox failed -- Traceback (most recent call last):
File
D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\test\test_mailbox.py,
line 803, in test_reread
self.assertFalse(refreshed())
AssertionError: True is not false
ok
==
FAIL: test_reread (test.test_mailbox.TestMaildir)
--
Traceback (most recent call last):
File
D:\cygwin\home\db3l\buildarea\2.7.bolen-windows7\build\lib\test\test_mailbox.py,
line 803, in test_reread
self.assertFalse(refreshed())
AssertionError: True is not false
--
Ran 280 tests in 5.250s
--
keywords: +buildbot -patch
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13254
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Florent Xicluna florent.xicl...@gmail.com added the comment: This is a transient failure, other builds are successful. Maybe the line time.sleep(2.01 + self._box._skewfactor) could be changed to time.sleep(2.5 + self._box._skewfactor) in test_mailbox.TestMaildir.test_reread. Closing because it's not related to this issue. -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Roundup Robot devn...@psf.upfronthosting.co.za added the comment: New changeset 5f27a9f67a34 by Petri Lehtinen in branch '3.2': Fix Maildir initialization so that maildir contents are read correctly. http://hg.python.org/cpython/rev/5f27a9f67a34 New changeset 91a0f6879173 by Petri Lehtinen in branch 'default': Fix Maildir initialization so that maildir contents are read correctly. http://hg.python.org/cpython/rev/91a0f6879173 New changeset 0b754ee12dbd by Petri Lehtinen in branch '2.7': Fix Maildir initialization so that maildir contents are read correctly. http://hg.python.org/cpython/rev/0b754ee12dbd -- nosy: +python-dev resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Petri Lehtinen pe...@digip.org added the comment: In the absence of any complaints, I went on and committed the fix. Thanks for reporting the issue! -- assignee: r.david.murray - ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Changes by Florent Xicluna florent.xicl...@gmail.com: Removed file: http://bugs.python.org/file23586/issue13254_v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Changes by Florent Xicluna florent.xicl...@gmail.com: -- keywords: -needs review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Petri Lehtinen pe...@digip.org added the comment: The last patch looks good to me and is a clever approach indeed :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Petri Lehtinen pe...@digip.org added the comment:
More specifically, this happens if the Maildir instance is created two seconds
before items() is called:
import time
from mailbox import Maildir
x = Maildir('test') # has messages
time.sleep(2.5)
x.items()
[]
This happens because __init__() doesn't populate _toc, and mtimes haven't
changed either, so _refresh() doesn't populate _toc either.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13254
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Petri Lehtinen pe...@digip.org added the comment: Attached a patch. It makes _refresh() re-read the _toc uncoditionally when called the first time. -- keywords: +needs review, patch stage: needs patch - patch review Added file: http://bugs.python.org/file23584/issue13254.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Florent Xicluna florent.xicl...@gmail.com added the comment: The patch by Petri looks good. I've uploaded a variant which set the initial mtimes to epoch instead of creating a _toc_read attribute. The tests are not changed. -- nosy: +flox Added file: http://bugs.python.org/file23585/issue13254_v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Florent Xicluna florent.xicl...@gmail.com added the comment: Re-uploaded, because we can set initialize _last_read to 0 instead of time.time(). It is more consistent. -- Added file: http://bugs.python.org/file23586/issue13254_v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Changes by Florent Xicluna florent.xicl...@gmail.com: Removed file: http://bugs.python.org/file23585/issue13254_v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Florent Xicluna florent.xicl...@gmail.com added the comment: Finally, the patch can be only 5 lines... -- Added file: http://bugs.python.org/file23587/issue13254_v3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
New submission from marco ghidinelli marc...@gmail.com:
since python 2.7.2
maildir.items() doesn't return anything:
from mailbox import Maildir
x = Maildir('test')
x.items()
[]
untils something was written on the maildir.
x.add('bubu')
'1319447613.M259111P6097Q1.deeppurple'
x.items()
[('1319447013.M913187P6096Q1.deeppurple', rfc822.Message instance at
0x7f25f5b612d8), ('1319447613.M259111P6097Q1.deeppurple', rfc822.Message
instance at 0x7f25f5b61680)]
--
components: Library (Lib)
messages: 146283
nosy: marco.ghidinelli
priority: normal
severity: normal
status: open
title: maildir.items() broken
type: behavior
versions: Python 2.7, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13254
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +r.david.murray versions: +Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
marco ghidinelli marc...@gmail.com added the comment: i verified now, and the 2.7.1 version is ok, the bug is present since the 2.7.2 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
Changes by Petri Lehtinen pe...@digip.org: -- nosy: +petri.lehtinen ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
marco ghidinelli marc...@gmail.com added the comment: 3.1 is ok 3.2.2 is affected -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
R. David Murray rdmur...@bitdance.com added the comment: I'm assigning this to myself so I don't lose it, but if someone wants to work on a patch please do. It'll be a bit before I can look at it. -- assignee: - r.david.murray priority: normal - high stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13254] maildir.items() broken
R. David Murray rdmur...@bitdance.com added the comment: Since this is a regression I'm upping the priority further to release blocker, so that we don't put out another release with the regression still in it. -- nosy: +benjamin.peterson, georg.brandl priority: high - release blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13254 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
