[issue13495] IDLE: Regressions - Two ColorDelegator instances loaded
Roundup Robot added the comment: New changeset fef7f212fe76 by Roger Serwy in branch '3.3': #13495: Avoid loading the color delegator twice in IDLE. http://hg.python.org/cpython/rev/fef7f212fe76 New changeset 588fcf36c975 by Roger Serwy in branch 'default': #13495: merge with 3.3. http://hg.python.org/cpython/rev/588fcf36c975 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13495 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13495] IDLE: Regressions - Two ColorDelegator instances loaded
Roger Serwy added the comment: I'm closing this issue as fixed. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13495 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13495] IDLE: Regressions - Two ColorDelegator instances loaded
Roger Serwy added the comment: I will split the good_load flag bug into its own issue. While addressing a bug in #5492, another doubled-up ColorDelegator problem appeared, tracing back to #1586. The dual_delagators patch removes the code which loads the extra color delegators as well as ensures that ResetColorizer loads a color delegator since ispythonsource() now always returns True in a PyShell instance. -- assignee: - roger.serwy title: IDLE: Regressions - Two ColorDelegator instances loaded and -e no longer edits new files. - IDLE: Regressions - Two ColorDelegator instances loaded versions: +Python 3.4 -Python 3.2 Added file: http://bugs.python.org/file29946/dual_delegators.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13495 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13495] IDLE: Regressions - Two ColorDelegator instances loaded and -e no longer edits new files.
Changes by Andrew Svetlov andrew.svet...@gmail.com: -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13495 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13495] IDLE: Regressions - Two ColorDelegator instances loaded and -e no longer edits new files.
Roger Serwy roger.se...@gmail.com added the comment: There was another regression introduced by (a4bd8a4805a8). IDLE 3 no longer allows for editing of new files from the command line. For example: idle -e /tmp/newfile.py will momentarily flash an editor window before it is closed. This is due to good_load not being set. What's worse is that the IDLE process will continue running without having any visible windows open. The rev2 patch removes the good_load flag and fixes the ColorDelegator issue. I understand the purpose of the original code is to avoid displaying a blank editor in case of a decode error. The rev2 patch reintroduces this behavior. In my opinion, that behavior is not a serious problem. -- nosy: +terry.reedy title: IDLE: Regression - Two ColorDelegator instances loaded - IDLE: Regressions - Two ColorDelegator instances loaded and -e no longer edits new files. Added file: http://bugs.python.org/file24243/issue13495_rev2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13495 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13495] IDLE: Regressions - Two ColorDelegator instances loaded and -e no longer edits new files.
Terry J. Reedy tjre...@udel.edu added the comment: If you are saying that it is better to open a blank window than to not open a filled window, I agree. -- stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13495 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
