[issue13593] importlib needs to be updated for __qualname__

2011-12-14 Thread Brett Cannon 

Brett Cannon br...@python.org added the comment:

Seems fine to me, and if Antoine says it's doing the right thing then I'm cool 
with the patch.

--
assignee:  - meador.inge

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13593
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13593] importlib needs to be updated for __qualname__

2011-12-14 Thread Roundup Robot 

Roundup Robot devn...@psf.upfronthosting.co.za added the comment:

New changeset 54a77c556d9a by Meador Inge in branch 'default':
Issue #13593: updating the importlib utility decorators for __qualname__.
http://hg.python.org/cpython/rev/54a77c556d9a

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13593
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13593] importlib needs to be updated for __qualname__

2011-12-14 Thread Meador Inge 

Meador Inge mead...@gmail.com added the comment:

Fix committed.  Thanks for the review Antoine and Brett.

--
resolution:  - fixed
stage: commit review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13593
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13593] importlib needs to be updated for __qualname__

2011-12-13 Thread Meador Inge 

New submission from Meador Inge mead...@gmail.com:

I was recently reading the 'importlib' code and noticed that the utility 
decorators have not been updated for '__qualname__':

 def f(): pass
... 
 importlib.util.set_loader(f)
function set_loader.locals.wrapper at 0x7f4b323f1f60
 importlib.util.set_loader(f).__name__
'f'
 importlib.util.set_loader(f).__qualname__
'set_loader.locals.wrapper'

The attached patch fixes this.  OK to commit?

--
components: Library (Lib)
files: importlib-qualname.patch
keywords: easy, patch
messages: 149389
nosy: brett.cannon, meador.inge
priority: normal
severity: normal
stage: patch review
status: open
title: importlib needs to be updated for __qualname__
type: behavior
versions: Python 3.3
Added file: http://bugs.python.org/file23942/importlib-qualname.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13593
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13593] importlib needs to be updated for __qualname__

2011-12-13 Thread Ezio Melotti 

Changes by Ezio Melotti ezio.melo...@gmail.com:


--
nosy: +pitrou
stage: patch review - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13593
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13593] importlib needs to be updated for __qualname__

2011-12-13 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Looks ok to me.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13593
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com