[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Stefan Behnel  added the comment:

> Maybe complete Doc/license.rst?

Thanks, done.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Change by Stefan Behnel :


--
pull_requests: +12972

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[STINNER Victor]

STINNER Victor  added the comment:

> Is there anything else I have to take care of when adding externally 
> provided/licensed files to the source tree?

Maybe complete Doc/license.rst?
https://docs.python.org/dev/license.html

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Stefan Behnel  added the comment:

A buildbot failure made me notice that the test files were not part of the 
CPython installation yet, so I added them. I also took the opportunity to add a 
README file that describes where they come from and under which conditions they 
were originally provided by the W3C (IANAL, but basically free use with 
copyright notice).

https://www.w3.org/Consortium/Legal/2015/doc-license

Is there anything else I have to take care of when adding externally 
provided/licensed files to the source tree?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Stefan Behnel  added the comment:


New changeset 0d5864fa07ab4f03188c690a5eb07bdd1fd1cb9c by Stefan Behnel in 
branch 'master':
bpo-13611: Include C14N 2.0 test data in installation (GH-13053)
https://github.com/python/cpython/commit/0d5864fa07ab4f03188c690a5eb07bdd1fd1cb9c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Change by Stefan Behnel :


--
pull_requests: +12971

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Change by Stefan Behnel :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Stefan Behnel  added the comment:


New changeset e1d5dd645d5f59867cb0ad63179110f310cbca89 by Stefan Behnel in 
branch 'master':
bpo-13611: C14N 2.0 implementation for ElementTree (GH-12966)
https://github.com/python/cpython/commit/e1d5dd645d5f59867cb0ad63179110f310cbca89


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Stefan Behnel  added the comment:

Thanks for testing, Zackery. I resolved the reference leaks. They were already 
in the PR for issue 36676. Both PRs updated.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Zackery Spytz]

Zackery Spytz  added the comment:

The PR has reference leaks.

--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Stefan Behnel  added the comment:

> I personally think it's ready to go into the last alpha release

Since I didn't get any negative comments or requests for deferral, I'll merge 
this today to get the feature into the last (still unreleased) alpha. We still 
have the beta phase to resolve issues with it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Stefan Behnel  added the comment:

Playing around with it a bit more, I ended up changing the interface of the 
canonicalize() function to return its output as a string by default. It's 
really nice to be able to say

c14n_xml = canonicalize(plain_xml)

To write to a file, you now do this:

  with open("c14n_output.xml", mode='w', encoding='utf-8') as out_file:
  canonicalize(xml_data, out=out_file)

and to read from a file:

  canonicalize(from_file=fileobj)

I think that nicely handles all use cases.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Stefan Behnel  added the comment:

It took me a couple of minutes longer to submit it, but it's there now. :)

I'm aware that there is a lot of new code involved, covering really three new 
features, which makes reviewing it a non-trivial task. I personally think it's 
ready to go into the last alpha release on Monday to receive some initial 
visibility, but I would like to have at least a little feedback before that. 
Even just a general opinion whether you support pushing this into 3.8 or not. 
Postponing it to the first beta would be ok, if you need more time to form an 
opinion, but having it in an alpha would improve the chance of getting user 
feedback.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[STINNER Victor]

STINNER Victor  added the comment:

> Comments and reviews welcome.

Review of what? There is no PR attached to this issue.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Change by Stefan Behnel :


--
keywords: +patch
pull_requests: +12893
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

Stefan Behnel  added the comment:

Turns out, it was not that easy. :-/

ElementTree lacks prefixes in its tree model, so they would have to be either 
registered globally (via register_namespace()) or come from the parser. I tried 
the latter since that is the most generic way when the input is serialised 
already. See issue 36673 and issue 36676 for extensions to the parser target 
interface that this implementation relies on. Note that this is a new 
implementation, only marginally based off the original ElementC14N 
implementation.

I only implemented C14N 2.0 (which lxml also does not have, but I'll add it 
there). I got most of the official test cases working, including prefix 
rewriting and prefix resolution in tag and attribute content.

https://www.w3.org/TR/xml-c14n2-testcases/

What's not supported?

The original namespace prefixes may not be preserved when namespaces are 
declared with multiple prefixes. In that case, one of them is picked. That's 
difficult to implement in ET because the parser resolves and discards prefixes. 
I think that's acceptable, as long as the prefix selection is deterministic.

Also, qname rewriting in XPath expressions that appear in XML text is not 
currently supported. I guess that's a bit of an esoteric feature which can 
still be added later if it's needed.

While testing, I noticed that ET and cET behave differently when it comes to 
resolving default attributes from an internal DTD subset. The parser in cET 
does it, ET does not. That should probably get aligned. For now, the tests hack 
around that difference.

Comments and reviews welcome.

--
assignee: serhiy.storchaka -> scoder

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

References:

Canonical XML Version 2.0 -- https://www.w3.org/TR/xml-c14n2/
Test cases for Canonical XML 2.0 -- https://www.w3.org/TR/xml-c14n2-testcases/

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

"c14n" is documented as an accepted serialization method of write() and there 
is some (non-working) code for support of C14N. 
e6a951b83e30b3b9c809a441041fb0f21f72b168 removed optional import of ElementC14N.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +serhiy.storchaka
stage:  -> needs patch
versions: +Python 3.8 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Chris E]

Chris E added the comment:

Whilst in most cases this would be correct, in this case it looks like the 
original contributor took a subset of what the original author wrote and put it 
into the python libraries.

Until relatively recently the ElementTree.py file included a stanza that 
attempted to import the ElementC14N module and conditionally set up the 'c14n' 
key value in _serialize

--
nosy: +cbz

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13611
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Antoine Pitrou]

Changes by Antoine Pitrou pit...@free.fr:


--
nosy: +eli.bendersky

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13611
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Christian Heimes]

Changes by Christian Heimes li...@cheimes.de:


--
nosy: +christian.heimes, effbot
versions: +Python 3.4 -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13611
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Stefan Behnel]

New submission from Stefan Behnel sco...@users.sourceforge.net:

The ElementC14N.py module by Fredrik Lundh implements XML canonicalisation for 
the ElementTree serialiser. Given that the required API hooks to use it are 
already in xml.etree.ElementTree, this would make a nice, simple and straight 
forward addition to the existing xml.etree package.

The source can be found here (unchanged since at least 2009):

https://bitbucket.org/effbot/et-2009-provolone/src/tip/elementtree/elementtree/ElementC14N.py

Note that the source needs some minor modifications to use relative imports at 
the top. Also, the 2.3 compatibility code section can be dropped.

--
components: Library (Lib), XML
messages: 149598
nosy: scoder
priority: normal
severity: normal
status: open
title: Integrate ElementC14N module into xml.etree package
type: enhancement
versions: Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13611
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Antoine Pitrou]

Changes by Antoine Pitrou pit...@free.fr:


--
nosy: +flox

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13611
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13611] Integrate ElementC14N module into xml.etree package

[Martin v . Löwis]

Martin v. Löwis mar...@v.loewis.de added the comment:

Code added to the standard library should be contributed by its author, with an 
explicit statement of plans to support it in an ongoing manner, and preferably 
also with plans to stop providing standalone releases over time.

--
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13611
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com