[issue13756] Python3.2.2 make fail on cygwin

[Donald Stufft]

Changes by Donald Stufft :


--
pull_requests: +919

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Zachary Ware]

Zachary Ware added the comment:

No problem.  Feel free to nosy me on any Cygwin issues that you feel have 
consensus on the solution and a commit-ready patch implementing it.  I can't 
guarantee when I'll have time to look at them, but I have finally gotten around 
to installing Cygwin and will get to them eventually :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Erik Bray]

Erik Bray added the comment:

Okay, that would explain it then.  I was building from an older branch 
(pre-3.7) that still has the bundled libffi.

FWIW with the fix from #2445, --with-system-ffi works (as does some trivial use 
of _ctypes though I haven't run all the tests).  So if the bundled libffi is 
gone then I guess that's a moot point.

Thanks for getting a bunch of these fixes merged.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Zachary Ware]

Zachary Ware added the comment:

Hmm, Cygwin64 is what I built on (successfully).  _ctypes does not build, but 
that's due to not having any libffi available at all: the bundled copy is no 
longer included in 3.7, and I didn't install a system copy.  I view ctypes 
support as a fairly low-priority item; we have much bigger issues to worry 
about first :).  If trying to build _ctypes actually crashes your build, I 
think '--without-system-ffi' might be enough to get it to error out cleanly.

--
versions: +Python 3.7 -Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Erik Bray]

Erik Bray added the comment:

FWIW, even with this patch and --without-threads Python does *not* build 
successfully on Cygwin64 (which is all I'm really interested in personally), 
though it does succeed on 32-bit Cygwin.  This has two related reasons:

1) The build of Python's bundled libffi does not work on 64-bit Cygwin for at 
least a few reasons that I won't go into here.  There doesn't seem to be a 
ticket yet for that so I'll open one.

2) Using --with-system-ffi doesn't work for reasons I talked about in #2445, 
and also discussed a bit in #1706863

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Zachary Ware]

Zachary Ware added the comment:

Fixed on 3.7, we can evaluate backporting later.  With this committed, a build 
on Cygwin can succeed if you configure with --without-threads.

Thanks for the patch!

--
nosy: +zach.ware
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Roundup Robot]

Roundup Robot added the comment:

New changeset 5b4c21436036 by Zachary Ware in branch 'default':
Issue #13756: Fix building extensions modules on Cygwin
https://hg.python.org/cpython/rev/5b4c21436036

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Erik Bray]

Erik Bray added the comment:

I can confirm that the last attached patch on this issue fixes this particular 
issue with building on Cygwin.  There are other issues but this is definitely 
one of them.

--
nosy: +erik.bray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Masayuki Yamamoto]

Changes by Masayuki Yamamoto light2happy@gmail.com:


--
nosy: +masamoto

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Éric Araujo]

Éric Araujo added the comment:

I have no objection to the patch.  I can’t test it on cygwin (unless snakebite 
provides it, I’ll ask) but I can check that a linux build still works.

--
keywords: +needs review
stage:  - patch review
versions: +Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Roumen Petrov]

Roumen Petrov added the comment:

Jason Tishler wrote:
 Jason Tishler added the comment:

 Is this still an issue on 3.3/3.4?
 I presume so.
This build is broken since SOABI implementation.

 Does the patch still work?
 I haven't tried it on 3.3 yet, so I don't know if it will apply cleanly.
Attached 0001-CYGWIN-issue13756-Python-make-fail-on-cygwin.patch for head.
This patch is part of split issue3871 into small independent changes.

Roumen

--
Added file: 
http://bugs.python.org/file28934/0001-CYGWIN-issue13756-Python-make-fail-on-cygwin.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___From 23031e941eaab013ef65ed7b2cdb08742a72e68d Mon Sep 17 00:00:00 2001
From: Roumen Petrov lo...@example.net
Date: Sat, 2 Feb 2013 00:04:12 +0200
Subject: [PATCH 1/5] CYGWIN-issue13756: Python make fail on cygwin

---
 Lib/distutils/command/build_ext.py | 7 ---
 Makefile.pre.in| 4 ++--
 Modules/makesetup  | 2 +-
 3 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/Lib/distutils/command/build_ext.py 
b/Lib/distutils/command/build_ext.py
index f7c71b3..eac04a5 100644
--- a/Lib/distutils/command/build_ext.py
+++ b/Lib/distutils/command/build_ext.py
@@ -705,13 +705,6 @@ class build_ext(Command):
 return ext.libraries + [pythonlib]
 else:
 return ext.libraries
-elif sys.platform[:6] == cygwin:
-template = python%d.%d
-pythonlib = (template %
-   (sys.hexversion  24, (sys.hexversion  16)  0xff))
-# don't extend ext.libraries, it may be shared with other
-# extensions, it is a reference to the original list
-return ext.libraries + [pythonlib]
 elif sys.platform[:6] == atheos:
 from distutils import sysconfig
 
diff --git a/Makefile.pre.in b/Makefile.pre.in
index 9570730..5190f4f 100644
--- a/Makefile.pre.in
+++ b/Makefile.pre.in
@@ -556,9 +556,9 @@ 
$(PYTHONFRAMEWORKDIR)/Versions/$(VERSION)/$(PYTHONFRAMEWORK): \
$(LN) -fsn Versions/Current/$(PYTHONFRAMEWORK) 
$(PYTHONFRAMEWORKDIR)/$(PYTHONFRAMEWORK)
$(LN) -fsn Versions/Current/Resources $(PYTHONFRAMEWORKDIR)/Resources
 
-# This rule builds the Cygwin Python DLL and import library if configured
+# This rule builds the Python DLL and import library if configured
 # for a shared core library; otherwise, this rule is a noop.
-$(DLLLIBRARY) libpython$(VERSION).dll.a: $(LIBRARY_OBJS)
+$(DLLLIBRARY) libpython$(LDVERSION).dll.a: $(LIBRARY_OBJS)
if test -n $(DLLLIBRARY); then \
$(LDSHARED) -Wl,--out-implib=$@ -o $(DLLLIBRARY) $^ \
$(LIBS) $(MODLIBS) $(SYSLIBS) $(LDLAST); \
diff --git a/Modules/makesetup b/Modules/makesetup
index 40dfa9d..1a1fcf6 100755
--- a/Modules/makesetup
+++ b/Modules/makesetup
@@ -91,7 +91,7 @@ CYGWIN*) if test $libdir = .
 else
ExtraLibDir='$(LIBPL)'
 fi
-ExtraLibs=-L$ExtraLibDir -lpython\$(VERSION);;
+ExtraLibs=-L$ExtraLibDir -lpython\$(LDVERSION);;
 esac
 
 # Main loop
-- 
1.7.12.1

___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Ezio Melotti]

Ezio Melotti added the comment:

Is this still an issue on 3.3/3.4?  Does the patch still work?

--
nosy: +ezio.melotti

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Jason Tishler]

Jason Tishler ja...@tishler.net added the comment:

I offer the attached patch for consideration. AFAICT, only the Makefile.pre.in 
and build_ext.py changes are required. I included the makesetup change for 
completeness and to be consistent with the other changes.

--
keywords: +patch
nosy: +jlt63, yselkowitz
Added file: http://bugs.python.org/file25936/3.2.3-libpython-abi.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Roumen Petrov]

Roumen Petrov bugtr...@roumenpetrov.info added the comment:

Hi Jason,
if you look in default rule you will see the same, so this relict specific 
else case could be removed. Also in Lib/packaging/command/build_ext.py.

--
nosy: +rpetrov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Lohoris]

Changes by Lohoris loo...@gmail.com:


--
nosy: +Lohoris
type:  - compile error

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

Martin, any input?

Uncompressed patch attached.  Plain text files are easier to review and devoid 
of security issues (unlike executables on Windows, PDFs if you’re using Adobe 
Reader, etc.).

--
Added file: http://bugs.python.org/file24657/patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Martin v . Löwis]

Martin v. Löwis mar...@v.loewis.de added the comment:

The removal of testing for ncurses.h is incorrect: this should break the Linux 
build, where ncurses.h is indeed commonly located in /usr/include.

Not sure how to proceed here: if somebody would try to reproduce the problem, 
they would likely come up with a patch which is fairly different from the one 
you are proposing. 

So, Luis: are you interested in working out a complete and correct patch? If 
so, please start with generating one that is against the hg 3.2 branch (or 
perhaps even against the default branch). It's ok if you are not interested, in 
that case we'll need to wait for some other volunteer.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Luis Marsano]

Luis Marsano luis.mars...@gmail.com added the comment:

Got it to build. Unpack the Python (3.2.2) source package and apply this patch 
to get a package that builds on Cygwin (1.7.9), eg:
xz -d patch.xz  tar -xJf Python-3.2.2.tar.xz  patch -p0 -i patch

Changes:
(1) The Makefile, makesetup, and distutils.UnixCCompiler and 
distutils.command.build_ext modules set values for locating cygwin's python 
library that didn't agree or make sense during buildtime, so I revised them to 
agree and use build options that work.
(2) configuration and setup.py couldn't locate cygwin's ncurses headers, so I 
revised them to do that. I don't think I made that change as portable friendly 
as possible, so someone please check that and find a better way.

Your input is welcome.

--
Added file: http://bugs.python.org/file24395/patch.xz

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Luis Marsano]

Luis Marsano luis.mars...@gmail.com added the comment:

The README file implies support:
[⋮]
Build Instructions
--

On Unix, Linux, BSD, OSX, and Cygwin:
[⋮]

--
components: +Build -Installation
nosy: +Luis.Marsano

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

I am not sure building CPython with Cygwin is supported.

--
nosy: +eric.araujo, loewis, mhammond

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13756] Python3.2.2 make fail on cygwin

[Holger]

New submission from Holger hol...@bille.dk:

Downloaded Python-3.2.2.tar
cd Python-3.2.2
./configure
make

Fail on:

.
ranlib libpython3.2m.a
make: *** No rule to make target `libpython3.2m.dll.a', needed by `python.exe'. 
 Stop.


libpython3.2m.a was built successfully:

$ ls -l libpython3.2m.a
-rw-r--r--+ 1 hbille Domain Users 7182050 Jan 10 13:31 libpython3.2m.a


I am not sure which part is incorrect. The name with or without dll

--
components: Installation
messages: 151014
nosy: holgerd00d
priority: normal
severity: normal
status: open
title: Python3.2.2 make fail on cygwin
versions: Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13756
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com