[issue13872] socket.detach doesn't mark socket._closed

2012-03-31 Thread Roundup Robot 

Roundup Robot devn...@psf.upfronthosting.co.za added the comment:

New changeset 3a220feafa15 by Antoine Pitrou in branch '3.2':
Issue #13872: socket.detach() now marks the socket closed (as mirrored in the 
socket repr()).
http://hg.python.org/cpython/rev/3a220feafa15

New changeset d2f0c3eb1eed by Antoine Pitrou in branch 'default':
Issue #13872: socket.detach() now marks the socket closed (as mirrored in the 
socket repr()).
http://hg.python.org/cpython/rev/d2f0c3eb1eed

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13872
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13872] socket.detach doesn't mark socket._closed

2012-03-31 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Thank you Matt. I've now committed the patch in relevant versions.

--
resolution:  - fixed
stage:  - committed/rejected
status: open - closed
versions:  -Python 2.6, Python 2.7, Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13872
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13872] socket.detach doesn't mark socket._closed

2012-03-15 Thread Matt Joiner 

Matt Joiner anacro...@gmail.com added the comment:

Yes it should.

A cursory glance shows that __repr__ returns incorrect if _closed is not 
marked, and an unnecessary mop-up call to socket.close is avoided.

--
nosy: +giampaolo.rodola, haypo, stutzbach

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13872
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13872] socket.detach doesn't mark socket._closed

2012-02-01 Thread Jesús Cea Avión 

Changes by Jesús Cea Avión j...@jcea.es:


--
nosy: +jcea

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13872
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13872] socket.detach doesn't mark socket._closed

2012-01-29 Thread Charles-François Natali 

Changes by Charles-François Natali neolo...@free.fr:


--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13872
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13872] socket.detach doesn't mark socket._closed

2012-01-29 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

 socket.socket.detach doesn't mark the socket._closed flag.

Well, does it have to? It's only an internal detail, it's not exposed as a 
public API.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13872
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13872] socket.detach doesn't mark socket._closed

2012-01-26 Thread Matt Joiner 

New submission from Matt Joiner anacro...@gmail.com:

socket.socket.detach doesn't mark the socket._closed flag. The flag is specific 
to the Python wrapper, so the fix is put there. Test included.

--
components: Library (Lib)
files: socket-detach-mark-closed.patch
keywords: patch
messages: 152005
nosy: anacrolix
priority: normal
severity: normal
status: open
title: socket.detach doesn't mark socket._closed
type: behavior
versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3
Added file: http://bugs.python.org/file24327/socket-detach-mark-closed.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13872
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com