[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you Martin for your review.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

[Roundup Robot]

Roundup Robot added the comment:

New changeset 929c2d076a85 by Serhiy Storchaka in branch '3.5':
Issue #14061: Misc fixes and cleanups in archiving code in shutil.
https://hg.python.org/cpython/rev/929c2d076a85

New changeset 268d3763bb07 by Serhiy Storchaka in branch '3.6':
Issue #14061: Misc fixes and cleanups in archiving code in shutil.
https://hg.python.org/cpython/rev/268d3763bb07

New changeset 5fd772a20f25 by Serhiy Storchaka in branch 'default':
Issue #14061: Misc fixes and cleanups in archiving code in shutil.
https://hg.python.org/cpython/rev/5fd772a20f25

New changeset eb02db65e148 by Serhiy Storchaka in branch '2.7':
Issue #14061: Misc fixes and cleanups in archiving code in shutil.
https://hg.python.org/cpython/rev/eb02db65e148

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


Added file: http://bugs.python.org/file45466/shutil_make_archive_misc_3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
versions:  -Python 3.4
Added file: http://bugs.python.org/file43517/shutil_make_archive_misc_2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Yes, I were going to left this for other issue, but now I agree that it is 
better to left zip in unarhiving registry unconditionally.

In 2.7 the support of bztar is not conditional.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

[Martin Panter]

Martin Panter added the comment:

Remember that you probably should not mention “xztar” in the 3.4 or 2.7 docs 
(even though “lzma” exists in 3.4).

I am not too familiar with using shutil or zipfile, but it seems like 
extraction of some zip files is always possible, even if zlib (for Deflate) 
isn’t available (e.g. for zip files that are not compressed, or use bzip2 or 
LZMA). Maybe you should only make zip file _creation_ conditional.

--
nosy: +martin.panter

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Most of issues are already fixed. Proposed patch fixes remnants:

* You see a skip message when bz2 or lzma are not available, instead of silent 
non-testing.

* Removed a code that handles zipfile import failure. Importing zipfile now is 
always successful.

* The gztar and zip formats now are registered and supported only when zlib is 
available. This is documented now.

* Broken circular dependency between shutil and tarfile.

* Removed outdated sentences about the InfoZIP "zip" utility.

--
keywords: +patch
stage:  -> patch review
versions: +Python 3.6
Added file: http://bugs.python.org/file41023/shutil_make_archive_misc.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
nosy: +serhiy.storchaka
type:  - behavior
versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14061
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14061] Misc fixes and cleanups in archiving code in shutil and test_shutil

[Éric Araujo]

Éric Araujo mer...@netwok.org added the comment:

test_shutil contains partial tests for the archiving functionality.  I plan to 
rewrite some tests so that for example you can see a skip message when bz2 is 
not available, instead of silent non-testing.  Also, the internal functions 
_make_tarfile and _make_zipfile are directly tested, but IMO it’d be better to 
only exercise make_archive.

--
title: Clean up archiving code in shutil - Misc fixes and cleanups in 
archiving code in shutil and test_shutil

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14061
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com