[issue14600] Change ImportError reference handling, naming

2012-07-13 Thread Éric Araujo 

Éric Araujo mer...@netwok.org added the comment:

Yep, bf23a6c215f6 fixed it, thanks for the ping.  Brian or Antoine, can you 
close this or was there something else?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14600
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14600] Change ImportError reference handling, naming

2012-07-13 Thread Brian Curtin 

Changes by Brian Curtin br...@python.org:


--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14600
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14600] Change ImportError reference handling, naming

2012-07-12 Thread Eli Bendersky 

Eli Bendersky eli...@gmail.com added the comment:

Eric: your note appears to be fixed in the code.
Can this issue be closed?

--
nosy: +eli.bendersky

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14600
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14600] Change ImportError reference handling, naming

2012-04-18 Thread Éric Araujo 

Éric Araujo mer...@netwok.org added the comment:

As was pointed on python-dev for the first commit:

args = PyTuple_New(1);
if (args == NULL)
return NULL;

kwargs = PyDict_New();
if (args == NULL)
return NULL;

It looks like the second block has a copy-paste typo and should check kwargs, 
not args.

--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14600
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14600] Change ImportError reference handling, naming

2012-04-17 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

You probably want to check args and kwargs for NULL-ness too. Otherwise, looks 
good.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14600
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14600] Change ImportError reference handling, naming

2012-04-17 Thread Roundup Robot 

Roundup Robot devn...@psf.upfronthosting.co.za added the comment:

New changeset 7a32b9380ffd by Brian Curtin in branch 'default':
Fix #14600. Correct reference handling and naming of ImportError convenience 
function
http://hg.python.org/cpython/rev/7a32b9380ffd

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14600
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14600] Change ImportError reference handling, naming

2012-04-16 Thread Brian Curtin 

New submission from Brian Curtin br...@python.org:

Antoine mentioned in email that the reference handling should be changed, so 
here's a shot at it. I also condensed and renamed the convenience functions - I 
was paying too much attention to the surrounding conventions and made this 
harder than it had to be.

--
assignee: brian.curtin
files: ImportError_changes.diff
keywords: patch
messages: 158499
nosy: brian.curtin, pitrou
priority: high
severity: normal
stage: patch review
status: open
title: Change ImportError reference handling, naming
type: behavior
versions: Python 3.3
Added file: http://bugs.python.org/file25245/ImportError_changes.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14600
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14600] Change ImportError reference handling, naming

2012-04-16 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Looks good on the principle. Implementation is a bit weird: you don't need to 
check name and path for NULL-ness?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14600
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14600] Change ImportError reference handling, naming

2012-04-16 Thread Antoine Pitrou 

Antoine Pitrou pit...@free.fr added the comment:

Oh, and is PyErr_SetExcWithArgsKwargs still useful?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14600
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14600] Change ImportError reference handling, naming

2012-04-16 Thread Brian Curtin 

Brian Curtin br...@python.org added the comment:

How about this patch? Adds NULL checking and merges PyErr_SetExcWithArgsKwargs 
inside PyErr_SetImportError since it's not needed by itself. Docs are also 
updated in line with these changes.

--
Added file: http://bugs.python.org/file25248/issue14600.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14600
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com