[issue14848] Use shutil.move instead of os.rename in packaging

[Éric Araujo]

Changes by Éric Araujo :


--
resolution:  -> out of date
stage: needs patch -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14848] Use shutil.move instead of os.rename in packaging

[Vetoshkin Nikita]

Vetoshkin Nikita  added the comment:

glad to help

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14848] Use shutil.move instead of os.rename in packaging

[Éric Araujo]

Éric Araujo  added the comment:

Thanks!  As your message shows the problem is in the install module, I propose 
to close this bug as a duplicate of Alexis’ bug about improving d2.install.  
The new FileMover class should use shutil.move, and we’ll make sure to test 
install+remove as you did to see if the bug is gone.

--
assignee: eric.araujo -> alexis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14848] Use shutil.move instead of os.rename in packaging

[Vetoshkin Nikita]

Vetoshkin Nikita  added the comment:

Sorry, no traceback by default, had to augment with "raise" :) Now output looks 
like this:

nekto0n@ya-darkstar /var/tmp/mypackage $ pysetup remove pygraphviz
u'workflow': u'1.01' is not a valid version (field 'Version')
u'zc-zookeeper-static': u'3.4.3-3' is not a valid version (field 'Version')
u'virtkey': u'0.01' is not a valid version (field 'Version')
u'SSSDConfig': u'1' is not a valid version (field 'Version')
[Errno 18] Invalid cross-device link
Traceback (most recent call last):
  File "/home/nekto0n/.local/lib/python2.7/site-packages/distutils2/run.py", 
line 651, in main
return dispatcher()
  File "/home/nekto0n/.local/lib/python2.7/site-packages/distutils2/run.py", 
line 639, in __call__
return func(self, self.args)
  File "/home/nekto0n/.local/lib/python2.7/site-packages/distutils2/run.py", 
line 91, in wrapper
return f(*args, **kwargs)
  File "/home/nekto0n/.local/lib/python2.7/site-packages/distutils2/run.py", 
line 239, in _remove
remove(dist, auto_confirm=auto_confirm)
  File 
"/home/nekto0n/.local/lib/python2.7/site-packages/distutils2/install.py", line 
413, in remove
error = _move_file(file_, tmpfile)
  File 
"/home/nekto0n/.local/lib/python2.7/site-packages/distutils2/install.py", line 
399, in _move_file
os.rename(source, target)
OSError: [Errno 18] Invalid cross-device link

According to strace arguments to rename where:
rename("/home/nekto0n/.local/lib/python2.7/site-packages/pygraphviz-1.1-py2.7.egg-info/PKG-INFO",
 "/tmp/pygraphviz-uninstallIiAQ1I/PKG-INFO") = -1 EXDEV (Invalid cross-device 
link)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14848] Use shutil.move instead of os.rename in packaging

[Éric Araujo]

Éric Araujo  added the comment:

OK.  Can you paste the full traceback for the error?

--
stage:  -> needs patch
title: os.rename should not be used -> Use shutil.move instead of os.rename in 
packaging

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com