[issue14964] distutils2.utils.resolve_name cleanup

[Éric Araujo]

Changes by Éric Araujo :


--
resolution:  -> out of date
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14964] distutils2.utils.resolve_name cleanup

[Éric Araujo]

Changes by Éric Araujo :


Added file: http://bugs.python.org/file25773/resolve_name.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14964] distutils2.utils.resolve_name cleanup

[Éric Araujo]

Changes by Éric Araujo :


Removed file: http://bugs.python.org/file25773/resolve_name.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14964] distutils2.utils.resolve_name cleanup

[Éric Araujo]

Éric Araujo  added the comment:

Closing as duplicate.  I have new tests for resolve_name (need to port them 
from p7g to d2 and upload a patch); if your patch makes them pass or if it can 
be merged with another patch that fixes the function, it’s easier to have all 
on one issue; if your patch makes the code more readable without fixing it then 
I think another patch will go in.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14964] distutils2.utils.resolve_name cleanup

[Ronny Pfannschmidt]

Ronny Pfannschmidt  added the comment:

i missused hg export, here is a corrected patch

--
Added file: http://bugs.python.org/file25773/resolve_name.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14964] distutils2.utils.resolve_name cleanup

[Ronny Pfannschmidt]

Ronny Pfannschmidt  added the comment:

updated the patch with more detailed errors

--
Added file: http://bugs.python.org/file25771/resolve_name.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14964] distutils2.utils.resolve_name cleanup

[Ronny Pfannschmidt]

Ronny Pfannschmidt  added the comment:

my change is a unrelated cleanup
but the ideas in the patch look good

the attribute error addition seems relevant

i'll adapt my patch to raise the original import error for toplevel import 
failure and accumuplate the attrbute name so it can raise the correct error

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14964] distutils2.utils.resolve_name cleanup

[Éric Araujo]

Éric Araujo  added the comment:

Thanks!  I would love to get your review on #12703 (not sure if this bug is a 
duplicate or an unrelated cleanup).

--
stage:  -> patch review
versions: +3rd party, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14964] distutils2.utils.resolve_name cleanup

[Ronny Pfannschmidt]

New submission from Ronny Pfannschmidt :

this patch simplifies and cleans up the resolve_name function

--
assignee: eric.araujo
components: Distutils2
files: resolve_name.patch
keywords: patch
messages: 161974
nosy: Ronny.Pfannschmidt, alexis, eric.araujo, tarek
priority: normal
severity: normal
status: open
title: distutils2.utils.resolve_name cleanup
type: enhancement
Added file: http://bugs.python.org/file25766/resolve_name.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com