[issue14977] mailcap does not respect precedence in the presence of wildcards

[R. David Murray]

R. David Murray added the comment:

Thanks, Michael.  I didn't see anything that needed updating in the docs.

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Roundup Robot]

Roundup Robot added the comment:

New changeset f1bf0abcca0c by R David Murray in branch '3.5':
#14977: Make mailcap respect the order of the lines in the mailcap file.
https://hg.python.org/cpython/rev/f1bf0abcca0c

New changeset efd692c86429 by R David Murray in branch 'default':
Merge: #14977: Make mailcap respect the order of the lines in the mailcap file.
https://hg.python.org/cpython/rev/efd692c86429

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Fabio Alessandro Locati]

Fabio Alessandro Locati added the comment:

Any news on this?

--
nosy: +Fabio Alessandro Locati

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[R. David Murray]

R. David Murray added the comment:

I think a doc update is probably worthwhile, but I haven't looked at the docs 
so I'm not sure.

I'll try to give this a complete review this weekend, though I'm a bit busy so 
it may not happen.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Michael Lazar]

Michael Lazar added the comment:

Got it, I found some examples and it didn't look too complicated so I took a 
shot at it. Is there anything else that needs to be added? Does the 
documentation need to be updated at all?

btw, thanks for the rapid iteration. I appreciate you taking the time to help 
guide me though this :)

--
Added file: http://bugs.python.org/file43710/mailcap_v4.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[R. David Murray]

R. David Murray added the comment:

There's actually programmatic way to generate a deprecation warning when the 
function is called (and then we'd want a test to make sure it gets generated).  
if you don't feel like working through that hopefully someone else will pick it 
up.  If you want to work on it, you can find examples by grepping for 
DeprecationWarning.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Michael Lazar]

Changes by Michael Lazar :


Added file: http://bugs.python.org/file43706/mailcap_v3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Michael Lazar]

Michael Lazar added the comment:

Whoops

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[R. David Murray]

R. David Murray added the comment:

Looks like you didn't attach the new patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Michael Lazar]

Michael Lazar added the comment:

That works for me, patch updated to match your suggestion. So to recap, the 
proposed fix implements the following changes to the api:

getcaps()
   The returned dict now has an additional `lineno` field. There's a *slim* 
chance that this could break behavior for somebody who relies on the output for 
something other than passing it to findmatch().

readmailcapfiles()
Marked as deprecated, but the behavior will remain the same.

lookup(caps, ...)
If the caps dict contains `lineno`, the metadata will be used to sort the 
matching entries. If the caps dict does not contain `lineno`, for example if it 
was constructed manually, the behavior will remain the same.

findmatch(caps, ...)
Same as lookup()

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[R. David Murray]

R. David Murray added the comment:

How about this: rename the existing readmailcapfile as an internal 
_readmailcapfile with the new signature.  Then add a backward compatible 
readmailcapfile with the existing signature/return value that uses a dummy 
value for lineno and throws away the lineno on output.  The point here is just 
to avoid breaking programs that are using the existing api, even though it is 
an internal one.  Yes, it is cruft, but backward compatibility sometimes 
requires cruft.  We could deprecate the old api with a message that says it is 
an internal method and should not be used, and see if anyone complains about it 
being deprecated.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Michael Lazar]

Michael Lazar added the comment:

I can certainly do that. Although in addition to adding a keyword argument, we 
would also have to change the return signature to switch between modes like 
this:

if lineno is None:
return caps
else:
return caps, lineno

Overall I'm not a fan of this technique and would like to avoid it if possible. 
The problem is that we have to keep track of the current line between 
successive calls to readmailcapfile(). An alternative would be to go back to 
using lineno as a generator. This is close to what I had in the initial patch.

lineno = itertools.count()
caps = readmailcapfile(fp, lineno=lineno)
caps = readmailcapfile(fp2, lineno=lineno)
caps = readmailcapfile(fp3, lineno=lineno)
...etc

Happy to hear any insights you have on this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[R. David Murray]

R. David Murray added the comment:

I think we need to preserve backward compatibility in the readmailcapfile 
function even though it isn't technically a public API (make lineno a keyword 
argument and the behavior dependent on its presence).  I haven't experimented 
with the patch yet, but it looks reasonable.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Michael Lazar]

Michael Lazar added the comment:

Submitting an updated patch; simplified the implementation and updated 
test_mailcap.py

--
Added file: http://bugs.python.org/file43695/mailcap_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Michael Lazar]

Michael Lazar added the comment:

Alright thanks, I've submitted a patch

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Michael Lazar]

Changes by Michael Lazar :


--
keywords: +patch
Added file: http://bugs.python.org/file43682/mailcap.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[R. David Murray]

R. David Murray added the comment:

Submit it as a proposed patch here for review, please.  git or hg diff against 
the default branch, or a pointer to an hg clone with the patch applied.

--
versions: +Python 3.5, Python 3.6 -Python 2.7, Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Michael Lazar]

Michael Lazar added the comment:

Hello. In my opinion this is a pretty major deficiency. I was trying to add 
definitions to my ~/.mailcap file (which should take priority over system 
mailcap files) but they weren't getting applied because of the wildcard bug. 
This was prohibiting me from using mailcap, so I wrote a patch and submitted it 
to PyPI. I've never contributed before; what would be the first step towards 
submitting this to python?

https://github.com/michael-lazar/mailcap_fix
https://pypi.python.org/pypi/mailcap-fix/0.1.0

--
nosy: +michael-lazar

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Petri Lehtinen]

Petri Lehtinen added the comment:

Sounds like a bug to me.

It's not too straightforward to fix, though. The order of MIME types is lost 
because they are stored as keys of a dict. AFAICS, it wouldn't help to use 
OrderedDict and checking for the wildcard type first if its index is smaller. 
Example:

image/*; foo %s; test=/bin/false
image/jpeg; bar %s; test=/bin/true
image/*; baz %s; test=/bin/true

In this case, the image/jpeg entry should be returned, but both image/* entries 
get grouped together, so they would be evaluated first and the baz %s entry 
would be returned.

The API expects the result of getcaps() (a dict) to be passed to findmatch(), 
which makes it very hard to change the caps representation. The only way I can 
think of would be to change the representation to a dict subclass with extra 
semantics. Plain dict would still have to be supported for backwards 
compatibility, though.

--
nosy: +petri.lehtinen

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14977
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Petri Lehtinen]

Changes by Petri Lehtinen pe...@digip.org:


--
keywords:  -easy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14977
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[Emmanuel Beffara]

New submission from Emmanuel Beffara m...@beffara.org:

According to RFC 1542, the first matching entry in mailcap files should be used 
for handling a given type. The mailcap module does not respect this rule when 
wildcards are used in some rules, because the lookup function always checks 
entries for a specific type (say image/jpeg) before checking the generic ones 
(image/*). As a consequence, if a user overrides system defaults using a 
generic type, this choice is not satisfied, and the behaviour is inconsistent 
with other tools using mailcap (including the standard run-mailcap).

--
components: Library (Lib)
messages: 162064
nosy: manu-beffara
priority: normal
severity: normal
status: open
title: mailcap does not respect precedence in the presence of wildcards
type: behavior

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14977
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14977] mailcap does not respect precedence in the presence of wildcards

[R. David Murray]

R. David Murray rdmur...@bitdance.com added the comment:

Hmm.  It seems to me this is an edge case as far as backward compatibility 
goes.  On the one hand it does seem like an RFC violation (ie: bug), on the 
other hand there could be user programs depending on the current behavior.  I'm 
inclined toward treating it as a bug, but I can see it being argued the other 
way.  The fact that the file is designed for interoperability and other tools 
do take the wildcard first argues in favor of treating it as a bug, I think.

--
components: +email -Library (Lib)
keywords: +easy
nosy: +barry, r.david.murray
versions: +Python 2.7, Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14977
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com