[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Roundup Robot]

Roundup Robot added the comment:

New changeset 1bbf8c263d3c by R David Murray in branch 'default':
Merge and update #17282: Document unittest.main defaultTest argument.
http://hg.python.org/cpython/rev/1bbf8c263d3c

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Chris Jerdonek]

Chris Jerdonek added the comment:

> *defaultTest* should probably also be documented in the text

I created issue 17282 for this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4285d13fd3dc by Chris Jerdonek in branch 'default':
Add a "Changed in version" to the docs for issue #15132.
http://hg.python.org/cpython/rev/4285d13fd3dc

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Chris Jerdonek]

Chris Jerdonek added the comment:

I can take care of the Changed in version.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Chris Jerdonek]

Chris Jerdonek added the comment:

Thanks, Jyrki and Petri.  I just noticed that a "Changed in version" should 
probably be added at the end of this section:

http://docs.python.org/dev/library/unittest.html#unittest.main

*defaultTest* should probably also be documented in the text (it currently 
appears only in the documentation signature), though this part of my comment 
need not be done as part of this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Petri Lehtinen]

Petri Lehtinen added the comment:

Applied, thanks!

--
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Roundup Robot]

Roundup Robot added the comment:

New changeset 4e2bfe6b227a by Petri Lehtinen in branch 'default':
Issue #15132: Allow a list for the defaultTest argument of unittest.TestProgram
http://hg.python.org/cpython/rev/4e2bfe6b227a

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Jyrki Pulliainen]

Changes by Jyrki Pulliainen :


Added file: http://bugs.python.org/file28126/issue15132_py3_no_convert.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Jyrki Pulliainen]

Jyrki Pulliainen added the comment:

Yeah, I added the convert names call mostly to make the behavior the same as 
with passing things from command line.

However, then we should probably wrap the case of str argument to _convert_name 
and the conversion behavior might be bit too implicit.

I added another patch which does not do the convert_names, but just makes it a 
list

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Chris Jerdonek]

Chris Jerdonek added the comment:

To clarify, I didn't say that _convert_names() should be used.  I was just 
noting that it returns a list.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Jyrki Pulliainen]

Changes by Jyrki Pulliainen :


Removed file: http://bugs.python.org/file27681/issue15132_py2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Jyrki Pulliainen]

Jyrki Pulliainen added the comment:

I rebased this change on top of 3.4 and in case of an iterable argument it now 
uses the _convert_names function to convert it to a list of test names.

--
Added file: http://bugs.python.org/file28112/issue15132_py3_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Michael Foord]

Changes by Michael Foord :


--
assignee:  -> michael.foord

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Chris Jerdonek]

Chris Jerdonek added the comment:

Thanks for the patch.

-self.testNames = (self.defaultTest,)
+if isinstance(self.defaultTest, str):
+self.testNames = (self.defaultTest,)
+else:
+self.testNames = tuple(self.defaultTest)

Is there any reason this is a tuple instead of a list?  A list would be more 
flexible.  In contrast, the _convert_names() function used in this line of code 
sets self.testNames to be a list of test names:

self.testNames = _convert_names(args)

(from http://hg.python.org/cpython/file/8576bf1c0302/Lib/unittest/main.py#l161 )

By the way, this can only go into Python 3.4 as it is an enhancement.

--
versions: +Python 3.4 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Jyrki Pulliainen]

Changes by Jyrki Pulliainen :


Added file: http://bugs.python.org/file27682/issue15132_py3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Jyrki Pulliainen]

Jyrki Pulliainen added the comment:

Added a patch for passing everything of not type basestring to tuple 
constructor and assigns that to testnames.

--
keywords: +patch
nosy: +nailor
Added file: http://bugs.python.org/file27681/issue15132_py2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Petri Lehtinen]

Changes by Petri Lehtinen :


--
nosy: +petri.lehtinen

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Ezio Melotti]

Changes by Ezio Melotti :


--
nosy: +ezio.melotti, michael.foord

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15132] Let unittest.TestProgram()'s defaultTest argument be a list

[Chris Jerdonek]

New submission from Chris Jerdonek :

It would be nice if unittest.TestProgram(), aka unittest.main(), allowed one to 
set self.testNames by programmatically passing in a list of test names.

Currently, unittest.main() almost allows this: the constructor sets 
self.testNames to a 1-tuple containing the value of the defaultTest argument.  
But defaultTest can only be a string, not a list of test names.

A way around this is to pass the test names explicitly via the argv argument, 
but this seems less elegant as a programmatic API.  Moreover, this approach 
isn't equivalent because test names passed via argv first get passed to a 
_convert_names() function.

It seems like it would be a natural and simple change to enhance 
unittest.TestProgram() to accept not just a name but also a list of names for 
the defaultTest argument.  Thanks.

--
components: Library (Lib)
keywords: easy
messages: 163386
nosy: cjerdonek
priority: normal
severity: normal
status: open
title: Let unittest.TestProgram()'s defaultTest argument be a list
type: enhancement
versions: Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com