[issue1524825] ConfigParser: accept leading whitespace on options+comments
Łukasz Langa luk...@langa.pl added the comment: Implemented as part of issue1682942 since it touches the same code. Moreover, this issue mentions Samba config parsing in the original comment (msg50719) which was not doable without the changes introduced by issue1682942. So I would supersede this issue with issue1682942. One way or the other, they both fly or both go. Michael, can you close this as superseded? -- nosy: +lukasz.langa, michael.foord ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1524825 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1524825] ConfigParser: accept leading whitespace on options+comments
Changes by Michael Foord mich...@voidspace.org.uk: -- resolution: - duplicate stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1524825 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1524825] ConfigParser: accept leading whitespace on options+comments
Changes by Terry J. Reedy tjre...@udel.edu: -- superseder: - ConfigParser support for alt delimiters ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1524825 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1524825] ConfigParser: accept leading whitespace on options+comments
Terry J. Reedy tjre...@udel.edu added the comment: I closed #1714 as a duplicate of this. It also has a patch attached. -- nosy: +akuchling, christian.heimes, msuchy, schmir, tjreedy versions: +Python 3.2 -Python 2.6, Python 3.0 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1524825 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1524825] ConfigParser: accept leading whitespace on options+comments
Jeremy Thurgood [EMAIL PROTECTED] added the comment: This looks very much like a duplicate of issue 1714. Perhaps the two should be merged? -- nosy: +jerith _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1524825 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1524825] ConfigParser: accept leading whitespace on options+comments
Quentin Gallet-Gilles [EMAIL PROTECTED] added the comment: Didn't think a few days would translate into a month. My bad! Anyway, here's the promised patch. -- keywords: +patch Added file: http://bugs.python.org/file9848/cfgparser_comments.patch _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1524825 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1524825] ConfigParser: accept leading whitespace on options+comments
Changes by Raghuram Devarakonda: -- nosy: +draghuram _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1524825 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1524825] ConfigParser: accept leading whitespace on options+comments
Quentin Gallet-Gilles added the comment: Okay, I'll upload a patch with unit tests and doc changes for the comment part in the next few days. _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1524825 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1524825] ConfigParser: accept leading whitespace on options+comments
Ken Lalonde added the comment: Quentin: I didn't appreciate the line-continuation issue. Breaking existing code is out of the question, so I'd like to retract that part of the patch. _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1524825 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1524825] ConfigParser: accept leading whitespace on options+comments
Changes by Georg Brandl: -- type: - feature request versions: +Python 2.6, Python 3.0 _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1524825 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1524825] ConfigParser: accept leading whitespace on options+comments
Changes by Facundo Batista: -- keywords: +easy -patch _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1524825 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1524825] ConfigParser: accept leading whitespace on options+comments
Quentin Gallet-Gilles added the comment: I tried to come up with a patch, but the issue isn't as easy as it seems, the proposed change is too simplistic. Leading spaces in a line is already used for one purpose : continuations of a previous line. For instance : option = value continued here gives option as key and value\n continued here as value. The proposal conflicts with this behavior, since having : option1 = value1 option2 = value2 creates only one key-value pair option1:value1\n option2=value2 Adding blank lines doesn't solve the issue. The only case when it's treated correctly is when the options is the first one of a section/file: there's no continuation since there's no previous option defined. One solution could be to check for the presence of a delimiter (colon or equals sign) and not treat it as a continuation if that's the case, but that could potentially break existing configurations files, since nothing forbids you from using delimiters in the values. Any opinion ? (By the way, the leading whitespaces for comments isn't affected by all this, the implementation is simple) -- nosy: +quentin.gallet-gilles _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1524825 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
