[issue15450] Allow dircmp.subdirs to behave well under subclassing

2020-11-23 Thread Andrew Svetlov 


Change by Andrew Svetlov :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2020-11-23 Thread Andrew Svetlov 


Andrew Svetlov  added the comment:


New changeset 2f2f9d0b5c96e68ed91cddd6673860ee752eb49c by Nick Crews in branch 
'master':
bpo-15450: Allow subclassing of dircmp (GH-23424) (#23424)
https://github.com/python/cpython/commit/2f2f9d0b5c96e68ed91cddd6673860ee752eb49c


--
nosy: +asvetlov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2020-11-20 Thread Nick Crews 


Nick Crews  added the comment:

I re-did this at https://github.com/python/cpython/pull/23424, let me know what 
you think. This is my first PR here, so I may have pooched something.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2020-11-20 Thread Nick Crews 


Change by Nick Crews :


--
nosy: +NickCrews
nosy_count: 5.0 -> 6.0
pull_requests: +22316
pull_request: https://github.com/python/cpython/pull/23424

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2018-01-03 Thread Mitar 

Change by Mitar :


--
pull_requests: +4962

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2018-01-03 Thread Mitar 

Change by Mitar :


--
nosy: +mitar

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2012-12-27 Thread Hynek Schlawack 

Changes by Hynek Schlawack h...@ox.cx:


--
nosy: +hynek

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15450
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2012-10-17 Thread Petri Lehtinen 

Changes by Petri Lehtinen pe...@digip.org:


--
keywords: +patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15450
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2012-07-31 Thread Chris Jerdonek 

Changes by Chris Jerdonek chris.jerdo...@gmail.com:


--
nosy: +cbc

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15450
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2012-07-27 Thread Chris Jerdonek 

Chris Jerdonek chris.jerdo...@gmail.com added the comment:

Updating patch to include documentation changes.

--
keywords:  -patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file26551/issue-15450-2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15450
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2012-07-27 Thread Chris Jerdonek 

Changes by Chris Jerdonek chris.jerdo...@gmail.com:


--
nosy: +eli.bendersky

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15450
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2012-07-26 Thread Chris Jerdonek 

Chris Jerdonek chris.jerdo...@gmail.com added the comment:

Adding a patch with a failing test for the issue.

--
keywords: +patch
stage:  - needs patch
Added file: http://bugs.python.org/file26531/issue-15450-failing-test.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15450
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2012-07-26 Thread Chris Jerdonek 

Chris Jerdonek chris.jerdo...@gmail.com added the comment:

Attaching full patch (though Misc/NEWS would need to be moved a new section is 
created for pre-alpha).

--
Added file: http://bugs.python.org/file26532/issue-15450-1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15450
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2012-07-26 Thread Chris Jerdonek 

Changes by Chris Jerdonek chris.jerdo...@gmail.com:


--
stage: needs patch - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15450
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2012-07-26 Thread Chris Jerdonek 

Chris Jerdonek chris.jerdo...@gmail.com added the comment:

Actually, this should also be documented.

--
stage: patch review - needs patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15450
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15450] Allow dircmp.subdirs to behave well under subclassing

2012-07-25 Thread Chris Jerdonek 

New submission from Chris Jerdonek chris.jerdo...@gmail.com:

Currently, the subdirs attribute of filecmp.dircmp does not respect subclassing:

 from filecmp import dircmp
 class MyDirCmp(dircmp):
...   pass
... 
 my_dcmp = MyDirCmp('dir1', 'dir2')
 for item in my_dcmp.subdirs.values():
...   print(type(item))
...   break
... 
class 'filecmp.dircmp'

This is the only place where dircmp does not respect subclassing.  It can be 
corrected here:

def phase4(self): # Find out differences between common subdirectories
...
...
self.subdirs[x]  = dircmp(a_x, b_x, self.ignore, self.hide)

This would let one do things like override dircmp.report() and have 
dircmp.report_full_closure() behave as expected.

--
components: Library (Lib)
keywords: easy
messages: 166443
nosy: cjerdonek
priority: normal
severity: normal
status: open
title: Allow dircmp.subdirs to behave well under subclassing
type: enhancement
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15450
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com