[issue15539] Fixing Tools/scripts/pindent.py
Andrew Svetlov added the comment: Is it fixed now? -- nosy: +asvetlov ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Serhiy Storchaka added the comment: Yes, it's fixed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Changes by Serhiy Storchaka storch...@gmail.com: -- stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Roundup Robot added the comment: New changeset f783db4a58ba by Serhiy Storchaka in branch '2.7': Issue #15539: Fix a number of bugs in Tools/scripts/pindent.py. http://hg.python.org/cpython/rev/f783db4a58ba New changeset 9df6b707aef9 by Serhiy Storchaka in branch '3.2': Issue #15539: Fix a number of bugs in Tools/scripts/pindent.py. http://hg.python.org/cpython/rev/9df6b707aef9 New changeset 01df1f7841b2 by Serhiy Storchaka in branch '3.3': Issue #15539: Fix a number of bugs in Tools/scripts/pindent.py. http://hg.python.org/cpython/rev/01df1f7841b2 New changeset 8452c23139c6 by Serhiy Storchaka in branch 'default': Issue #15539: Fix a number of bugs in Tools/scripts/pindent.py. http://hg.python.org/cpython/rev/8452c23139c6 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Ezio Melotti added the comment: Some buildbots are failing: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%202.7/builds/341/steps/test/logs/stdio http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/1263/steps/test/logs/stdio -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Serhiy Storchaka added the comment: Here is a patch which should fix creating a backup on Windows. Please test it. If test_tools passes on Windows then I'll commit the patch, in contrary case I'll just skip checking of backup on Windows. -- stage: committed/rejected - patch review status: closed - open Added file: http://bugs.python.org/file28695/pindent_backup.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Roundup Robot added the comment: New changeset 2d0c5f97af48 by Serhiy Storchaka in branch '2.7': Issue #15539: Fix backup file creation in pindent.py on Windows http://hg.python.org/cpython/rev/2d0c5f97af48 New changeset a9990104f728 by Serhiy Storchaka in branch '3.2': Issue #15539: Fix a backup file creation in pindent.py on Windows. http://hg.python.org/cpython/rev/a9990104f728 New changeset 735361e8709e by Serhiy Storchaka in branch '3.3': Issue #15539: Fix a backup file creation in pindent.py on Windows. http://hg.python.org/cpython/rev/735361e8709e New changeset c46dec051819 by Serhiy Storchaka in branch 'default': Issue #15539: Fix a backup file creation in pindent.py on Windows. http://hg.python.org/cpython/rev/c46dec051819 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Serhiy Storchaka added the comment: I hope it will help buidbots. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Serhiy Storchaka added the comment: If no one objects I will commit this next year. -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Serhiy Storchaka added the comment: Patch updated. Tests added. I am not sure tests will be passed on Windows. -- Added file: http://bugs.python.org/file28224/pindent_2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Serhiy Storchaka added the comment: 5. Fixed one type in help message. Typo. Should be Fixed one typo in help message. Patch updated, unused experimental variable removed. -- Added file: http://bugs.python.org/file26696/pindent.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file26665/pindent.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Serhiy Storchaka added the comment: There is now a test_tools, so it would be great to have tests to go along with this patch. Well, I'll do it. But the tests most likely will be different for different versions of Python (in contrast to the pindent patch). pindent -d and then pindent -c on pindent.py must give the original of pindent.py. It exposes some of the above mentioned bugs. I haven't looked at the patch in detail, but as long as you are modernizing it please kill those # end ... lines. This is done deliberately. It demonstrates the purpose of the script. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
Changes by Serhiy Storchaka storch...@gmail.com: -- keywords: +needs review priority: normal - low stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
R. David Murray added the comment: There is now a test_tools, so it would be great to have tests to go along with this patch. I haven't looked at the patch in detail, but as long as you are modernizing it please kill those # end ... lines. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15539] Fixing Tools/scripts/pindent.py
New submission from Serhiy Storchaka: Here is a patch which fixes some bugs in Tools/scripts/pindent.py and modernizes it with regard to the new Python features abilities that have made since 1994. 1. Now pindent works with with. 2. Now pindent does not produce improper indentation (tabs by default for space-indented file). It uses for the end-marks indentation the same sequence of whitespaces that for start operator indentation. 3. Now pindent works with escaped newline \\\n at start of line and after class and def. 4. Now pindent does not produce indentation for empty line. 5. Fixed one type in help message. 6. Using io.StringIO. 7. Using booleans, augmented assignments, list.pop(), with operators, etc. -- components: Demos and Tools files: pindent.patch keywords: patch messages: 167239 nosy: storchaka priority: normal severity: normal status: open title: Fixing Tools/scripts/pindent.py type: behavior versions: Python 2.7, Python 3.2, Python 3.3 Added file: http://bugs.python.org/file26665/pindent.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15539 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
