[issue16089] _elementtree.TreeBuilder broken with a non-C-deriving element_factory
Dmitry Shachnev added the comment: There are still some false-positive warnings caused by C code that affect docutils (see http://sourceforge.net/tracker/?func=detailatid=422030aid=3555164group_id=38414). Look at this traceback for exmaple: http://paste.ubuntu.com/1345164/ There, _ElementInterfaceWrapper is a subclass of etree._ElementInterface (http://repo.or.cz/w/docutils.git/blob/HEAD:/docutils/docutils/writers/odf_odt/__init__.py#l91). -- nosy: +larry, mitya57 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16089 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16089] _elementtree.TreeBuilder broken with a non-C-deriving element_factory
Changes by Dmitry Shachnev mity...@gmail.com: ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16089 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16089] _elementtree.TreeBuilder broken with a non-C-deriving element_factory
Changes by Dmitry Shachnev mity...@gmail.com: ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16089 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16089] _elementtree.TreeBuilder broken with a non-C-deriving element_factory
Roundup Robot added the comment: New changeset 7bd9626d8b4f by Antoine Pitrou in branch '3.3': Issue #16089: Allow ElementTree.TreeBuilder to work again with a non-Element element_factory (fixes a regression in SimpleTAL). http://hg.python.org/cpython/rev/7bd9626d8b4f New changeset a8c044188731 by Antoine Pitrou in branch 'default': Issue #16089: Allow ElementTree.TreeBuilder to work again with a non-Element element_factory (fixes a regression in SimpleTAL). http://hg.python.org/cpython/rev/a8c044188731 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16089 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16089] _elementtree.TreeBuilder broken with a non-C-deriving element_factory
Changes by Antoine Pitrou pit...@free.fr: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16089 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16089] _elementtree.TreeBuilder broken with a non-C-deriving element_factory
Eli Bendersky added the comment: Antoine, Thanks! You said : the coding style there is quite old It would be great if you could elaborate, however briefly, if there's anything else besides your fixes that is old and should be modernized. I will admit to writing some of that code very recently, but that's mostly because I was trying to follow the existing coding style of the module, which was written a long time ago. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16089 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16089] _elementtree.TreeBuilder broken with a non-C-deriving element_factory
Antoine Pitrou added the comment: the coding style there is quite old It would be great if you could elaborate, however briefly, if there's anything else besides your fixes that is old and should be modernized. I will admit to writing some of that code very recently, but that's mostly because I was trying to follow the existing coding style of the module, which was written a long time ago. I don't think that's you. I was talking about some of the cruft I removed (such as list_join() which was going through complicated hoops instead of calling PyUnicode_Join(), or manual filling of tuples instead of calling PyTuple_Pack()). There are still issues with internal functions stealing references and such. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16089 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16089] _elementtree.TreeBuilder broken with a non-C-deriving element_factory
Eli Bendersky added the comment: Ah, OK. I was actually putting off refactorings in that code to after refactoring the test suite. The latter is in progress, it was paused by my vacation but I do plan to resume it eventually. Once the test suite is sufficiently humane (esp. moves off doctest to enable normal testing of multiple modules with the same set of tests) the refactoring should become easier. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16089 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16089] _elementtree.TreeBuilder broken with a non-C-deriving element_factory
Antoine Pitrou added the comment: Here is a patch. It still needs some tests. -- title: _elementtree causes segfault in GC - _elementtree.TreeBuilder broken with a non-C-deriving element_factory Added file: http://bugs.python.org/file27392/c_treebuilder.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16089 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16089] _elementtree.TreeBuilder broken with a non-C-deriving element_factory
Antoine Pitrou added the comment: Updated patch with tests. -- stage: needs patch - patch review Added file: http://bugs.python.org/file27393/c_treebuilder2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16089 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
