[issue1611944] sndhdr.what() does not recognize wav file

[Georg Brandl]

Change by Georg Brandl :


--
nosy:  -georg.brandl

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1611944] sndhdr.what() does not recognize wav file

[Mark Lawrence]

Changes by Mark Lawrence breamore...@yahoo.co.uk:


--
stage:  - unit test needed
type:  - behavior
versions: +Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1611944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1611944] sndhdr.what() does not recognize wav file

[Matthijs Kooijman]

Matthijs Kooijman [EMAIL PROTECTED] added the comment:

I've written a new patch, which works a bit better. You can find the new
patch attached.

I've restructed the patch to prevent code duplication. Also, it now
works with other chunks than bext (I had a file with a list chunk which
triggered my interest in this bug). This is done with a hardcoded list
of valid chunks. However, it seems that there is no complete list of
valid chunk types, so it might be better to remove the chunk type check
alltogether.

Also, this patch explicitly checks for overflow, since taking a slice of
a sequence does not seem to trigger an IndexError, but just return an
empty sequence.

--
keywords: +patch
nosy: +matthijs
Added file: http://bugs.python.org/file11501/sndhdr.diff

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1611944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1611944] sndhdr.what() does not recognize wav file

[Benjamin Peterson]

Changes by Benjamin Peterson [EMAIL PROTECTED]:


--
versions: +Python 2.7, Python 3.1 -Python 2.5

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue1611944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com