[issue16296] Patch to fix building on Win32/64 under VS 2010

[Steve Dower]

Change by Steve Dower :


--
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Ralf Gommers]

Ralf Gommers added the comment:

I'll note that in Numpy we have now worked around the issue (with 
https://github.com/numpy/numpy/pull/4892), basically by monkeypatching 
distutils and doing:

if '/MANIFEST' not in ldflags:
ldflags.append('/MANIFEST')

The bug report is still valid though; it should not be specific to numpy. A 
more detailed report of what was broken before and fixed by this patch would 
have been helpful. I cannot be sure that this is 100% correct because I don't 
have Windows+MSVC available, but it should be this:

- Take Python 3.4 installed from the python.org .exe installer
- Create a new virtualenv and activate it
- pip install numpy==1.8.0   # this will fail
- apply the patch
- pip install numpy==1.8.0   # this will work

Furthermore I think that this is a duplicate of 
http://bugs.python.org/issue4431, which is also a valid bug report confirmed by 
multiple people (but closed as not a bug). 

Given that applying the patch is harmless and not applying it clearly does 
create problems for users, it would make sense to apply it. But honestly, given 
for how long the bug reports on 4431 were ignored, I'm not willing to spend 
much effort on this. So if no one else does either, this issue may indeed just 
as well be closed as outdated like Marc Lawrence suggests.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Mark Lawrence]

Mark Lawrence added the comment:

I think this can now be closed as out of date.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Steve Dower]

Steve Dower added the comment:

It doesn't apply to 3.5 or later, so it's up to Martin whether he wants to 
apply it for 3.4. (I suspect not, but I'm not about to preempt his call.)

--
versions:  -Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Brian Curtin]

Changes by Brian Curtin br...@python.org:


--
nosy:  -brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[irdb]

Changes by irdb dalba.w...@gmail.com:


--
nosy: +irdb

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Zachary Ware]

Changes by Zachary Ware zachary.w...@gmail.com:


--
components: +Distutils -Build, Windows
nosy: +dstufft, eric.araujo -zach.ware
status: languishing - open
type: compile error - behavior
versions: +Python 3.5 -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Zachary Ware]

Changes by Zachary Ware zachary.w...@gmail.com:


--
components: +Windows

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Mark Lawrence]

Mark Lawrence added the comment:

Can somebody reset the status to open please.

--
nosy: +BreamoreBoy, steve.dower, zach.ware

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Max Naumov]

Max Naumov added the comment:

Wouldn't this be more correct?
--- Lib/distutils/msvc9compiler.py  2013-08-03T16:17:08+04:00
+++ Lib/distutils/msvc9compiler.py  2014-03-17T18:36:50.078672+04:00
@@ -411,7 +411,11 @@
   '/Z7', '/D_DEBUG']
 
 self.ldflags_shared = ['/DLL', '/nologo', '/INCREMENTAL:NO']
-if self.__version = 7:
+if self.__version = 10:
+self.ldflags_shared = [
+'/DLL', '/nologo', '/INCREMENTAL:NO', '/DEBUG', '/pdb:None', 
'/Manifest'
+]
+elif self.__version = 7:
 self.ldflags_shared_debug = [
 '/DLL', '/nologo', '/INCREMENTAL:no', '/DEBUG', '/pdb:None'
 ]

--
nosy: +Max.Naumov
Added file: http://bugs.python.org/file34465/msvc9compilerpatch.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Martin v . Löwis]

Martin v. Löwis added the comment:

What is the procedure to test this patch? Under what circumstances exactly is 
it needed?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Max Naumov]

Max Naumov added the comment:

It allows to install numpy on windows python 3.4. Just like the patch in the 
original post. Actually my patch is merely the original patch refactored.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Paul Moore]

Paul Moore added the comment:

Is there any chance this can be included in Python 3.4? It would apparently 
allow numpy to be built with stock tools on Windows Python.

--
nosy: +pmoore

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Tim Golden]

Tim Golden added the comment:

Larry Hastings would have to rule on whether it could get into 3.4 at
this stage.

Paul: are you in a position to apply / test the patch? I've done no more
than glance at it but it looks, from the comments, as though it doesn't
apply cleanly.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Paul Moore]

Paul Moore added the comment:

Unfortunately not really - it's the numpy guys that need this, so hopefully the 
original poster can comment.

I'll see if I can hand-patch the relevant files and do a pip install numpy to 
see if it fixes that specific scenario. I'll report back.

I've added Larry Hastings to the nosy list for his comments.

--
nosy: +larry

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Paul Moore]

Paul Moore added the comment:

Sigh. Looks like it doesn't fix the issue of building numpy - plus it doesn't 
apply cleanly. My apologies for the noise, I'll report the issues with the 
patch back on the numpy issue where I was told about this patch.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Larry Hastings]

Larry Hastings added the comment:

I'm not sure I need to be on this issue.  As a rule, Windows build concerns for 
3.4 are delegated to Martin von Lowis.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Tim Golden]

Tim Golden added the comment:

Thanks, Larry. Martin's already nosy this issue, but really we need to
see if we have a viable patch before making decisions about 3.4. I'll
take you off the nosy list.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Tim Golden]

Changes by Tim Golden m...@timgolden.me.uk:


--
nosy:  -larry

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Thomas Heller]

Thomas Heller added the comment:

Hm, what's the problem?
For me, the patch applies cleanly (in Python 3.4.0b3, 32-bit and 64-bit on 
Windows), and
  py -3.4(-32) -m pip install numpy
works correctly.  At least
  py -3.4(-32) -c import numpy; print(numpy.__version__)
prints 1.8.0.

This is with the newest pip (1.5.2).

I have the full version of visual studio 2010 installed.

--
nosy: +theller

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Paul Moore]

Paul Moore added the comment:

Maybe it's not applicable to 3.3 somehow, which is what I tried. I applied the 
patch to the distutils in the system installed Python, then ran pip install 
numpy from a virtualenv.

It's quite possible that a million things could have gone wrong in that process 
- but that's all I had time to check (I'm only really interested in this as a 
courtesy to the numpy people, who asked me to raise the bug on numpy, then 
directed me to this patch as a fix).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Ralf Gommers]

Changes by Ralf Gommers ralf.gomm...@gmail.com:


--
nosy: +ralf.gommers

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Christian Heimes]

Changes by Christian Heimes li...@cheimes.de:


--
status: open - languishing

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Trent Nelson]

Changes by Trent Nelson tr...@snakebite.org:


--
nosy: +trent

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Trent Nelson]

Changes by Trent Nelson tr...@snakebite.org:


--
versions:  -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Christoph Gohlke]

Changes by Christoph Gohlke cgoh...@uci.edu:


--
nosy: +cgohlke

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Martin v . Löwis]

Martin v. Löwis added the comment:

Why did you put 3.2 into the version list? 3.2 doesn't use VS 2010.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Silverback Networks]

New submission from Silverback Networks:

Once I got my broken environment fixed, this was the only thing that didn't 
work. The bug is that VS 2010 no longer creates a manifest by default, despite 
the documentation, and there are confirmation posts around the internet. 
/Manifest has to be forced starting with VS 2010. Here is a patch to fix that:


--- Lib/distutils/msvc9compiler.py2011-08-14 11:17:42.0 -0700
+++ Lib/distutils/msvc9compiler.py2012-10-21 10:38:42.257682200 -0700
@@ -411,10 +411,16 @@
   '/Z7', '/D_DEBUG']

 self.ldflags_shared = ['/DLL', '/nologo', '/INCREMENTAL:NO']
+if self.__version = 10:
+self.ldflags_shared = ['/DLL', '/nologo', '/INCREMENTAL:NO', 
'/Manifest']
 if self.__version = 7:
 self.ldflags_shared_debug = [
 '/DLL', '/nologo', '/INCREMENTAL:no', '/DEBUG', '/pdb:None'
 ]
+if self.__version = 10:
+self.ldflags_shared = [
+'/DLL', '/nologo', '/INCREMENTAL:NO', '/DEBUG', '/pdb:None', 
'/Manifest'
+]
 self.ldflags_static = [ '/nologo']

 self.initialized = True

--
components: Build
messages: 173464
nosy: silverbacknet
priority: normal
severity: normal
status: open
title: Patch to fix building on Win32/64 under VS 2010
type: compile error
versions: Python 3.1, Python 3.2, Python 3.3, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Silverback Networks]

Silverback Networks added the comment:

oops, add _debug on the second part of the patch.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Christian Heimes]

Christian Heimes added the comment:

Can you please upload a proper patch files? It makes code review and applying 
the patch easier for us.

--
components: +Windows
keywords: +3.3regression
nosy: +christian.heimes
stage:  - patch review
versions:  -Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Silverback Networks]

Silverback Networks added the comment:

Sure. I got this patch from Mercurial, just in case, but it looks the same.

--
keywords: +patch
Added file: http://bugs.python.org/file27648/msvc9manifest.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16296] Patch to fix building on Win32/64 under VS 2010

[Antoine Pitrou]

Changes by Antoine Pitrou pit...@free.fr:


--
nosy: +brian.curtin, loewis, tim.golden

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16296
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com