[issue16482] pdb.set_trace() clobbering traceback on error

[Irit Katriel]

Change by Irit Katriel :


--
resolution:  -> out of date
stage: patch review -> resolved
status: pending -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Irit Katriel]

Irit Katriel  added the comment:

iritkatriel@Irits-MBP cpython % cat pdb_traceback.py

import pdb

x = 0

while True:
pdb.set_trace()
y = "line of code not triggering an error"
x += 1
assert x != 3
iritkatriel@Irits-MBP cpython % cat pdb_traceback.py

import pdb

x = 0

while True:
pdb.set_trace()
y = "line of code not triggering an error"
x += 1
assert x != 3
iritkatriel@Irits-MBP cpython % ./python.exe pdb_traceback.py
> /Users/iritkatriel/src/cpython/pdb_traceback.py(8)()
-> y = "line of code not triggering an error"
(Pdb) c
> /Users/iritkatriel/src/cpython/pdb_traceback.py(8)()
-> y = "line of code not triggering an error"
(Pdb) c
> /Users/iritkatriel/src/cpython/pdb_traceback.py(8)()
-> y = "line of code not triggering an error"
(Pdb) c
Traceback (most recent call last):
  File "/Users/iritkatriel/src/cpython/pdb_traceback.py", line 10, in 
assert x != 3
^
AssertionError

--
nosy: +iritkatriel
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Aaron Meurer]

Aaron Meurer  added the comment:

You can download the branch for a pull request even if the repo is deleted 
using this https://stackoverflow.com/a/28622034/161801. That will let you keep 
the original commits intact.

--
nosy: +asmeurer

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

I too just hit this issue with pdb and checked out the PR locally. It works 
fine though it has merge conflicts with latest master. I am adding 3.8, 3.7 and 
3.6 removing the older versions that don't support bug fixes. Since the PR has 
unknown repository I suppose @xdegaye has deleted their fork and I don't know 
if the PR can be revived without opening a new one.

I have merged the latest master in my own fork resolving conflicts in case a 
new PR has to be generated : 
https://github.com/python/cpython/compare/master...tirkarthi:pr-6233-latest. 
Adding Serhiy to the issue. The PR also solves many linked issues in the PR and 
I thought to add the update here since it seemed appropriate.

Thanks much @xdegaye for the PR

--
nosy: +serhiy.storchaka, xtreak
versions: +Python 3.6, Python 3.7, Python 3.8 -Python 3.2, Python 3.3, Python 
3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[daniel hahler]

daniel hahler  added the comment:

Just for reference: https://github.com/python/cpython/pull/6233 is about fixing 
this.

--
keywords: +patch
nosy: +blueyed
pull_requests: +5995
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Atsuo Ishimoto]

Change by Atsuo Ishimoto :


--
nosy: +ishimoto

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Aaron Meurer]

Changes by Aaron Meurer asmeu...@gmail.com:


--
nosy: +Aaron.Meurer

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16482
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Peter Inglesby]

Peter Inglesby added the comment:

I've just hit this.  Is there anything I can do to help get this fixed?`

--
nosy: +inglesp

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16482
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Xavier de Gaye]

Xavier de Gaye added the comment:

The last patch proposed at issue 17277 and named traced_frame.patch
fixes also issue 17697, and issues 7238, 16482. IMHO one should remove
the assumption in PyFrame_GetLineNumber() that f_lineno is correct
when f_trace is not NULL, as there does not seem to be a way to remove
the local trace function of a generator frame. The traced_frame patch
does that.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16482
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Xavier de Gaye]

Xavier de Gaye added the comment:

Forgot to say that traced_frame.patch includes a test.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16482
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Ned Deily]

Ned Deily added the comment:

See also Issue17697.  Xavier, would you be willing to submit a patch with a 
test?

--
nosy: +ned.deily
stage:  - needs patch
versions: +Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16482
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Jesús Cea Avión]

Changes by Jesús Cea Avión j...@jcea.es:


--
nosy: +jcea

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16482
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Andrew Svetlov]

Changes by Andrew Svetlov andrew.svet...@gmail.com:


--
nosy: +asvetlov

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16482
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Xavier de Gaye]

Xavier de Gaye added the comment:

See also how it is fixed at
http://code.google.com/p/pdb-clone/source/detail?r=123d1b6db6649f4b54712db321865fda55395488name=default

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16482
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[Xavier de Gaye]

Xavier de Gaye added the comment:

The top level frame line number is not updated because it has a local
trace function while the global trace function is None. This is
related to issue 7238.

The following patch fixes the issue. The patch removes the local trace
at the top level frame and makes sure it is not reinstalled when
returning from the current trace function.

diff --git a/Lib/bdb.py b/Lib/bdb.py
--- a/Lib/bdb.py
+++ b/Lib/bdb.py
@@ -64,6 +64,10 @@
 if self.stop_here(frame) or self.break_here(frame):
 self.user_line(frame)
 if self.quitting: raise BdbQuit
+# Do not re-install the local trace when we are finished debugging,
+# see issues 16482 and 7238.
+if not sys.gettrace():
+return None
 return self.trace_dispatch
 
 def dispatch_call(self, frame, arg):
@@ -231,8 +235,10 @@
 # no breakpoints; run without debugger overhead
 sys.settrace(None)
 frame = sys._getframe().f_back
-while frame and frame is not self.botframe:
+while frame:
 del frame.f_trace
+if frame is self.botframe:
+break
 frame = frame.f_back
 
 def set_quit(self):


The following code is a minimum implementation of pdb with the patch
applied and the associated code to test it.

class Bdb:

def trace_dispatch(self, frame, event, arg):
self.set_continue()
if sys.gettrace():
return self.trace_dispatch

def set_trace(self, frame):
self.botframe = frame
frame.f_trace = self.trace_dispatch
sys.settrace(self.trace_dispatch)

def set_continue(self):
sys.settrace(None)
del self.botframe.f_trace

frame = sys._getframe()
d = Bdb()
d.set_trace(frame)

y = line of code not triggering an error
x = 1
assert x != 1

--
nosy: +xdegaye

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16482
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16482] pdb.set_trace() clobbering traceback on error

[A Kaptur]

New submission from A Kaptur:

pdb.set_trace() is overwriting the actual traceback when exiting with an error. 
 See minimal recreation here: https://gist.github.com/4079971

--
messages: 175630
nosy: akaptur
priority: normal
severity: normal
status: open
title: pdb.set_trace() clobbering traceback on error
type: behavior
versions: Python 2.7, Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16482
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com