[issue16645] Wrong test_extract_hardlink() in test_tarfile.py

2012-12-30 Thread Ezio Melotti 

Ezio Melotti added the comment:

LGTM.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16645] Wrong test_extract_hardlink() in test_tarfile.py

2012-12-30 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka storch...@gmail.com:


--
Removed message: http://bugs.python.org/msg178416

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16645] Wrong test_extract_hardlink() in test_tarfile.py

2012-12-30 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 503b889668fc by Serhiy Storchaka in branch '2.7':
Issue #16645: Fix hardlink extracting test for tarfile.
http://hg.python.org/cpython/rev/503b889668fc

New changeset d42bf4faf3d1 by Serhiy Storchaka in branch '3.2':
Issue #16645: Fix hardlink extracting test for tarfile.
http://hg.python.org/cpython/rev/d42bf4faf3d1

New changeset e1a0901e4ef7 by Serhiy Storchaka in branch '3.3':
Issue #16645: Fix hardlink extracting test for tarfile.
http://hg.python.org/cpython/rev/e1a0901e4ef7

New changeset f173c2e92b64 by Serhiy Storchaka in branch 'default':
Issue #16645: Fix hardlink extracting test for tarfile.
http://hg.python.org/cpython/rev/f173c2e92b64

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16645] Wrong test_extract_hardlink() in test_tarfile.py

2012-12-30 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka storch...@gmail.com:


--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16645] Wrong test_extract_hardlink() in test_tarfile.py

2012-12-28 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

Sorry, Chris.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16645] Wrong test_extract_hardlink() in test_tarfile.py

2012-12-27 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka storch...@gmail.com:


--
assignee:  - serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16645] Wrong test_extract_hardlink() in test_tarfile.py

2012-12-10 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka storch...@gmail.com:


Removed file: 
http://bugs.python.org/file28260/test_tarfile_test_extract_hardlink.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16645] Wrong test_extract_hardlink() in test_tarfile.py

2012-12-10 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka storch...@gmail.com:


Added file: 
http://bugs.python.org/file28275/test_tarfile_test_extract_hardlink.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16645] Wrong test_extract_hardlink() in test_tarfile.py

2012-12-10 Thread Jesús Cea Avión 

Changes by Jesús Cea Avión j...@jcea.es:


--
nosy: +jcea

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16645] Wrong test_extract_hardlink() in test_tarfile.py

2012-12-08 Thread Serhiy Storchaka 

New submission from Serhiy Storchaka:

Test test_extract_hardlink() in Lib/test/test_tarfile.py ran 4 times. First 
time (uncompressed tarfile) it extract symbolic and hard links successfully, 
but in other 3 times (gzipped, bzipped and lzma'ed tarfile) extracting fails 
becouse this links already exists (left from first test). The test just ignore 
this error and other possible errors (error EEXIST raised, but ignored all 
except ENOENT).

Here is a patch, which adds a right cleanup of extracted links.

--
components: Tests
files: test_tarfile_test_extract_hardlink.patch
keywords: patch
messages: 177166
nosy: ezio.melotti, michael.foord, pitrou, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Wrong test_extract_hardlink() in test_tarfile.py
type: behavior
versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4
Added file: 
http://bugs.python.org/file28260/test_tarfile_test_extract_hardlink.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16645
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com