[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

> commit 995d9b92979768125ced4da3a56f755bcdf80f6e introduced a regression: 
> bpo-37603: parsetok(): Assertion `(intptr_t)(int)(a - line_start) == (a - 
> line_start)' failed, when running get-pip.py.

Fixed in https://bugs.python.org/issue39209

--
nosy: +pablogsal
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Lysandros Nikolaou]

Change by Lysandros Nikolaou :


--
pull_requests: +17320
pull_request: https://github.com/python/cpython/pull/17582

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[STINNER Victor]

STINNER Victor  added the comment:

commit 995d9b92979768125ced4da3a56f755bcdf80f6e introduced a regression: 
bpo-37603: parsetok(): Assertion `(intptr_t)(int)(a - line_start) == (a - 
line_start)' failed, when running get-pip.py.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Anthony Sottile]

Anthony Sottile  added the comment:

I agree -- probably safer to not backport to 3.7 in case someone is relying on 
this behaviour.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[INADA Naoki]

INADA Naoki  added the comment:


New changeset 995d9b92979768125ced4da3a56f755bcdf80f6e by INADA Naoki (Anthony 
Sottile) in branch 'master':
bpo-16806: Fix `lineno` and `col_offset` for multi-line string tokens (GH-10021)
https://github.com/python/cpython/commit/995d9b92979768125ced4da3a56f755bcdf80f6e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[INADA Naoki]

INADA Naoki  added the comment:

Should we backport this to 3.7?
AST changes including bugfix affects existing software unexpectedly.

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[INADA Naoki]

Change by INADA Naoki :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Anthony Sottile]

Change by Anthony Sottile :


--
pull_requests: +9361

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Anthony Sottile]

Anthony Sottile  added the comment:

Still a problem in 3.7:

$ python3.7
Python 3.7.0b2 (default, Feb 28 2018, 06:59:18) 
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import ast
>>> ast.parse("""x = '''foo\n'''""").body[-1].value
<_ast.Str object at 0x7fcde6898358>
>>> ast.parse("""x = '''foo\n'''""").body[-1].value.col_offset
-1

--
versions: +Python 3.6, Python 3.7, Python 3.8 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Anthony Sottile]

Anthony Sottile added the comment:

pypy seems to have this right (though I don't know enough about their internals 
to know if cpython can benefit from their patch)

$ venvpypy/bin/pythonPython 2.7.10 (3260adbeba4a, Apr 19 2016, 17:42:20)
[PyPy 5.1.0 with GCC 4.8.4] on linux2
Type "help", "copyright", "credits" or "license" for more information.
 import ast, astpretty
 astpretty.pprint(ast.parse('"""\n"""'))
Module(
body=[
Expr(
lineno=1,
col_offset=0,
value=Str(lineno=1, col_offset=0, s='\n'),
),
],
)

--
nosy: +Anthony Sottile

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Łukasz Langa]

Changes by Łukasz Langa :


--
pull_requests: +1890

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Ivailo Karamanolev]

Ivailo Karamanolev added the comment:

What's the status on this? Anything preventing it getting fixed? Still the same 
in 3.6.1:

>>> import ast
>>> ast.parse("""'''foo\n'''""").body[0].value.col_offset
-1

--
nosy: +karamanolev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Anthony Sottile]

Changes by Anthony Sottile asott...@yelp.com:


--
nosy: +asottile

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16806
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Anthony Sottile]

Anthony Sottile added the comment:

Any updates on this? I'm running into this as well (still a problem in 3.4)

```$ python3.4
Python 3.4.2 (default, Oct 11 2014, 17:59:27) 
[GCC 4.4.3] on linux
Type help, copyright, credits or license for more information.
 import ast
 ast.parse('''foo\n''').body[0].value.col_offset
-1
```

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16806
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Aivar Annamaa]

Changes by Aivar Annamaa aivar.anna...@gmail.com:


--
nosy: +Aivar.Annamaa

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16806
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Terry J. Reedy]

Terry J. Reedy added the comment:

If this is really an 'enhancement', it will only go in 3.4. If it is a 
bug/behavior issue, then it should be marked as such and 2.7,3.2,3.3 selected. 
I have not read the doc and messages well enough to know, so I leave that to 
you and Benjamin.

The patch includes a test. It needs a patch to Misc/ACKS to add Carsten Klein 
between Reid Kleckner and Bastian Kleineidam

--
nosy: +terry.reedy
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16806
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Benjamin Peterson]

Benjamin Peterson added the comment:

I left comments on Rietveld a few days ago.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16806
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Benjamin Peterson]

Changes by Benjamin Peterson benja...@python.org:


--
nosy: +benjamin.peterson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16806
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Carsten Klein]

Carsten Klein added the comment:

I have created a patch for Python 2.7.3 that fixes the issue for that release, 
too.

--
Added file: http://bugs.python.org/file28499/python2.7.3.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16806
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Carsten Klein]

Changes by Carsten Klein carsten.kl...@axn-software.de:


--
title: col_offset is -1 for multiline string expressions resembling docstrings 
- col_offset is -1 and lineno is wrong for multiline string expressions

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16806
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Carsten Klein]

Changes by Carsten Klein carsten.kl...@axn-software.de:


Removed file: http://bugs.python.org/file28477/issue1680.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16806
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

[Carsten Klein]

Changes by Carsten Klein carsten.kl...@axn-software.de:


Added file: http://bugs.python.org/file28478/issue16806.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16806
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com