[issue16931] mention work-around to create diffs in default/non-git mode

[Brett Cannon]

Brett Cannon added the comment:

With the pending migration to git, this probably isn't worth the effort.

--
nosy: +brett.cannon
resolution:  -> out of date
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16931] mention work-around to create diffs in default/non-git mode

[Carol Willing]

Changes by Carol Willing willi...@willingconsulting.com:


--
assignee:  - willingc
nosy: +willingc

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16931
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16931] mention work-around to create diffs in default/non-git mode

[Ezio Melotti]

Ezio Melotti added the comment:

 This can be in a general Mercurial section before the section specific
 to committers, or else spread throughout (e.g. in the FAQ).

FWIW I'm leaning towards making the committing.rst page for committers only, 
and move general instructions for non-committers elsewhere.  For this issue I 
think it might be OK to either add a FAQ about Rietveld that also mentions the 
git format, or possibly include it in a new Rietveld section somewhere in the 
tracker docs (see #13963).

--
stage:  - needs patch
type:  - enhancement

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16931
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16931] mention work-around to create diffs in default/non-git mode

[Chris Jerdonek]

Chris Jerdonek added the comment:

 AFAICT, the recommendation to use hg git format is currently only mentioned 
 in the Committing section 
 (http://docs.python.org/devguide/committing.html#minimal-configuration) but 
 not elsewhere, in particular, not http://docs.python.org/devguide/patch.html.

Good observation.  Personally, I think it makes sense to keep Mercurial 
information for both committers and non-committers (like configuring to use the 
git format) outside of the Mercurial section specific to committers.  This 
can be in a general Mercurial section before the section specific to 
committers, or else spread throughout (e.g. in the FAQ).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16931
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16931] mention work-around to create diffs in default/non-git mode

[Ned Deily]

Ned Deily added the comment:

However this is resolved, the information in the devguide should be consistent. 
 AFAICT, the recommendation to use hg git format is currently only mentioned 
in the Committing section 
(http://docs.python.org/devguide/committing.html#minimal-configuration) but not 
elsewhere, in particular, not http://docs.python.org/devguide/patch.html. (This 
was brought up in Issue10572.) Perhaps both sections could reference a FAQ 
entry which includes the Rietveld caveats.

--
nosy: +ned.deily

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16931
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16931] mention work-around to create diffs in default/non-git mode

[Chris Jerdonek]

New submission from Chris Jerdonek:

This issue is to mention in the devguide how to create diffs with the changeset 
number when --git is configured on.  Perhaps this can be done via a FAQ like: 
How can I get Rietveld to work with a 2.7 patch?

Background: Currently, the devguide recommends configuring Mercurial to use 
--git when making diffs.  However, this causes the changeset ID to be left off 
of patch files and, for example, prevents Rietveld from working with patches to 
non-default branches.  See also this thread:

http://mail.python.org/pipermail/python-dev/2011-March/108765.html

This issue describes a couple work-arounds:

http://bz.selenic.com/show_bug.cgi?id=3761

--
components: Devguide
messages: 179654
nosy: chris.jerdonek, eric.araujo, ezio.melotti, ncoghlan
priority: normal
severity: normal
status: open
title: mention work-around to create diffs in default/non-git mode

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16931
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16931] mention work-around to create diffs in default/non-git mode

[Tshepang Lekhonkhobe]

Changes by Tshepang Lekhonkhobe tshep...@gmail.com:


--
nosy: +tshepang

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16931
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com