[issue17335] FieldStorageClass is messed up

[Georg Brandl]

Georg Brandl added the comment:

I'll keep the class attribute for compatibility, but will remove the local 
assignment.

--
nosy: +georg.brandl

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17335
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17335] FieldStorageClass is messed up

[Roundup Robot]

Roundup Robot added the comment:

New changeset b9d3e99ea516 by Georg Brandl in branch 'default':
Closes #17335: remove no-op assignment.
http://hg.python.org/cpython/rev/b9d3e99ea516

--
nosy: +python-dev
resolution:  - fixed
stage:  - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17335
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17335] FieldStorageClass is messed up

[Neal Norwitz]

New submission from Neal Norwitz:

This problem goes back to 2.6 at least.

In Lib/cgi.py

FieldStorageClass = None

def read_multi(self, environ, keep_blank_values, strict_parsing):
Internal: read a part that is itself multipart.
ib = self.innerboundary
if not valid_boundary(ib):
raise ValueError, 'Invalid boundary in multipart form: %r' % (ib,)
self.list = []
if self.qs_on_post:
for key, value in urlparse.parse_qsl(self.qs_on_post,
self.keep_blank_values, self.strict_parsing):
self.list.append(MiniFieldStorage(key, value))
FieldStorageClass = None

The set of FieldStorageClass is to a local variable, so a no-op since it's 
never read.  The class attribute will always be None unless set outside this 
class (not sure if it is).  It looks like it should just be removed.

--
messages: 183308
nosy: Neal.Norwitz
priority: normal
severity: normal
status: open
title: FieldStorageClass is messed up
versions: Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17335
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com