[issue1736190] asyncore/asynchat patches
Changes by intgr ma...@juffo.org: -- nosy: +intgr ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1736190 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
Giampaolo Rodola' [EMAIL PROTECTED] added the comment: This issue should be closed. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
Josiah Carlson [EMAIL PROTECTED] added the comment: Committed to trunk a bit ago, will be in 3.0 this weekend. -- resolution: - accepted status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
svncodereview [EMAIL PROTECTED] added the comment: Dear GvR, report, New code review comments by josiah.carlson have been published. Please go to http://codereview.appspot.com/744 to read them. Message: Details: http://codereview.appspot.com/744/diff/1/22 File Doc/library/asyncore.rst (right): http://codereview.appspot.com/744/diff/1/22#newcode226 Line 226: A file_dispatcher takes a file descriptor or file object along with an optional On 2008/05/05 22:02:22, GvR wrote: Mind keeping the line length under 80 chars? No problem. Any other comments? Issue Description: http://bugs.python.org/issue1736190 Sincerely, Your friendly code review daemon (http://codereview.appspot.com/). _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
Guido van Rossum [EMAIL PROTECTED] added the comment: FWIW, I've added Giampaolo's latest patch to Rietveld: http://codereview.appspot.com/744 Review comments added there should automatically be CC'ed here. _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
svncodereview [EMAIL PROTECTED] added the comment: Dear [EMAIL PROTECTED], New code review comments by [EMAIL PROTECTED] have been published. Please go to http://codereview.appspot.com/744 to read them. Message: (This is mostly a test of the bug/rietveld integration.) Details: http://codereview.appspot.com/744/diff/1/22 File Doc/library/asyncore.rst (right): http://codereview.appspot.com/744/diff/1/22#newcode226 Line 226: A file_dispatcher takes a file descriptor or file object along with an optional Mind keeping the line length under 80 chars? Issue Description: http://bugs.python.org/issue1736190 Sincerely, Your friendly code review daemon (http://codereview.appspot.com/). -- nosy: +svncodereview _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
Giampaolo Rodola' [EMAIL PROTECTED] added the comment: In attachment the Josiah Carlson's patch who currently seems to have problems in accessing the bug tracker. It should address all the problems raised on python-dev related discussion: http://groups.google.com/group/python-dev2/browse_thread/thread/eec1ddadefe09fd8/40e79742231076b9?lnk=gstq=asyncore#40e79742231076b9 Added file: http://bugs.python.org/file10196/full_async_patch.patch _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
Brett Cannon [EMAIL PROTECTED] added the comment: This is separate from issue1563, right? -- nosy: +brett.cannon _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
Giampaolo Rodola' [EMAIL PROTECTED] added the comment: Yes. _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
Giampaolo Rodola' [EMAIL PROTECTED] added the comment: Are there news about this issue? -- nosy: +gvanrossum _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
Giampaolo Rodola' added the comment: I've discussed a lot with Josiah via e-mail and this is the updated version of the patch including a fix for the two issues raised before. This update has been needed also because the original patch has been out-dated by some commits after r53734 involving the test suite and the documentation, which I both took off this patch. I also re-added simple_producer and fifo classes in asynchat.py since it seems they are needed for passing tests. The test suite has passed on Windows XP using Python 2.6 alpha 1. I have also successfully run the test suite of a project of mine based on asynchat which includes over 40 tests. Added file: http://bugs.python.org/file9587/patch.diff _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
Changes by Daniel Arbuckle: -- nosy: +djarb _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
Changes by Giampaolo Rodola': -- severity: normal - urgent type: - security versions: +Python 2.5 _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
Changes by Giampaolo Rodola': -- severity: urgent - normal type: security - versions: +Python 2.6 -Python 2.5 _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1736190] asyncore/asynchat patches
billiejoex added the comment: The current implementation of asynchat.async_chat.initiate_send method doesn't look at what is specified in ac_out_buffer_size attribute which represents the buffer size of the outgoing data defaulting to a maximum of 4096 bytes to send in a single socket.send() call. Note that this only happens when sending the data by using a producer through the use of the push_with_producer method. This happens because while the older asynchat version used slicing for buffering: num_sent = self.send(self.ac_out_buffer[:obs]) # obs == ac_out_buffer_size ...the newer version just calls self.send using the entire data as argument without caring of what ac_out_buffer_size thinks about it: num_sent = self.send(first) What is specified in ac_out_buffer_size when using a producer is just ignored and the only way to have control over the outgoing data buffer is to operate directly on the producer. _ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue1736190 _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
